WebKit Bugzilla
Attachment 343138 Details for
Bug 186836
: [GTK][WPE][Nicosia] Add name for Nicosia Painting Threads
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186836-20180620165749.patch (text/plain), 4.78 KB, created by
Yusuke Suzuki
on 2018-06-20 00:57:50 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Yusuke Suzuki
Created:
2018-06-20 00:57:50 PDT
Size:
4.78 KB
patch
obsolete
>Subversion Revision: 233004 >diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog >index a9c791b242b29828d64b8d51d4bd6ac25686008d..40341210c45be49cc5752578583d41a8c2505143 100644 >--- a/Source/WTF/ChangeLog >+++ b/Source/WTF/ChangeLog >@@ -1,3 +1,19 @@ >+2018-06-20 Yusuke Suzuki <utatane.tea@gmail.com> >+ >+ [GTK][WPE][Nicosia] Add name for Nicosia Painting Threads >+ https://bugs.webkit.org/show_bug.cgi?id=186836 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ AutomaticThread can take a name for the generated threads now. >+ This patch adds the above ability to WorkerPool. >+ >+ * wtf/WorkerPool.cpp: >+ (WTF::WorkerPool::WorkerPool): >+ * wtf/WorkerPool.h: >+ (WTF::WorkerPool::create): >+ (WTF::WorkerPool::name const): >+ > 2018-06-18 Jiewen Tan <jiewen_tan@apple.com> > > Add a graceful exit for AuthenticationManager::initializeConnection >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 18ba9250868b506c551cbfb5e09349d1602ab1de..c62c43cf5c2de09d433150c644fd9dbde0d57af9 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,15 @@ >+2018-06-20 Yusuke Suzuki <utatane.tea@gmail.com> >+ >+ [GTK][WPE][Nicosia] Add name for Nicosia Painting Threads >+ https://bugs.webkit.org/show_bug.cgi?id=186836 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Use "PaintingThread" name. >+ >+ * platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp: >+ (Nicosia::PaintingEngineThreaded::PaintingEngineThreaded): >+ > 2018-06-19 Antoine Quint <graouts@apple.com> > > [Web Animations] Make imported/mozilla/css-animations/test_pseudoElement-get-animations.html pass reliably >diff --git a/Source/WTF/wtf/WorkerPool.cpp b/Source/WTF/wtf/WorkerPool.cpp >index 3ccb7a2dee6484af842861da5419467eeda5b003..a9d271de0578326f4e4372baf462dda28295f86c 100644 >--- a/Source/WTF/wtf/WorkerPool.cpp >+++ b/Source/WTF/wtf/WorkerPool.cpp >@@ -75,7 +75,7 @@ class WorkerPool::Worker final : public AutomaticThread { > > const char* name() const override > { >- return "Worker Pool"; >+ return m_pool.name(); > } > > private: >@@ -83,10 +83,11 @@ class WorkerPool::Worker final : public AutomaticThread { > Function<void()> m_task; > }; > >-WorkerPool::WorkerPool(unsigned numberOfWorkers, Seconds timeout) >+WorkerPool::WorkerPool(const char* name, unsigned numberOfWorkers, Seconds timeout, const char*) > : m_lock(Box<Lock>::create()) > , m_condition(AutomaticThreadCondition::create()) > , m_timeout(timeout) >+ , m_name(name) > { > LockHolder locker(*m_lock); > for (unsigned i = 0; i < numberOfWorkers; ++i) >diff --git a/Source/WTF/wtf/WorkerPool.h b/Source/WTF/wtf/WorkerPool.h >index b5f4d345dc18a69c302c5984254d0932240e2af3..e48fd791f6b287d6fdae792497d233734656408d 100644 >--- a/Source/WTF/wtf/WorkerPool.h >+++ b/Source/WTF/wtf/WorkerPool.h >@@ -40,17 +40,19 @@ class WorkerPool : public ThreadSafeRefCounted<WorkerPool> { > WTF_EXPORT_PRIVATE ~WorkerPool(); > > // If timeout is infinity, it means AutomaticThread will be never automatically destroyed. >- static Ref<WorkerPool> create(unsigned numberOfWorkers = WTF::numberOfProcessorCores(), Seconds timeout = Seconds::infinity()) >+ static Ref<WorkerPool> create(const char* name, unsigned numberOfWorkers = WTF::numberOfProcessorCores(), Seconds timeout = Seconds::infinity()) > { > ASSERT(numberOfWorkers >= 1); >- return adoptRef(*new WorkerPool(numberOfWorkers, timeout)); >+ return adoptRef(*new WorkerPool(name, numberOfWorkers, timeout)); > } > >+ const char* name() const { return m_name; } >+ > private: > class Worker; > friend class Worker; > >- WTF_EXPORT_PRIVATE WorkerPool(unsigned numberOfWorkers, Seconds timeout); >+ WTF_EXPORT_PRIVATE WorkerPool(const char* name, unsigned numberOfWorkers, Seconds timeout); > > bool shouldSleep(const AbstractLocker&); > >@@ -61,6 +63,7 @@ class WorkerPool : public ThreadSafeRefCounted<WorkerPool> { > unsigned m_numberOfActiveWorkers { 0 }; > Vector<Ref<Worker>> m_workers; > Deque<Function<void()>> m_tasks; >+ const char* m_name; > }; > > } >diff --git a/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp b/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp >index 609d1c301c3f000b93de17cd9e89074c3a457166..60ffbaa019defd3b3a0411fd981222f105cb6ae5 100644 >--- a/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp >+++ b/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp >@@ -60,7 +60,7 @@ static void paintLayer(GraphicsContext& context, GraphicsLayer& layer, const Int > } > > PaintingEngineThreaded::PaintingEngineThreaded(unsigned numThreads) >- : m_workerPool(WorkerPool::create(numThreads)) >+ : m_workerPool(WorkerPool::create("PaintingThread", numThreads)) > { > } >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186836
:
343138
|
343139