Attachment 343137 Details for Bug 186835 – Patch

[patch] Patch

bug-186835-20180620163826.patch (text/plain), 1.38 KB, created by Yusuke Suzuki on 2018-06-20 00:38:27 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2018-06-20 00:38:27 PDT

Size: 1.38 KB

patch

obsolete

>Subversion Revision: 233004
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 408f6f2f2cf77375e8a4c25474721287ca356918..4ba50150463f6a0d34a91e8c458e9755db6e2723 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>
>+
>+        [WPE] Remove warnings by setting nullptr for unused listeners
>+        https://bugs.webkit.org/show_bug.cgi?id=186835
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        frame, axis_source, axis_stop, and axis_discrete are unused.
>+        Setting nullptr explicitly to remove warnings in GCC.
>+
>+        * wpe/backends/WindowViewBackend.cpp:
>+
> 2018-06-19  Leo Balter  <leonardo.balter@gmail.com>
> 
>         [test262-runner] Reduce flakiness of unit tests for the runner
>diff --git a/Tools/wpe/backends/WindowViewBackend.cpp b/Tools/wpe/backends/WindowViewBackend.cpp
>index 8134a1b306f74091119d5346194a6e2a2a222374..d13749abb6a172a5f2d4fbca26c2cabae0577dfc 100644
>--- a/Tools/wpe/backends/WindowViewBackend.cpp
>+++ b/Tools/wpe/backends/WindowViewBackend.cpp
>@@ -182,6 +182,10 @@ const struct wl_pointer_listener WindowViewBackend::s_pointerListener = {
>             window.dispatchInputAxisEvent(&event);
>         }
>     },
>+    nullptr, // frame
>+    nullptr, // axis_source
>+    nullptr, // axis_stop
>+    nullptr, // axis_discrete
> };
> 
> const struct wl_keyboard_listener WindowViewBackend::s_keyboardListener = {

Actions: View | Formatted Diff | Diff

Attachments on bug 186835: 343137