WebKit Bugzilla
Attachment 343135 Details for
Bug 182352
: [SOUP] http/tests/misc/bubble-drag-events.html crashes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
debugging patch
debugging.patch (text/plain), 1.44 KB, created by
Fujii Hironori
on 2018-06-19 23:20:30 PDT
(
hide
)
Description:
debugging patch
Filename:
MIME Type:
Creator:
Fujii Hironori
Created:
2018-06-19 23:20:30 PDT
Size:
1.44 KB
patch
obsolete
>diff --git a/Source/WebKit/NetworkProcess/PingLoad.cpp b/Source/WebKit/NetworkProcess/PingLoad.cpp >index 1aece4792d2..ae56cfaa7ce 100644 >--- a/Source/WebKit/NetworkProcess/PingLoad.cpp >+++ b/Source/WebKit/NetworkProcess/PingLoad.cpp >@@ -76,6 +76,7 @@ PingLoad::~PingLoad() > void PingLoad::didFinish(const ResourceError& error, const ResourceResponse& response) > { > m_completionHandler(error, response); >+ RELEASE_ASSERT(!m_isProtected); > delete this; > } > >@@ -114,7 +115,9 @@ void PingLoad::willPerformHTTPRedirection(ResourceResponse&& redirectResponse, R > void PingLoad::didReceiveChallenge(const AuthenticationChallenge&, ChallengeCompletionHandler&& completionHandler) > { > RELEASE_LOG_IF_ALLOWED("didReceiveChallenge"); >+ m_isProtected = true; > completionHandler(AuthenticationChallengeDisposition::Cancel, { }); >+ m_isProtected = false; > didFinish(ResourceError { String(), 0, currentURL(), ASCIILiteral("Failed HTTP authentication"), ResourceError::Type::AccessControl }); > } > >diff --git a/Source/WebKit/NetworkProcess/PingLoad.h b/Source/WebKit/NetworkProcess/PingLoad.h >index b93815a04bd..d56fdba9e85 100644 >--- a/Source/WebKit/NetworkProcess/PingLoad.h >+++ b/Source/WebKit/NetworkProcess/PingLoad.h >@@ -73,6 +73,7 @@ private: > WebCore::Timer m_timeoutTimer; > UniqueRef<NetworkLoadChecker> m_networkLoadChecker; > std::optional<WebCore::ResourceRequest> m_lastRedirectionRequest; >+ bool m_isProtected { false }; > }; > > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 182352
:
343132
|
343135
|
343141
|
343144
|
343206
|
344406
|
344408
|
344411
|
344414
|
344416
|
344419
|
344568
|
344929
|
345033