Attachment 343115 Details for Bug 186824 – Patch

[patch] Patch

bug-186824-20180619183907.patch (text/plain), 2.31 KB, created by Leo Balter on 2018-06-19 15:39:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Leo Balter

Created: 2018-06-19 15:39:08 PDT

Size: 2.31 KB

patch

obsolete

>Subversion Revision: 232989
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index a313fe797a205615c62cf1b4353d741023468a00..5dec1d3500df6c850b762d49fb406a4cc84e1fa5 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-06-19  Leo Balter  <leonardo.balter@gmail.com>
>+
>+        [test262-runner] Reduce flakiness of unit tests for the runner
>+        https://bugs.webkit.org/show_bug.cgi?id=186824
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/test262/Runner.pm:
>+        (main):
>+        * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl:
>+
> 2018-06-19  Keith Rollin  <krollin@apple.com>
> 
>         Crash running check-webkit-style on webrtc/.../exceptions.py
>diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm
>index 4d9e822d5b2dc15f0b32031062e5462c32f7edcd..66cbafd57806345ea427d5ba1f846c481499429a 100755
>--- a/Tools/Scripts/test262/Runner.pm
>+++ b/Tools/Scripts/test262/Runner.pm
>@@ -345,8 +345,8 @@ sub main {
>             $select->add($child);
>             # each child starts with a file;
>             my $file = shift @files;
>-            chomp $file;
>             if ($file) {
>+                chomp $file;
>                 print $child "$file\n";
>                 $activeChildren++;
>             }
>diff --git a/Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl b/Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl
>index e043860fe5b07f97876c7550a4d780b9ea3cd4cb..6618d2f5fa552866dce8211ea4a2ab231c85404d 100755
>--- a/Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl
>+++ b/Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl
>@@ -47,7 +47,7 @@ if (isWindows() || isCygwin() || isWinCairo()) {
> }
> 
> my $Bin = $FindBin::Bin;
>-my $runner = abs_path("$Bin/../../test262-runner");
>+my $runner = abs_path("$Bin/../../test262-runner -p 1");
> my $mockTest262 = abs_path("$Bin/fixtures");
> 
> 
>@@ -133,7 +133,7 @@ foreach my $testCase (@testCases) {
>     my $exitCode = $? >> 8;
>     my $expectedExitCode = $testCase->{EXITSTATUS};
>     my $testName =  $testCase->{TESTNAME} . " (exit code: $expectedExitCode)";
>-    is($exitCode, $testCase->{EXITSTATUS}, $testName);
>+    is($exitCode, $expectedExitCode, $testName);
> 
>     # Test the number of occurences of string "! NEW FAIL"
>     my @newFailCount = $output =~ /! NEW FAIL/g;

Actions: View | Formatted Diff | Diff

Attachments on bug 186824: 343115