WebKit Bugzilla
Attachment 343095 Details for
Bug 186816
: Crash running check-webkit-style on webrtc/.../exceptions.py
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186816-20180619140228.patch (text/plain), 2.36 KB, created by
Keith Rollin
on 2018-06-19 14:02:29 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Keith Rollin
Created:
2018-06-19 14:02:29 PDT
Size:
2.36 KB
patch
obsolete
>Subversion Revision: 232933 >diff --git a/Tools/ChangeLog b/Tools/ChangeLog >index 292ef55aafd6fbdc9e94edfa0ae9d110e376c22a..f806850c50b6f90ea999c28e9b5d2e6cc0bf829a 100644 >--- a/Tools/ChangeLog >+++ b/Tools/ChangeLog >@@ -1,3 +1,18 @@ >+2018-06-19 Keith Rollin <krollin@apple.com> >+ >+ Crash running check-webkit-style on webrtc/.../exceptions.py >+ https://bugs.webkit.org/show_bug.cgi?id=186816 >+ <rdar://problem/41262553> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ It's not apparent to me why the crash is occurring. Trying to write a >+ unittest that checks this file in isolation does not reproduce the >+ crash. But the crash goes away when updating to pylint-0.25.2. >+ >+ * Scripts/webkitpy/thirdparty/__init__.py: >+ (AutoinstallImportHook._install_pylint): >+ > 2018-06-18 Keith Rollin <krollin@apple.com> > > cpp style checker needs to know more about NOLINT >diff --git a/Tools/Scripts/webkitpy/thirdparty/__init__.py b/Tools/Scripts/webkitpy/thirdparty/__init__.py >index 5f3814548cc16269c313c3001c54dfa516961d38..6ca117ddbb2d7cb638834ff0133bc66eb2746775 100644 >--- a/Tools/Scripts/webkitpy/thirdparty/__init__.py >+++ b/Tools/Scripts/webkitpy/thirdparty/__init__.py >@@ -160,7 +160,7 @@ class AutoinstallImportHook(object): > files_to_remove = ['test/data/write_protected_file.txt'] > installer.install("https://pypi.python.org/packages/source/l/logilab-common/logilab-common-0.58.1.tar.gz#md5=77298ab2d8bb8b4af9219791e7cee8ce", url_subpath="logilab-common-0.58.1", target_name="logilab/common", files_to_remove=files_to_remove) > installer.install("https://pypi.python.org/packages/source/l/logilab-astng/logilab-astng-0.24.1.tar.gz#md5=ddaf66e4d85714d9c47a46d4bed406de", url_subpath="logilab-astng-0.24.1", target_name="logilab/astng") >- installer.install('https://pypi.python.org/packages/source/p/pylint/pylint-0.25.1.tar.gz#md5=728bbc2b339bc3749af013709a7f87a5', url_subpath="pylint-0.25.1", target_name="pylint") >+ installer.install('https://pypi.python.org/packages/source/p/pylint/pylint-0.25.2.tar.gz#md5=d878d7688a4f5290dc5b53a836872400', url_subpath="pylint-0.25.2", target_name="pylint") > > # autoinstalled.buildbot is used by BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py > # and should ideally match the version of BuildBot used at build.webkit.org.
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186816
: 343095