Attachment 343039 Details for Bug 186801 – Patch

[patch] Patch

bug-186801-20180619120132.patch (text/plain), 3.72 KB, created by Miguel Gomez on 2018-06-19 03:01:34 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Miguel Gomez

Created: 2018-06-19 03:01:34 PDT

Size: 3.72 KB

patch

obsolete

>Subversion Revision: 232956
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 5a8027ccff3a51c60a6e02ef1d33e9a787499b2a..6738c9f45967a9983245d38f5e12094ab0f1ca51 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-06-19  Miguel Gomez  <magomez@igalia.com>
>+
>+        [GTK][WPE][Nicosia] Add environment variable to enable threaded rendering and set the number of painting threads
>+        https://bugs.webkit.org/show_bug.cgi?id=186801
>+
>+        Reviewed by Carlos Garcia Campos.
>+
>+        Add and environment variable to enable the usage of the threaded renderer and define the number
>+        of painting threads.
>+
>+        No new tests.
>+
>+        * platform/graphics/nicosia/NicosiaPaintingEngine.cpp:
>+        (Nicosia::PaintingEngine::create):
>+        * platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp:
>+        (Nicosia::PaintingEngineThreaded::PaintingEngineThreaded):
>+        * platform/graphics/nicosia/NicosiaPaintingEngineThreaded.h:
>+
> 2018-06-19  Youenn Fablet  <youenn@apple.com>
> 
>         RTCRtpSender.replaceTrack(null) ends current track
>diff --git a/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp b/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp
>index 6de3509a84cff6ae258f86af06acdbafeab9ea55..3bd9bf3237091e8c7697878a992ec65b0f97565b 100644
>--- a/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp
>+++ b/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp
>@@ -30,11 +30,26 @@
> #include "NicosiaPaintingEngine.h"
> 
> #include "NicosiaPaintingEngineBasic.h"
>+#include "NicosiaPaintingEngineThreaded.h"
> 
> namespace Nicosia {
> 
> std::unique_ptr<PaintingEngine> PaintingEngine::create()
> {
>+#if ENABLE(DEVELOPER_MODE)
>+    if (const char* numThreadsEnv = getenv("WEBKIT_NICOSIA_PAINTING_THREADS")) {
>+        unsigned numThreads = 0;
>+        if (sscanf(numThreadsEnv, "%u", &numThreads) == 1) {
>+            if (numThreads < 1 || numThreads > 8) {
>+                WTFLogAlways("The number of Nicosia painting threads is not between 1 and 8. Using the default value 4\n");
>+                numThreads = 4;
>+            }
>+
>+            return std::unique_ptr<PaintingEngine>(new PaintingEngineThreaded(numThreads));
>+        }
>+    }
>+#endif
>+
>     return std::unique_ptr<PaintingEngine>(new PaintingEngineBasic);
> }
> 
>diff --git a/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp b/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp
>index 760878bb8ee9f09bb50bbba703c18f25daa21693..609d1c301c3f000b93de17cd9e89074c3a457166 100644
>--- a/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp
>+++ b/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp
>@@ -59,8 +59,8 @@ static void paintLayer(GraphicsContext& context, GraphicsLayer& layer, const Int
>     context.restore();
> }
> 
>-PaintingEngineThreaded::PaintingEngineThreaded()
>-    : m_workerPool(WorkerPool::create(4))
>+PaintingEngineThreaded::PaintingEngineThreaded(unsigned numThreads)
>+    : m_workerPool(WorkerPool::create(numThreads))
> {
> }
> 
>diff --git a/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.h b/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.h
>index f5580bbed2442de38690884926efd66a7807f168..f08055e2b8c599d1ac6cba53113961d7a4edb9ea 100644
>--- a/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.h
>+++ b/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.h
>@@ -37,7 +37,7 @@ namespace Nicosia {
> 
> class PaintingEngineThreaded final : public PaintingEngine {
> public:
>-    PaintingEngineThreaded();
>+    explicit PaintingEngineThreaded(unsigned);
>     virtual ~PaintingEngineThreaded();
> 
> private:

Actions: View | Formatted Diff | Diff

Attachments on bug 186801: 343035 | 343037 | 343039