WebKit Bugzilla
Attachment 343031 Details for
Bug 186800
: [WTF] Coverity scan issues
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186800-20180619105025.patch (text/plain), 2.23 KB, created by
Tomas Popela
on 2018-06-19 01:50:26 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Tomas Popela
Created:
2018-06-19 01:50:26 PDT
Size:
2.23 KB
patch
obsolete
>Subversion Revision: 232929 >diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog >index daf38a3bd6e048cfc8a2c1169ff50cc9f80f0e76..88b9fe0eef888261c9ba2c83c6e61bf23af7dabb 100644 >--- a/Source/WTF/ChangeLog >+++ b/Source/WTF/ChangeLog >@@ -1,3 +1,14 @@ >+2018-06-19 Tomas Popela <tpopela@redhat.com> >+ >+ [WTF] Coverity scan issues >+ https://bugs.webkit.org/show_bug.cgi?id=186800 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * wtf/CheckedArithmetic.h: Swap the operands to multiply(). >+ * wtf/ThreadSpecific.h: Initialize the m_key variable. >+ * wtf/dtoa.cpp: Initialize the next variable. >+ > 2018-06-12 Darin Adler <darin@apple.com> > > [Cocoa] Make some RetainPtr refinements to get more ready for ARC >diff --git a/Source/WTF/wtf/CheckedArithmetic.h b/Source/WTF/wtf/CheckedArithmetic.h >index 31be98b0929b5924bd5dfee55482af8d3807d9ca..e668bf8a8364c6959e146084e77dd64d5af26987 100644 >--- a/Source/WTF/wtf/CheckedArithmetic.h >+++ b/Source/WTF/wtf/CheckedArithmetic.h >@@ -489,7 +489,7 @@ template <typename ResultType> struct ArithmeticOperations<unsigned, int, Result > > static inline bool multiply(int64_t lhs, int64_t rhs, ResultType& result) > { >- return ArithmeticOperations<int, unsigned, ResultType>::multiply(rhs, lhs, result); >+ return ArithmeticOperations<int, unsigned, ResultType>::multiply(lhs, rhs, result); > } > > static inline bool equals(unsigned lhs, int rhs) >diff --git a/Source/WTF/wtf/ThreadSpecific.h b/Source/WTF/wtf/ThreadSpecific.h >index 1be1204cddf694521e82a576b8854237d0b59ee1..fc75b241e9eb6510d8cdd7c3fd0a3c1049b87d8e 100644 >--- a/Source/WTF/wtf/ThreadSpecific.h >+++ b/Source/WTF/wtf/ThreadSpecific.h >@@ -122,7 +122,7 @@ private: > void static THREAD_SPECIFIC_CALL destroy(void* ptr); > > #if USE(PTHREADS) >- pthread_key_t m_key; >+ pthread_key_t m_key { }; > #elif OS(WINDOWS) > int m_index; > #endif >diff --git a/Source/WTF/wtf/dtoa.cpp b/Source/WTF/wtf/dtoa.cpp >index edefd7f884305fc2c20cb3f3bc571a7f980e30f7..7b5f59290101c3abb754c55f1ea4e11a7ec23258 100644 >--- a/Source/WTF/wtf/dtoa.cpp >+++ b/Source/WTF/wtf/dtoa.cpp >@@ -360,7 +360,7 @@ struct P5Node { > public: > P5Node() { } > BigInt val; >- P5Node* next; >+ P5Node* next { nullptr }; > }; > > static P5Node* p5s;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186800
: 343031 |
343049
|
343091