Attachment 343003 Details for Bug 186793 – Patch v1

[patch] Patch v1

bug-186793-20180618185444.patch (text/plain), 3.18 KB, created by David Kilzer (:ddkilzer) on 2018-06-18 18:54:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2018-06-18 18:54:45 PDT

Size: 3.18 KB

patch

obsolete

>Subversion Revision: 232932
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index d45797da3eeef3e4a3cb526a0188a9e58886a90e..1a732fdee9c511979ddf3b6e4e5335b86718dfc7 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-06-18  David Kilzer  <ddkilzer@apple.com>
>+
>+        Add logging when splashboardd enables WebThread
>+        <https://webkit.org/b/186793>
>+        <rdar://problem/41213255>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/RuntimeApplicationChecks.h:
>+        (WebCore::IOSApplication::isSplashBoardd): Add declaration.
>+        * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
>+        (WebCore::IOSApplication::isSplashBoardd): Add implementation.
>+        * platform/ios/wak/WebCoreThread.mm:
>+        (WebThreadEnable): Call RELEASE_LOG_FAULT() if this is called by
>+        splashboardd.
>+
> 2018-06-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
> 
>         [WTF] Remove workarounds needed to support libstdc++-4
>diff --git a/Source/WebCore/platform/RuntimeApplicationChecks.h b/Source/WebCore/platform/RuntimeApplicationChecks.h
>index 94e28f8592e1548338f28116009edc5444e9ec94..7fe2116afe655537c5c6c9d2abed914b97befd73 100644
>--- a/Source/WebCore/platform/RuntimeApplicationChecks.h
>+++ b/Source/WebCore/platform/RuntimeApplicationChecks.h
>@@ -78,6 +78,7 @@ WEBCORE_EXPORT bool isMobileSafari();
> WEBCORE_EXPORT bool isWebBookmarksD();
> bool isDumpRenderTree();
> bool isMobileStore();
>+bool isSplashBoardd();
> bool isSpringBoard();
> WEBCORE_EXPORT bool isWebApp();
> WEBCORE_EXPORT bool isWebProcess();
>diff --git a/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm b/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
>index 2f379a3da2d317e66a534cd55e0fa67179c2bdac..6dd91514ba187817c7bb593eeb0680ce26bf2746 100644
>--- a/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
>+++ b/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
>@@ -206,6 +206,12 @@ bool IOSApplication::isMobileStore()
>     return isMobileStore;
> }
> 
>+bool IOSApplication::isSplashBoardd()
>+{
>+    static bool isSplashBoardd = applicationBundleIsEqualTo(ASCIILiteral("splashboardd"));
>+    return isSplashBoardd;
>+}
>+
> bool IOSApplication::isSpringBoard()
> {
>     static bool isSpringBoard = applicationBundleIsEqualTo(ASCIILiteral("com.apple.springboard"));
>diff --git a/Source/WebCore/platform/ios/wak/WebCoreThread.mm b/Source/WebCore/platform/ios/wak/WebCoreThread.mm
>index 43bb32a930a2145921f05c2c7fc2202f81934348..d8ff806ab4330037684c619effe47417373090c8 100644
>--- a/Source/WebCore/platform/ios/wak/WebCoreThread.mm
>+++ b/Source/WebCore/platform/ios/wak/WebCoreThread.mm
>@@ -866,7 +866,9 @@ WebThreadContext* WebThreadCurrentContext(void)
> void WebThreadEnable(void)
> {
>     RELEASE_ASSERT_WITH_MESSAGE(!WebCore::IOSApplication::isWebProcess(), "The WebProcess should never run a Web Thread");
>-    if (WebCore::IOSApplication::isSpringBoard())
>+    if (WebCore::IOSApplication::isSplashBoardd())
>+        RELEASE_LOG_FAULT(Threading, "splashboardd enabled WebThread.");
>+    else if (WebCore::IOSApplication::isSpringBoard())
>         RELEASE_LOG_FAULT(Threading, "SpringBoard enabled WebThread.");
> 
>     static std::once_flag flag;

Actions: View | Formatted Diff | Diff

Attachments on bug 186793: 343003