Attachment 342974 Details for Bug 186542 – Patch

[patch] Patch

bug-186542-20180618145305.patch (text/plain), 2.39 KB, created by Chris Dumez on 2018-06-18 14:52:39 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-06-18 14:52:39 PDT

Size: 2.39 KB

patch

obsolete

>Subversion Revision: 232948
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 58b92131755c0293ab250969e684e4835a666192..4fd2cd0b75e39d99d2c1dcd853bf9ecb2105bb1c 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-18  Chris Dumez  <cdumez@apple.com>
>+
>+        Turn on PSON in WebKitTestRunner
>+        https://bugs.webkit.org/show_bug.cgi?id=186542
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Turn on process swap on cross-origin navigation by default for WebKitTestRunner
>+        now that all layout tests are passing.
>+
>+        * WebKitTestRunner/TestOptions.h:
>+        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
>+        (WTR::TestController::platformAddTestOptions const):
>+
> 2018-06-18  Chris Dumez  <cdumez@apple.com>
> 
>         Crash under WebProcessPool::networkProcessFailedToLaunch():
>diff --git a/Tools/WebKitTestRunner/TestOptions.h b/Tools/WebKitTestRunner/TestOptions.h
>index 3b17c01146e90fd7da8661cb52736cb8c9a37c26..5af925acc85909df1b279dd8873450a0f0aa4492 100644
>--- a/Tools/WebKitTestRunner/TestOptions.h
>+++ b/Tools/WebKitTestRunner/TestOptions.h
>@@ -56,7 +56,7 @@ struct TestOptions {
>     bool dumpJSConsoleLogInStdErr { false };
>     bool allowCrossOriginSubresourcesToAskForCredentials { false };
>     bool enableWebAnimationsCSSIntegration { false };
>-    bool enableProcessSwapOnNavigation { false };
>+    bool enableProcessSwapOnNavigation { true };
>     bool enableProcessSwapOnWindowOpen { false };
>     bool enableColorFilter { false };
> 
>diff --git a/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm b/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
>index e6efb2795d21bcdff396bc682e6270f60770c0ce..ee1af8cca455617edcc3c8d3e7ffee6eabe77a68 100644
>--- a/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
>+++ b/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
>@@ -133,8 +133,8 @@ WKPreferencesRef TestController::platformPreferences()
> 
> void TestController::platformAddTestOptions(TestOptions& options) const
> {
>-    if ([[NSUserDefaults standardUserDefaults] boolForKey:@"EnableProcessSwapOnNavigation"])
>-        options.enableProcessSwapOnNavigation = true;
>+    if ([[NSUserDefaults standardUserDefaults] boolForKey:@"DisableProcessSwapOnNavigation"])
>+        options.enableProcessSwapOnNavigation = false;
>     if ([[NSUserDefaults standardUserDefaults] boolForKey:@"EnableProcessSwapOnWindowOpen"])
>         options.enableProcessSwapOnWindowOpen = true;
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 186542: 342467 | 342488 | 342705 | 342962 | 342974 | 345177 | 345188