Attachment 342969 Details for Bug 186787 – Patch

[patch] Patch

bug-186787-20180618134835.patch (text/plain), 1.60 KB, created by BJ Burg on 2018-06-18 13:48:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: BJ Burg

Created: 2018-06-18 13:48:36 PDT

Size: 1.60 KB

patch

obsolete

>Subversion Revision: 232942
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index 5959f81a80538d440f97d2f45799397048a8faf7..7c1969d365224f38f05ca24c37cf137996c05449 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-06-18  Brian Burg  <bburg@apple.com>
>+
>+        Web Inspector: TypeError: Array.prototype.sort passed bad value in NetworkTableContentView _updateSortAndFilteredEntries
>+        https://bugs.webkit.org/show_bug.cgi?id=186787
>+        <rdar://problem/41175680>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/NetworkTableContentView.js:
>+        (WI.NetworkTableContentView.prototype._updateSortAndFilteredEntries):
>+
> 2018-06-13  Nikita Vasilyev  <nvasilyev@apple.com>
> 
>         Web Inspector: open source Dark Mode
>diff --git a/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js b/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>index a487cc628b2ba1db17461c6ba820650fd7710514..cfb4460c24263bacd431d84003983330ebb3e30f 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
>@@ -1243,7 +1243,9 @@ WI.NetworkTableContentView = class NetworkTableContentView extends WI.ContentVie
> 
>     _updateSortAndFilteredEntries()
>     {
>-        this._entries = this._entries.sort(this._entriesSortComparator);
>+        if (this._entriesSortComparator)
>+            this._entries = this._entries.sort(this._entriesSortComparator);
>+
>         this._updateFilteredEntries();
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 186787: 342969