Attachment 342948 Details for Bug 186776 – Patch

[patch] Patch

bug-186776-20180618102148.patch (text/plain), 1.62 KB, created by Wenson Hsieh on 2018-06-18 10:21:48 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Wenson Hsieh

Created: 2018-06-18 10:21:48 PDT

Size: 1.62 KB

patch

obsolete

>Subversion Revision: 232799
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 502db0473162fe3c15e6b054ef8f65c6149c1e42..2a29d8e6a14957571019abf85e942cb7d40b1e58 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-18  Wenson Hsieh  <wenson_hsieh@apple.com>
>+
>+        fast/forms/button-set-display-flex-justifyContent-center.html is failing on macOS Mojave
>+        https://bugs.webkit.org/show_bug.cgi?id=186776
>+        <rdar://problem/41104962>
>+
>+        Fix a failing layout test by making the reference markup robust for changes to system button text color. This
>+        system color is different in macOS Mojave, which causes this layout test to fail.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * fast/forms/button-set-display-flex-justifyContent-center-expected.html:
>+
> 2018-06-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
> 
>         [GTK] Mark some flaky tests and expected failures.
>diff --git a/LayoutTests/fast/forms/button-set-display-flex-justifyContent-center-expected.html b/LayoutTests/fast/forms/button-set-display-flex-justifyContent-center-expected.html
>index ec7e9b5d47989492a0139b831b5ee2f343c68401..229628034e83bb07fd7ce5d0b4e6035cd3f42cca 100644
>--- a/LayoutTests/fast/forms/button-set-display-flex-justifyContent-center-expected.html
>+++ b/LayoutTests/fast/forms/button-set-display-flex-justifyContent-center-expected.html
>@@ -6,6 +6,7 @@ div {
>     width: 300px;
>     display: flex;
>     justify-content: center;
>+    color: buttontext;
> }
> </style>
> <h4>Test for centering text inside a button set to display flex and justify-content: center is impossible</h4>

Actions: View | Formatted Diff | Diff

Attachments on bug 186776: 342948