WebKit Bugzilla
Attachment 342936 Details for
Bug 186765
: [Armv7] Linkbuffer: executableOffsetFor() fails for location 2
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186765-20180618165309.patch (text/plain), 1.44 KB, created by
Guillaume Emont
on 2018-06-18 07:53:10 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Guillaume Emont
Created:
2018-06-18 07:53:10 PDT
Size:
1.44 KB
patch
obsolete
>Subversion Revision: 232930 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index 81f49f6df83e75abf4ed7f9954708a631bc212de..ab50041a5da13d8e644c32797e7606cec5c750c4 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,15 @@ >+2018-06-18 Guillaume Emont <guijemont@igalia.com> >+ >+ [Armv7] Linkbuffer: executableOffsetFor() fails for location 2 >+ https://bugs.webkit.org/show_bug.cgi?id=186765 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ This widens the check for 0 so that we handle that case more correctly. >+ >+ * assembler/LinkBuffer.h: >+ (JSC::LinkBuffer::executableOffsetFor): >+ > 2018-06-16 Michael Catanzaro <mcatanzaro@igalia.com> > > REGRESSION(r227717): Hardcoded page size causing JSC crashes on platforms with page size bigger than 16 KB >diff --git a/Source/JavaScriptCore/assembler/LinkBuffer.h b/Source/JavaScriptCore/assembler/LinkBuffer.h >index 792a8c952261d640c17bfc2350ef8ecb42ee7143..05fe0afd66a4b44a349c8a4f5b74f8f32c654c65 100644 >--- a/Source/JavaScriptCore/assembler/LinkBuffer.h >+++ b/Source/JavaScriptCore/assembler/LinkBuffer.h >@@ -297,7 +297,7 @@ private: > #if ENABLE(BRANCH_COMPACTION) > int executableOffsetFor(int location) > { >- if (!location) >+ if (location < sizeof(int32_t)) > return 0; > return bitwise_cast<int32_t*>(m_assemblerStorage.buffer())[location / sizeof(int32_t) - 1]; > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186765
:
342936
|
343007
|
343041
|
343148
|
343152