Attachment 342922 Details for Bug 186756 – Patch

[patch] Patch

bug-186756-20180618131058.patch (text/plain), 1.77 KB, created by Tomas Popela on 2018-06-18 04:10:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tomas Popela

Created: 2018-06-18 04:10:59 PDT

Size: 1.77 KB

patch

obsolete

>Subversion Revision: 232922
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index d7be2d4937bab03e6e595fd06e31852505c7a076..b2eec5a83d179a43a81116da798a1276d4d91a13 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-18  Tomas Popela  <tpopela@redhat.com>
>+
>+        [GTK] Wrong variable used in RenderThemeGtk
>+        https://bugs.webkit.org/show_bug.cgi?id=186756
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use SliderThumbHorizontalPart instead of SliderHorizontalPart.
>+
>+        * rendering/RenderThemeGtk.cpp:
>+        (WebCore::RenderThemeGtk::adjustSliderThumbSize const):
>+
> 2018-06-17  Zalan Bujtas  <zalan@apple.com>
> 
>         Anonymous block collapsing can destroy the renderer's parent.
>diff --git a/Source/WebCore/rendering/RenderThemeGtk.cpp b/Source/WebCore/rendering/RenderThemeGtk.cpp
>index d04a6845f26a3fd0d5608f7a63bbf5f30ff68844..8e8fe10f58eb72cdf455b4a949fd5a28fffc5d80 100644
>--- a/Source/WebCore/rendering/RenderThemeGtk.cpp
>+++ b/Source/WebCore/rendering/RenderThemeGtk.cpp
>@@ -1314,7 +1314,7 @@ void RenderThemeGtk::adjustSliderThumbSize(RenderStyle& style, const Element*) c
>     if (part != SliderThumbHorizontalPart && part != SliderThumbVerticalPart)
>         return;
> 
>-    auto& sliderWidget = static_cast<RenderThemeSlider&>(RenderThemeWidget::getOrCreate(part == SliderHorizontalPart ? RenderThemeWidget::Type::HorizontalSlider : RenderThemeWidget::Type::VerticalSlider));
>+    auto& sliderWidget = static_cast<RenderThemeSlider&>(RenderThemeWidget::getOrCreate(part == SliderThumbHorizontalPart ? RenderThemeWidget::Type::HorizontalSlider : RenderThemeWidget::Type::VerticalSlider));
>     sliderWidget.scale().setState(GTK_STATE_FLAG_NORMAL);
>     sliderWidget.trough().setState(GTK_STATE_FLAG_NORMAL);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 186756: 342922