Attachment 342906 Details for Bug 186708 – Patch

[patch] Patch

bug-186708-20180616223207.patch (text/plain), 1.40 KB, created by Simon Fraser (smfr) on 2018-06-16 22:32:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2018-06-16 22:32:07 PDT

Size: 1.40 KB

patch

obsolete

>Subversion Revision: 232900
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 80221903a52ef86da10e0ebb58161ee0f531f87d..676b680a620418be59208e1a631a18bcce95809d 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-16  Simon Fraser  <simon.fraser@apple.com>
>+
>+        CSSFontFace wastes 59KB of Vector capacity on nytimes.com
>+        https://bugs.webkit.org/show_bug.cgi?id=186708
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Most CSSFontFace have one or two CSSFontFaceSource so don't allocate
>+        vector capacity in the default 16-size chunks.
>+
>+        * css/CSSFontFace.h:
>+
> 2018-06-15  Chris Dumez  <cdumez@apple.com>
> 
>         StyleRuleMedia wastes 158KB of Vector capacity on cnn.com
>diff --git a/Source/WebCore/css/CSSFontFace.h b/Source/WebCore/css/CSSFontFace.h
>index 346a7b861a7ae39ff05ee6e3e0530cafbcf66087..adefcbefa7c1c49886e6adf784a8aeaadda445ef 100644
>--- a/Source/WebCore/css/CSSFontFace.h
>+++ b/Source/WebCore/css/CSSFontFace.h
>@@ -184,7 +184,7 @@ private:
>     FontFeatureSettings m_featureSettings;
>     FontVariantSettings m_variantSettings;
>     Timer m_timeoutTimer;
>-    Vector<std::unique_ptr<CSSFontFaceSource>> m_sources;
>+    Vector<std::unique_ptr<CSSFontFaceSource>, 0, CrashOnOverflow, 0> m_sources;
>     RefPtr<CSSFontSelector> m_fontSelector;
>     RefPtr<StyleRuleFontFace> m_cssConnection;
>     HashSet<Client*> m_clients;

Actions: View | Formatted Diff | Diff

Attachments on bug 186708: 342906