WebKit Bugzilla
Attachment 342903 Details for
Bug 186704
: SVGTransformListValues wastes 127KB of Vector capacity on nytimes.com
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186704-20180616221423.patch (text/plain), 1.76 KB, created by
Simon Fraser (smfr)
on 2018-06-16 22:14:24 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Simon Fraser (smfr)
Created:
2018-06-16 22:14:24 PDT
Size:
1.76 KB
patch
obsolete
>Subversion Revision: 232900 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 80221903a52ef86da10e0ebb58161ee0f531f87d..116c0bdb12b9cc2e352fd08e73d7229690995121 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,20 @@ >+2018-06-16 Simon Fraser <simon.fraser@apple.com> >+ >+ SVGTransformListValues wastes 127KB of Vector capacity on nytimes.com >+ https://bugs.webkit.org/show_bug.cgi?id=186704 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ SVGTransformListValues has inline capacity 1, and every SVGGraphicsElement has >+ a SVGSynchronizableAnimatedProperty<WebCore::SVGTransformListValues>, so the inline >+ capacity wastes space for every SVGGraphicsElement that doesn't have a transform (i.e. >+ most of them). >+ >+ So make SVGTransformListValues have zero inline capacity, and set its min capacity to >+ 2, rather than the default 16, since most transform lists are short. >+ >+ * svg/SVGTransformListValues.h: >+ > 2018-06-15 Chris Dumez <cdumez@apple.com> > > StyleRuleMedia wastes 158KB of Vector capacity on cnn.com >diff --git a/Source/WebCore/svg/SVGTransformListValues.h b/Source/WebCore/svg/SVGTransformListValues.h >index 166554e60bca6996469a05e18f00c6d60f5c468a..2f32951e4be5b84da389ddf6ee09dbefc3564c0e 100644 >--- a/Source/WebCore/svg/SVGTransformListValues.h >+++ b/Source/WebCore/svg/SVGTransformListValues.h >@@ -31,7 +31,7 @@ class SVGListPropertyTearOff; > > class SVGTransformList; > >-class SVGTransformListValues final : public Vector<SVGTransformValue, 1> { >+class SVGTransformListValues final : public Vector<SVGTransformValue, 0, CrashOnOverflow, 2> { > public: > Ref<SVGTransform> createSVGTransformFromMatrix(SVGMatrix&) const; > Ref<SVGTransform> consolidate();
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186704
: 342903 |
342910