WebKit Bugzilla
Attachment 342866 Details for
Bug 186716
: Better pack MediaQuery
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186716-20180615190544.patch (text/plain), 2.20 KB, created by
Chris Dumez
on 2018-06-15 19:05:14 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Chris Dumez
Created:
2018-06-15 19:05:14 PDT
Size:
2.20 KB
patch
obsolete
>Subversion Revision: 232891 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 29a1f763f5d598f5b13fbbcf373374458962f356..bfd3df85aaadaf37caead653e86f41fd87d11646 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,17 @@ >+2018-06-15 Chris Dumez <cdumez@apple.com> >+ >+ Better pack MediaQuery >+ https://bugs.webkit.org/show_bug.cgi?id=186716 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Better pack MediaQuery to reduce its size from 48 bytes to 40 and save >+ some memory. >+ >+ * css/MediaQuery.cpp: >+ (WebCore::MediaQuery::MediaQuery): >+ * css/MediaQuery.h: >+ > 2018-06-15 Chris Dumez <cdumez@apple.com> > > Add API test coverage for SW RegistrationDatabase destruction and fix issues found by the test >diff --git a/Source/WebCore/css/MediaQuery.cpp b/Source/WebCore/css/MediaQuery.cpp >index 9d0badf9cd4f49569b0d02c3430008cc93e50bb0..74c47044c62bbf13800ea33c91b9c8c52e8dbc0b 100644 >--- a/Source/WebCore/css/MediaQuery.cpp >+++ b/Source/WebCore/css/MediaQuery.cpp >@@ -70,9 +70,9 @@ String MediaQuery::serialize() const > } > > MediaQuery::MediaQuery(Restrictor restrictor, const String& mediaType, Vector<MediaQueryExpression>&& expressions) >- : m_restrictor(restrictor) >- , m_mediaType(mediaType.convertToASCIILowercase()) >+ : m_mediaType(mediaType.convertToASCIILowercase()) > , m_expressions(WTFMove(expressions)) >+ , m_restrictor(restrictor) > { > std::sort(m_expressions.begin(), m_expressions.end(), [](auto& a, auto& b) { > return codePointCompare(a.serialize(), b.serialize()) < 0; >diff --git a/Source/WebCore/css/MediaQuery.h b/Source/WebCore/css/MediaQuery.h >index 1044042e1a2ecdceb35be5e9a04d93672df9cc00..9d11d4c5b39090c60545c864625e4521e51357a5 100644 >--- a/Source/WebCore/css/MediaQuery.h >+++ b/Source/WebCore/css/MediaQuery.h >@@ -54,11 +54,11 @@ public: > private: > String serialize() const; > >- Restrictor m_restrictor; > String m_mediaType; >+ mutable String m_serializationCache; > Vector<MediaQueryExpression> m_expressions; >+ Restrictor m_restrictor; > bool m_ignored { false }; >- mutable String m_serializationCache; > }; > > WTF::TextStream& operator<<(WTF::TextStream&, const MediaQuery&);
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186716
: 342866 |
342874