Attachment 342857 Details for Bug 186705 – Patch

[patch] Patch

bug-186705-20180615165555.patch (text/plain), 2.47 KB, created by Chris Dumez on 2018-06-15 16:55:55 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-06-15 16:55:55 PDT

Size: 2.47 KB

patch

obsolete

>Subversion Revision: 232894
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index b9c20361430f958503a674054b00deaf89a31569..35db3c901fd2a75b3d02c9183faff108e901bbc5 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-06-15  Chris Dumez  <cdumez@apple.com>
>+
>+        StyleRuleMedia wastes 158KB of Vector capacity on cnn.com
>+        https://bugs.webkit.org/show_bug.cgi?id=186705
>+        <rdar://problem/41173637>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Call shrinkToFit on RefPtr<StyleRuleBase> vectors in CSSParserImpl, after we're
>+        done parsing and before constructing StyleRuleMedia, StyleRuleSupports and
>+        deferred rules in StyleRuleGroup.
>+
>+        * css/parser/CSSParserImpl.cpp:
>+        (WebCore::CSSParserImpl::parseDeferredRuleList):
>+        (WebCore::CSSParserImpl::consumeMediaRule):
>+        (WebCore::CSSParserImpl::consumeSupportsRule):
>+
> 2018-06-15  Antti Koivisto  <antti@apple.com>
> 
>         Semantic colors should not be transformed by color-filter
>diff --git a/Source/WebCore/css/parser/CSSParserImpl.cpp b/Source/WebCore/css/parser/CSSParserImpl.cpp
>index 92236067dd3f6afbd3b3f86856b6eb6657815bde..7844191762b3a9e65d9c49b747a1e95e6a489f41 100644
>--- a/Source/WebCore/css/parser/CSSParserImpl.cpp
>+++ b/Source/WebCore/css/parser/CSSParserImpl.cpp
>@@ -185,6 +185,7 @@ void CSSParserImpl::parseDeferredRuleList(CSSParserTokenRange tokenRange, CSSDef
>     parser.consumeRuleList(tokenRange, RegularRuleList, [&childRules](const RefPtr<StyleRuleBase>& rule) {
>         childRules.append(rule);
>     });
>+    childRules.shrinkToFit();
> }
> 
> void CSSParserImpl::parseDeferredKeyframeList(CSSParserTokenRange tokenRange, CSSDeferredParser& deferredParser, StyleRuleKeyframes& keyframeRule)
>@@ -551,6 +552,7 @@ RefPtr<StyleRuleMedia> CSSParserImpl::consumeMediaRule(CSSParserTokenRange prelu
>     consumeRuleList(block, RegularRuleList, [&rules](RefPtr<StyleRuleBase> rule) {
>         rules.append(rule);
>     });
>+    rules.shrinkToFit();
> 
>     if (m_observerWrapper)
>         m_observerWrapper->observer().endRuleBody(m_observerWrapper->endOffset(block));
>@@ -577,6 +579,7 @@ RefPtr<StyleRuleSupports> CSSParserImpl::consumeSupportsRule(CSSParserTokenRange
>     consumeRuleList(block, RegularRuleList, [&rules](RefPtr<StyleRuleBase> rule) {
>         rules.append(rule);
>     });
>+    rules.shrinkToFit();
> 
>     if (m_observerWrapper)
>         m_observerWrapper->observer().endRuleBody(m_observerWrapper->endOffset(block));

Actions: View | Formatted Diff | Diff

Attachments on bug 186705: 342857