Attachment 342855 Details for Bug 186703 – Patch

[patch] Patch

bug-186703-20180615161025.patch (text/plain), 1.81 KB, created by Chris Dumez on 2018-06-15 16:10:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-06-15 16:10:26 PDT

Size: 1.81 KB

patch

obsolete

>Subversion Revision: 232894
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index b9c20361430f958503a674054b00deaf89a31569..8ca28f1ed361003fe87de4f98390f4d51172e80b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,23 @@
>+2018-06-15  Chris Dumez  <cdumez@apple.com>
>+
>+        CachedRawResource wastes 57K of Vector capacity
>+        https://bugs.webkit.org/show_bug.cgi?id=186703
>+        <rdar://problem/41173515>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use 0 as minimum capacity for CachedRawResource::m_redirectChain, instead of the
>+        default value of 16. m_redirectChain usually contains very few items so 16 is
>+        wasteful, especially considering that m_redirectChain contains fairly large
>+        objects (std::pair<ResourceRequest, ResourceResponse>). CachedRawResource are
>+        stored in the memory cache so it is important to not use more memory than
>+        necessary.
>+
>+        We are also not worried about the performance cost of allocations here since
>+        this vector is only populated on HTTP redirects.
>+
>+        * loader/cache/CachedRawResource.h:
>+
> 2018-06-15  Antti Koivisto  <antti@apple.com>
> 
>         Semantic colors should not be transformed by color-filter
>diff --git a/Source/WebCore/loader/cache/CachedRawResource.h b/Source/WebCore/loader/cache/CachedRawResource.h
>index f069487383a8ec2a474bfea285efc7f5ba12375f..2d3dac996432228f948fcb6fd4f66d706547ce1f 100644
>--- a/Source/WebCore/loader/cache/CachedRawResource.h
>+++ b/Source/WebCore/loader/cache/CachedRawResource.h
>@@ -89,7 +89,7 @@ private:
>         const ResourceResponse m_redirectResponse;
>     };
> 
>-    Vector<RedirectPair> m_redirectChain;
>+    Vector<RedirectPair, 0, CrashOnOverflow, 0> m_redirectChain;
> 
>     struct DelayedFinishLoading {
>         RefPtr<SharedBuffer> buffer;

Actions: View | Formatted Diff | Diff

Attachments on bug 186703: 342855