Attachment 342853 Details for Bug 186707 – Patch

[patch] Patch

bug-186707-20180615181350.patch (text/plain), 1.48 KB, created by Leo Balter on 2018-06-15 15:13:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Leo Balter

Created: 2018-06-15 15:13:50 PDT

Size: 1.48 KB

patch

obsolete

>Subversion Revision: 232892
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index b131b8a29c6217c694b86577f016c567988056f8..cc7c0f57ef36460fce21ed1eb23c351b1e286793 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-06-15  Leo Balter  <leonardo.balter@gmail.com>
>+
>+        [test262-runner] Handle items from the config list with inline comments
>+        https://bugs.webkit.org/show_bug.cgi?id=186707
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This is a workaround for the Yaml parser that bundles inline comments together with any items.
>+        * Scripts/test262/Runner.pm:
>+        (shouldSkip):
>+
> 2018-06-15  Chris Dumez  <cdumez@apple.com>
> 
>         Add API test coverage for SW RegistrationDatabase destruction and fix issues found by the test
>diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm
>index 3afa3268c977e4a7589b8b301e3ba42672c2115d..a9860cb3e5dab46083db63c82935ded4e066a3a1 100755
>--- a/Tools/Scripts/test262/Runner.pm
>+++ b/Tools/Scripts/test262/Runner.pm
>@@ -592,7 +592,10 @@ sub shouldSkip {
>         return 1 if (grep {$filename =~ $_} @skipPaths);
> 
>         my @skipFeatures;
>-        @skipFeatures = @{ $config->{skip}->{features} } if defined $config->{skip}->{features};
>+        @skipFeatures = map {
>+            # Remove inline comments from the yaml parsed config
>+            $_ =~ /(\S*)/;
>+        } @{ $config->{skip}->{features} } if defined $config->{skip}->{features};
> 
>         my $skip = 0;
>         my $keep = 0;

Actions: View | Formatted Diff | Diff

Attachments on bug 186707: 342852 | 342853