Attachment 342849 Details for Bug 186697 – patch

[patch] patch

patch.txt (text/plain), 1.62 KB, created by Nan Wang on 2018-06-15 14:56:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nan Wang

Created: 2018-06-15 14:56:22 PDT

Size: 1.62 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 232894)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2018-06-15  Nan Wang  <n_wang@apple.com>
>+
>+        AX: [macOS] When zoom is enabled, focus doesn't follow text cursor
>+        https://bugs.webkit.org/show_bug.cgi?id=186697
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Now that web process doesn't have access to NSScreen. The conversion of the 
>+        rects is wrong. Fixed this by using the right function that's available in
>+        WebCore to get the screen height.
>+
>+        * editing/mac/FrameSelectionMac.mm:
>+        (WebCore::accessibilityConvertScreenRect):
>+
> 2018-06-15  Antti Koivisto  <antti@apple.com>
> 
>         Semantic colors should not be transformed by color-filter
>Index: Source/WebCore/editing/mac/FrameSelectionMac.mm
>===================================================================
>--- Source/WebCore/editing/mac/FrameSelectionMac.mm	(revision 232774)
>+++ Source/WebCore/editing/mac/FrameSelectionMac.mm	(working copy)
>@@ -35,11 +35,10 @@ namespace WebCore {
> #if !PLATFORM(IOS)
> static CGRect accessibilityConvertScreenRect(CGRect bounds)
> {
>-    NSArray *screens = [NSScreen screens];
>-    if ([screens count]) {
>-        CGFloat screenHeight = NSHeight([(NSScreen *)[screens objectAtIndex:0] frame]);
>+    CGFloat screenHeight = screenRectForPrimaryScreen().height();
>+    if (screenHeight > 0)
>         bounds.origin.y = (screenHeight - (bounds.origin.y + bounds.size.height));
>-    } else
>+    else
>         bounds = CGRectZero;    
>     
>     return bounds;

Flags:

darin: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 186697: 342849 | 342961