Attachment 342823 Details for Bug 186677 – Patch

[patch] Patch

bug-186677-20180615101237.patch (text/plain), 2.16 KB, created by Timothy Hatcher on 2018-06-15 10:12:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Hatcher

Created: 2018-06-15 10:12:37 PDT

Size: 2.16 KB

patch

obsolete

>Subversion Revision: 232847
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 101bcfe3e1301da7870da3a72d3ee48282ca16b3..55b412efa899ea4291cc53df3d4010199dc677d6 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-15  Timothy Hatcher  <timothy@apple.com>
>+
>+        REGRESSION (r232799): Form controls are blank in dark mode.
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=186677
>+        rdar://problem/41162899
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * rendering/RenderThemeMac.mm:
>+        (-[WebCoreTextFieldCell _adjustedCoreUIDrawOptionsForDrawingBordersOnly:]):
>+        Dark mode controls don't have borders, just a semi-transparent background of shadows.
>+        In the dark mode case we can't disable borders, or we will not paint anything for the control.
>+
> 2018-06-14  Timothy Hatcher  <timothy@apple.com>
> 
>         Expose more semantic system colors.
>diff --git a/Source/WebCore/rendering/RenderThemeMac.mm b/Source/WebCore/rendering/RenderThemeMac.mm
>index a58d733f9b7dc1bb21d8b1cce3bd8add437d0164..1e334a1b5061c9dc76544d5242d5a58629e92dfd 100644
>--- a/Source/WebCore/rendering/RenderThemeMac.mm
>+++ b/Source/WebCore/rendering/RenderThemeMac.mm
>@@ -156,6 +156,14 @@ @implementation WebCoreTextFieldCell
> 
> - (CFDictionaryRef)_adjustedCoreUIDrawOptionsForDrawingBordersOnly:(CFDictionaryRef)defaultOptions
> {
>+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
>+    // Dark mode controls don't have borders, just a semi-transparent background of shadows.
>+    // In the dark mode case we can't disable borders, or we will not paint anything for the control.
>+    NSAppearanceName appearance = [self.controlView.effectiveAppearance bestMatchFromAppearancesWithNames:@[ NSAppearanceNameAqua, NSAppearanceNameDarkAqua ]];
>+    if ([appearance isEqualToString:NSAppearanceNameDarkAqua])
>+        return defaultOptions;
>+#endif
>+
>     // FIXME: This is a workaround for <rdar://problem/11385461>. When that bug is resolved, we should remove this code,
>     // as well as the internal method overrides below.
>     CFMutableDictionaryRef coreUIDrawOptions = CFDictionaryCreateMutableCopy(NULL, 0, defaultOptions);

Actions: View | Formatted Diff | Diff

Attachments on bug 186677: 342822 | 342823 | 342824