Attachment 342812 Details for Bug 185611 – Patch.

[patch] Patch.

GTKWPE-Avoid-using-uninitialized-launchOptions-in-.patch (text/plain), 1.90 KB, created by Thibault Saunier on 2018-06-15 08:02:49 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thibault Saunier

Created: 2018-06-15 08:02:49 PDT

Size: 1.90 KB

patch

obsolete

>From 6d4b2ed6c8984f4ea9d54c8e8381f8028a70c8d4 Mon Sep 17 00:00:00 2001
>From: Thibault Saunier <tsaunier@igalia.com>
>Date: Mon, 14 May 2018 10:18:02 -0400
>Subject: [PATCH xserver] [GTK][WPE]: Avoid using uninitialized launchOptions
> in getLaunchOptions
>
>Otherwise we might get segfault
>
>https://bugs.webkit.org/show_bug.cgi?id=185611
>---
> Source/WebKit/ChangeLog                              | 12 ++++++++++++
> .../WebKit/UIProcess/Plugins/PluginProcessProxy.cpp  |  2 +-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index a8877685739..8601a93c198 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-15  Thibault Saunier  <tsaunier@igalia.com>
>+
>+        [GTK][WPE]: Avoid using uninitialized launchOptions in getLaunchOptions
>+        https://bugs.webkit.org/show_bug.cgi?id=185611
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Otherwise we might segfault.
>+
>+        * UIProcess/Plugins/PluginProcessProxy.cpp:
>+        (WebKit::PluginProcessProxy::getLaunchOptions):
>+
> 2018-06-14  Youenn Fablet  <youenn@apple.com>
> 
>         Make NetworkProcess get cache storage parameters at creation of the CacheStorage engine
>diff --git a/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp b/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp
>index 7a39f5b1aea..326ae2a749e 100644
>--- a/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp
>+++ b/Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp
>@@ -88,8 +88,8 @@ PluginProcessProxy::~PluginProcessProxy()
> 
> void PluginProcessProxy::getLaunchOptions(ProcessLauncher::LaunchOptions& launchOptions)
> {
>-    ChildProcessProxy::getLaunchOptions(launchOptions);
>     platformGetLaunchOptions(launchOptions, m_pluginProcessAttributes);
>+    ChildProcessProxy::getLaunchOptions(launchOptions);
> }
> 
> void PluginProcessProxy::processWillShutDown(IPC::Connection& connection)
>-- 
>2.17.1

Actions: View | Formatted Diff | Diff

Attachments on bug 185611: 340313 | 340321 | 340429 | 340488 | 341270 | 341289 | 342812