Attachment 342790 Details for Bug 186647 – patch

[patch] patch

a-backup.diff (text/plain), 1.23 KB, created by Saam Barati on 2018-06-14 22:13:28 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2018-06-14 22:13:28 PDT

Size: 1.23 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 232866)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-06-14  Saam Barati  <sbarati@apple.com>
>+
>+        sun spider compile time benchmark fails in run-jsc-benchmarks with JSC_validateOptions=1
>+        https://bugs.webkit.org/show_bug.cgi?id=186647
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Let's use `unset JSC_useBlah` instead of `export JSC_useBlah=` to clear environment
>+        variables. The latter was causing crashes with when JSC_validateOptions was true.
>+
>+        * Scripts/run-jsc-benchmarks:
>+
> 2018-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
> 
>         [GTK][buildbot] Raise timeouts for the step benchmark-test on the GTK perf bot
>Index: Tools/Scripts/run-jsc-benchmarks
>===================================================================
>--- Tools/Scripts/run-jsc-benchmarks	(revision 232866)
>+++ Tools/Scripts/run-jsc-benchmarks	(working copy)
>@@ -1506,7 +1506,7 @@ class VM
>     $script.puts "}"
>     plan.environment.keys.each {
>         | key |
>-        $script.puts "export #{Shellwords.shellescape(key)}="
>+        $script.puts "unset #{Shellwords.shellescape(key)}"
>     }
>   end
> end

Actions: View | Formatted Diff | Diff

Attachments on bug 186647: 342790