Attachment 342759 Details for Bug 186631 – Patch

[patch] Patch

bug-186631-20180614141416.patch (text/plain), 1.78 KB, created by youenn fablet on 2018-06-14 14:14:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-06-14 14:14:19 PDT

Size: 1.78 KB

patch

obsolete

>Subversion Revision: 232840
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index be510d8073a5ae9e8b4180b8cd7a5db384f5e219..abd9eb968330e2d8b60ab59c4461ac6659dcd0ba 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-06-14  Youenn Fablet  <youenn@apple.com>
>+
>+        TestWebKitAPI.WebKit.WKNavigationResponsePDFType fails after r232815
>+        https://bugs.webkit.org/show_bug.cgi?id=186631
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
>+        (TEST): Update PDF plug-in identifier.
>+
> 2018-06-14  Zan Dobersek  <zdobersek@igalia.com>
> 
>         [GTK][WPE] MiniBrowsers should be able to ignore TLS errors
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm
>index f032bbe50185ddef4450ec78ec94418859ac40c0..fb54b91e558467464deab0a9f141b1f0c4c1e031 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm
>@@ -135,7 +135,7 @@ TEST(WebKit, WKNavigationResponsePDFType)
>     auto navigationDelegate = adoptNS([[WKNavigationResponseTestNavigationDelegate alloc] init]);
>     webView.get().navigationDelegate = navigationDelegate.get();
> 
>-    [[[webView configuration] processPool] _addSupportedPlugin: @"" named: @"WebKit built-in PDF" withMimeTypes: [NSSet setWithArray: @[ @"application/pdf" ]] withExtensions: [NSSet setWithArray: @[ ]]];
>+    [[[webView configuration] processPool] _addSupportedPlugin: @"" named: @"com.apple.webkit.builtinpdfplugin" withMimeTypes: [NSSet setWithArray: @[ @"application/pdf" ]] withExtensions: [NSSet setWithArray: @[ ]]];
> 
>     schemeHandler.get().mimeType = @"application/pdf";
>     navigationDelegate.get().expectation = YES;

Actions: View | Formatted Diff | Diff

Attachments on bug 186631: 342759