Attachment 342747 Details for Bug 186626 – Patch

[patch] Patch

bug-186626-20180614142536.patch (text/plain), 2.83 KB, created by Leo Balter on 2018-06-14 11:25:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Leo Balter

Created: 2018-06-14 11:25:37 PDT

Size: 2.83 KB

patch

obsolete

>Subversion Revision: 232841
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index bc25ed2d42fe4eef9073468013580e92e90322b6..62226a7ab9f10926c01fca1c8710f97e25947666 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-14  Leo Balter  <leonardo.balter@gmail.com>
>+
>+        [test262-runner] Improve displayed settings, use rel paths
>+        https://bugs.webkit.org/show_bug.cgi?id=186626
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use relative paths for the information printed in the settings summary after calling the Test262 Runner. This provides a cleaner summary that is easier to read and consume.
>+        * Scripts/test262/Runner.pm:
>+        (processCLI):
>+        (getBuildPath):
>+
> 2018-06-14  Valerie R Young  <valerie@bocoup.com>
> 
>         [test262-runner] Test output should summarize tests that are
>diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm
>index d045d5589027b52b61d4dcf8667152831aa1deec..a0a8a4914d70e7975fb63b0a91773ad64f497be8 100755
>--- a/Tools/Scripts/test262/Runner.pm
>+++ b/Tools/Scripts/test262/Runner.pm
>@@ -246,24 +246,24 @@ sub processCLI {
> 
>     $max_process ||= getProcesses();
> 
>-    print "\n-------------------------Settings------------------------\n"
>-        . "Test262 Dir: $test262Dir\n"
>-        . "JSC: $JSC\n"
>+    print "\nSettings:\n"
>+        . "Test262 Dir: " . abs2rel($test262Dir) . "\n"
>+        . "JSC: " . abs2rel($JSC) . "\n"
>         . "Child Processes: $max_process\n";
> 
>     print "Test timeout: $timeout\n" if $timeout;
>     print "DYLD_FRAMEWORK_PATH: $DYLD_FRAMEWORK_PATH\n" if $DYLD_FRAMEWORK_PATH;
>     print "Features to include: " . join(', ', @features) . "\n" if @features;
>     print "Paths: " . join(', ', @cliTestDirs) . "\n" if @cliTestDirs;
>-    print "Config file: $configFile\n" if $config;
>-    print "Expectations file: $expectationsFile\n" if $expect;
>-    print "Results file: $resultsFile\n" if $stats || $failingOnly;
>+    print "Config file: " . abs2rel($configFile) . "\n" if $config;
>+    print "Expectations file: " . abs2rel($expectationsFile) . "\n" if $expect;
>+    print "Results file: ". abs2rel($resultsFile) . "\n" if $stats || $failingOnly;
> 
>     print "Running only the latest imported files\n" if $latestImport;
> 
>     print "Verbose mode\n" if $verbose;
> 
>-    print "--------------------------------------------------------\n\n";
>+    print "---\n\n";
> }
> 
> 
>@@ -529,8 +529,8 @@ sub getBuildPath {
>         $jsc = $jscDir . '/JavaScriptCore.framework/Resources/jsc' if (! -e $jsc);
>         $jsc = $jscDir . '/bin/jsc' if (! -e $jsc);
> 
>-        # Sets the Env DYLD_FRAMEWORK_PATH
>-        $DYLD_FRAMEWORK_PATH = dirname($jsc) if (-e $jsc);
>+        # Sets the Env DYLD_FRAMEWORK_PATH, abs_path will remove any extra '/' character
>+        $DYLD_FRAMEWORK_PATH = abs_path(dirname($jsc)) if (-e $jsc);
>     }
> 
>     if (! $jsc || ! -e $jsc) {

Actions: View | Formatted Diff | Diff

Attachments on bug 186626: 342747