WebKit Bugzilla
Attachment 342738 Details for
Bug 186570
: Eliminate static initializers in libwebrtc.dylib
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Fix memory error issue
bug-186570-20180614102245.patch (text/plain), 1.69 KB, created by
youenn fablet
on 2018-06-14 10:22:46 PDT
(
hide
)
Description:
Fix memory error issue
Filename:
MIME Type:
Creator:
youenn fablet
Created:
2018-06-14 10:22:46 PDT
Size:
1.69 KB
patch
obsolete
>Subversion Revision: 232840 >diff --git a/Source/ThirdParty/libwebrtc/ChangeLog b/Source/ThirdParty/libwebrtc/ChangeLog >index 8aa311b0b3ddb64219b41eb0cd95e6a3c91c1d26..a656b0754484de2f0776e7495abe2f87497d86cc 100644 >--- a/Source/ThirdParty/libwebrtc/ChangeLog >+++ b/Source/ThirdParty/libwebrtc/ChangeLog >@@ -1,3 +1,14 @@ >+2018-06-14 Youenn Fablet <youenn@apple.com> >+ >+ Eliminate static initializers in libwebrtc.dylib >+ https://bugs.webkit.org/show_bug.cgi?id=186570 >+ <rdar://problem/41054874> >+ >+ Reviewed by Darin Adler. >+ >+ * Source/webrtc/rtc_base/flags.h: >+ Fix memory corruption error by having the actual flag value be static. >+ > 2018-06-13 Youenn Fablet <youenn@apple.com> > > Eliminate static initializers in libwebrtc.dylib >diff --git a/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/flags.h b/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/flags.h >index 568e9bc3f7028214710cf7043dfa9c381f612cd4..0515d1140e90df3346fedade133108acc6b0e844 100644 >--- a/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/flags.h >+++ b/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/flags.h >@@ -155,7 +155,7 @@ class Flag { > #define DEFINE_FLAG(type, c_type, name, default, comment) \ > static std::pair<std::reference_wrapper<c_type>, std::reference_wrapper<rtc::Flag>> name() { \ > /* define and initialize the flag */ \ >- c_type FLAG_##name = (default); \ >+ static c_type FLAG_##name = (default); \ > /* register the flag */ \ > static rtc::Flag Flag_##name(__FILE__, #name, (comment), \ > rtc::Flag::type, &FLAG_##name, \
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186570
:
342615
|
342619
|
342620
|
342678
| 342738