Attachment 342732 Details for Bug 186219 – Patch

[patch] Patch

bug-186219-20180614140604.patch (text/plain), 4.47 KB, created by Carlos Bentzen on 2018-06-14 05:06:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Bentzen

Created: 2018-06-14 05:06:06 PDT

Size: 4.47 KB

patch

obsolete

>Subversion Revision: 232834
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8b4845d87b759cf25fc4dbc9cce17f06c1cdcc8f..2e0625a8aecc5a217123050907ddc5ec9a1ac152 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-06-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
>+
>+        [GTK] Correct behavior for dark themes
>+        https://bugs.webkit.org/show_bug.cgi?id=186219
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Override RenderThemeGtk::isControlStyled() to not style
>+        text inputs if color is set different than default.
>+
>+        No new tests. Manual theme test and existing layout tests already cover it.
>+
>+        * rendering/RenderThemeGtk.cpp:
>+        (WebCore::RenderThemeGtk::isControlStyled const):
>+        * rendering/RenderThemeGtk.h:
>+
> 2018-06-13  Chris Dumez  <cdumez@apple.com>
> 
>         Crash under SWServer::unregisterConnection(Connection&)
>diff --git a/Source/WebCore/rendering/RenderThemeGtk.cpp b/Source/WebCore/rendering/RenderThemeGtk.cpp
>index f549471d31f1f74715173ed327c47394858e4023..d8eb1634fb9174db1b94697f0b9bf1d76a920e47 100644
>--- a/Source/WebCore/rendering/RenderThemeGtk.cpp
>+++ b/Source/WebCore/rendering/RenderThemeGtk.cpp
>@@ -924,6 +924,14 @@ bool RenderThemeGtk::paintMenuListButtonDecorations(const RenderBox& object, con
>     return paintMenuList(object, info, rect);
> }
> 
>+bool RenderThemeGtk::isControlStyled(const RenderStyle& style, const BorderData& border, const FillLayer& background, const Color& backgroundColor) const
>+{
>+    if ((style.appearance() == TextFieldPart || style.appearance() == TextAreaPart || style.appearance() == SearchFieldPart) && style.color() != RenderStyle::initialColor())
>+        return true;
>+
>+    return RenderTheme::isControlStyled(style, border, background, backgroundColor);
>+}
>+
> #if GTK_CHECK_VERSION(3, 20, 0)
> 
> static IntSize spinButtonSize()
>diff --git a/Source/WebCore/rendering/RenderThemeGtk.h b/Source/WebCore/rendering/RenderThemeGtk.h
>index 31ee7b7a3026616ecbdf49464595e18a8d176924..097f9418430893eddc14f653714c6acc5529b83c 100644
>--- a/Source/WebCore/rendering/RenderThemeGtk.h
>+++ b/Source/WebCore/rendering/RenderThemeGtk.h
>@@ -168,6 +168,8 @@ private:
> #endif
> #endif
> 
>+    bool isControlStyled(const RenderStyle&, const BorderData&, const FillLayer&, const Color&) const override;
>+
>     Seconds animationRepeatIntervalForProgressBar(RenderProgress&) const override;
>     Seconds animationDurationForProgressBar(RenderProgress&) const override;
>     void adjustProgressBarStyle(StyleResolver&, RenderStyle&, const Element*) const override;
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 4acddd5eb1240740fd9c7e3f5b679ed302071df6..32f19601056dbeecc07213d26cbed56520f1a557 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-13  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
>+
>+        [GTK] Correct behavior for dark themes
>+        https://bugs.webkit.org/show_bug.cgi?id=186219
>+
>+        Update expectations in reftests expected to fail due to not
>+        styling text inputs with GTK when color is different than default color.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/gtk/TestExpectations:
>+
> 2018-06-13  Zalan Bujtas  <zalan@apple.com>
> 
>         [Mail] Use the Mail Viewer width as the base for resolving horizontal viewport units
>diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations
>index 107c0be48789139adf255107e29bd8b6421165e6..0561112625ca66ccfc5e598485da04a2d62ddb87 100644
>--- a/LayoutTests/platform/gtk/TestExpectations
>+++ b/LayoutTests/platform/gtk/TestExpectations
>@@ -3392,6 +3392,12 @@ webkit.org/b/186252 legacy-animation-engine/css3/filters/composited-during-trans
> 
> webkit.org/b/186340 transitions/zero-duration-with-non-zero-delay-start.html [ Timeout Failure ]
> 
>+# When text input colors are set we do not style with GTK, so these reftests will fail
>+webkit.org/b/186219 fast/forms/input-placeholder-text-indent.html [ ImageOnlyFailure ]
>+webkit.org/b/186219 fast/forms/password-placeholder-text-security.html [ ImageOnlyFailure ]
>+webkit.org/b/186219 fast/forms/placeholder-with-positioned-element.html [ ImageOnlyFailure ]
>+webkit.org/b/186219 fast/forms/textarea-placeholder-wrapping.html [ ImageOnlyFailure ]
>+
> #////////////////////////////////////////////////////////////////////////////////////////
> # End of non-crashing, non-flaky tests failing
> #////////////////////////////////////////////////////////////////////////////////////////

Actions: View | Formatted Diff | Diff

Attachments on bug 186219: 342732 | 342909