Attachment 342713 Details for Bug 186612 – Patch

[patch] Patch

bug-186612-20180614024127.patch (text/plain), 1.34 KB, created by Carlos Alberto Lopez Perez on 2018-06-13 17:41:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Alberto Lopez Perez

Created: 2018-06-13 17:41:29 PDT

Size: 1.34 KB

patch

obsolete

>Subversion Revision: 232817
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 2e9bbeb280baebbbb458ee13c52ab1ced65e431e..f25b62e1c5760a32b52321013c96176132b5e16e 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
>+
>+        Ensure the tests are run with US/Pacific time zone
>+        https://bugs.webkit.org/show_bug.cgi?id=186612
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Unconditionally set TZ environment variable to US/Pacific for the test environment.
>+
>+        * Scripts/webkitpy/port/base.py:
>+        (Port.setup_environ_for_server):
>+
> 2018-06-13  David Fenton  <david_fenton@apple.com>
> 
>         Unreviewed, add myself as a WebKit committer.
>diff --git a/Tools/Scripts/webkitpy/port/base.py b/Tools/Scripts/webkitpy/port/base.py
>index 87caa97879ae2afee04ef96a10945f64e7513fb9..e7fdefeb17730723bb7eb670aed45660ad62f811 100644
>--- a/Tools/Scripts/webkitpy/port/base.py
>+++ b/Tools/Scripts/webkitpy/port/base.py
>@@ -944,6 +944,9 @@ class Port(object):
>             [name, value] = string_variable.split('=', 1)
>             clean_env[name] = value
> 
>+        # Some tests fail if the time zone is not set to US/Pacific (<https://webkit.org/b/186612>)
>+        clean_env['TZ'] = 'US/Pacific'
>+
>         return clean_env
> 
>     def _clear_global_caches_and_temporary_files(self):

Actions: View | Formatted Diff | Diff

Attachments on bug 186612: 342713 | 342762 | 411521