Attachment 342691 Details for Bug 186312 – Patch

[patch] Patch

bug-186312-20180613141143.patch (text/plain), 47.60 KB, created by youenn fablet on 2018-06-13 14:11:44 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: youenn fablet

Created: 2018-06-13 14:11:44 PDT

Size: 47.60 KB

patch

obsolete

>Subversion Revision: 232792
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 50328f184a6300ca0952105387d7cbae15dcafd5..dff2a08e9831e3f677cb0d5d1195478c1adc329d 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,33 @@
>+2018-06-13  Youenn Fablet  <youenn@apple.com>
>+
>+        Network Preflights do not show in WebInspector after moving CORS checks to NetworkProcess
>+        https://bugs.webkit.org/show_bug.cgi?id=186312
>+        <rdar://problem/40495434>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Test: http/wpt/fetch/inspect-preflight.html
>+
>+        No change of behavior in regular conditions.
>+        All intermediate requests/responses are now buffered in NetworkProcess if Web inspector shows up.
>+        Add NetworkLoadInformation and NetworkIntermediateLoadInformation for that purpose.
>+
>+        Add a new LoaderStrategy method to grab this information from NetworkProcess synchronously.
>+        Add Internals API for testing the storage by the Network Process and the sending to WebProcess.
>+
>+        * WebCore.xcodeproj/project.pbxproj:
>+        * loader/LoaderStrategy.cpp:
>+        (WebCore::LoaderStrategy::intermediateLoadInformationFromResourceLoadIdentifier):
>+        * loader/LoaderStrategy.h:
>+        * platform/network/NetworkLoadInformation.h: Added.
>+        (WebCore::NetworkTransactionInformation::encode const):
>+        (WebCore::NetworkTransactionInformation::decode):
>+        * testing/Internals.cpp:
>+        (WebCore::Internals::setCaptureExtraNetworkLoadMetricsEnabled):
>+        (WebCore::Internals::ongoingLoadDescriptions):
>+        * testing/Internals.h:
>+        * testing/Internals.idl:
>+
> 2018-06-13  Philippe Normand  <pnormand@igalia.com>
> 
>         Unreviewed GTK build fix for --cmakeargs=-DUSE_GSTREAMER_GL=OFF
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index a777d75e06dafa3f7df0f9b2911b6d753dae328f..4f6e79222fc78ca2625a547dc68c6c29906ea03a 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,54 @@
>+2018-06-13  Youenn Fablet  <youenn@apple.com>
>+
>+        Network Preflights do not show in WebInspector after moving CORS checks to NetworkProcess
>+        https://bugs.webkit.org/show_bug.cgi?id=186312
>+        <rdar://problem/40495434>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add buffering of all request/response of a given load, including redirections and preflights.
>+        This buffering is switched on/off by a boolean which is switched on in case Web Inspector is launched.
>+
>+        Buffering is done in NetworkLoadChecker.
>+        We add ways to retrieve preflight information from NetworkCORSPreflightChecker.
>+
>+        Implement LoaderStrategy new methods through sync IPC.
>+
>+        * NetworkProcess/NetworkCORSPreflightChecker.cpp:
>+        (WebKit::NetworkCORSPreflightChecker::NetworkCORSPreflightChecker):
>+        (WebKit::NetworkCORSPreflightChecker::startPreflight):
>+        (WebKit::NetworkCORSPreflightChecker::willPerformHTTPRedirection):
>+        (WebKit::NetworkCORSPreflightChecker::didReceiveResponseNetworkSession):
>+        (WebKit::NetworkCORSPreflightChecker::didCompleteWithError):
>+        (WebKit::NetworkCORSPreflightChecker::takeInformation):
>+        * NetworkProcess/NetworkCORSPreflightChecker.h:
>+        * NetworkProcess/NetworkConnectionToWebProcess.h:
>+        (WebKit::NetworkConnectionToWebProcess::takeNetworkLoadInformationRequest):
>+        (WebKit::NetworkConnectionToWebProcess::takeNetworkLoadIntermediateInformation):
>+        (WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformation):
>+        (WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformationMetrics):
>+        (WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformationResponse): Deleted.
>+        * NetworkProcess/NetworkConnectionToWebProcess.messages.in:
>+        * NetworkProcess/NetworkLoadChecker.cpp:
>+        (WebKit::NetworkLoadChecker::NetworkLoadChecker):
>+        (WebKit::NetworkLoadChecker::check):
>+        (WebKit::NetworkLoadChecker::checkRedirection):
>+        (WebKit::NetworkLoadChecker::checkResponse):
>+        (WebKit::NetworkLoadChecker::checkCORSRequestWithPreflight):
>+        (WebKit::NetworkLoadChecker::storeRedirection):
>+        * NetworkProcess/NetworkLoadChecker.h:
>+        (WebKit::NetworkLoadChecker::takeNetworkLoadInformation):
>+        * NetworkProcess/NetworkResourceLoader.cpp:
>+        (WebKit::NetworkResourceLoader::didReceiveResponse):
>+        (WebKit::NetworkResourceLoader::willSendRedirectedRequest):
>+        (WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
>+        * NetworkProcess/PingLoad.cpp:
>+        (WebKit::PingLoad::PingLoad):
>+        * Scripts/webkit/messages.py:
>+        * WebProcess/Network/WebLoaderStrategy.cpp:
>+        (WebKit::WebLoaderStrategy::intermediateLoadInformationFromResourceLoadIdentifier):
>+        * WebProcess/Network/WebLoaderStrategy.h:
>+
> 2018-06-12  Brent Fulgham  <bfulgham@apple.com>
> 
>         Turn CSS Spring Animations and Link Preload off by default for production builds.
>diff --git a/Source/WebCore/WebCore.xcodeproj/project.pbxproj b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>index e578f644be65a1a7091485847afb68dd9d9a2535..4566d7cd34498c159d2454d92160e2d72eeb6d7b 100644
>--- a/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>+++ b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>@@ -1082,6 +1082,7 @@
> 		4161E2D51FE48DC500EC2E96 /* FetchLoader.h in Headers */ = {isa = PBXBuildFile; fileRef = 4147E2B51C89912600A7E715 /* FetchLoader.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		4162A451101145AE00DFF3ED /* DedicatedWorkerGlobalScope.h in Headers */ = {isa = PBXBuildFile; fileRef = 4162A44E101145AE00DFF3ED /* DedicatedWorkerGlobalScope.h */; };
> 		4162A4581011464700DFF3ED /* JSDedicatedWorkerGlobalScope.h in Headers */ = {isa = PBXBuildFile; fileRef = 4162A4561011464700DFF3ED /* JSDedicatedWorkerGlobalScope.h */; };
>+		416D75A220C651A500D02D2C /* NetworkLoadInformation.h in Headers */ = {isa = PBXBuildFile; fileRef = 416D759F20C6441300D02D2C /* NetworkLoadInformation.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		416E0B3A209BC3CB004A95D9 /* FetchIdentifier.h in Headers */ = {isa = PBXBuildFile; fileRef = 416E0B37209BC3C2004A95D9 /* FetchIdentifier.h */; settings = {ATTRIBUTES = (Private, ); }; };
> 		416E29A6102FA962007FC14E /* WorkerReportingProxy.h in Headers */ = {isa = PBXBuildFile; fileRef = 416E29A5102FA962007FC14E /* WorkerReportingProxy.h */; };
> 		416E6FE81BBD12DF000A3F64 /* ReadableStreamInternalsBuiltins.h in Headers */ = {isa = PBXBuildFile; fileRef = 9B03D8061BB3110D00B764D9 /* ReadableStreamInternalsBuiltins.h */; settings = {ATTRIBUTES = (Private, ); }; };
>@@ -7232,6 +7233,7 @@
> 		4162A44F101145AE00DFF3ED /* DedicatedWorkerGlobalScope.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = DedicatedWorkerGlobalScope.idl; sourceTree = "<group>"; };
> 		4162A4551011464700DFF3ED /* JSDedicatedWorkerGlobalScope.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDedicatedWorkerGlobalScope.cpp; sourceTree = "<group>"; };
> 		4162A4561011464700DFF3ED /* JSDedicatedWorkerGlobalScope.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSDedicatedWorkerGlobalScope.h; sourceTree = "<group>"; };
>+		416D759F20C6441300D02D2C /* NetworkLoadInformation.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NetworkLoadInformation.h; sourceTree = "<group>"; };
> 		416E0B37209BC3C2004A95D9 /* FetchIdentifier.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = FetchIdentifier.h; sourceTree = "<group>"; };
> 		416E29A5102FA962007FC14E /* WorkerReportingProxy.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WorkerReportingProxy.h; sourceTree = "<group>"; };
> 		4170A2E91D8C0CC000318452 /* JSDOMWrapper.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMWrapper.cpp; sourceTree = "<group>"; };
>@@ -19019,6 +19021,7 @@
> 				514C765D0CE923A1007EF3CD /* HTTPParsers.cpp */,
> 				514C765E0CE923A1007EF3CD /* HTTPParsers.h */,
> 				628D214B12131ED10055DCFC /* NetworkingContext.h */,
>+				416D759F20C6441300D02D2C /* NetworkLoadInformation.h */,
> 				8A81BF8411DCFD9000DA2B98 /* NetworkLoadMetrics.h */,
> 				1A7FA61A0DDA3BBE0028F8A5 /* NetworkStateNotifier.cpp */,
> 				1A7FA6180DDA3B3A0028F8A5 /* NetworkStateNotifier.h */,
>@@ -29460,6 +29463,7 @@
> 				656D37430ADBA5DE00A4554D /* NetscapePlugInStreamLoader.h in Headers */,
> 				A19D934B1AA11B1E00B46C24 /* NetworkExtensionContentFilter.h in Headers */,
> 				628D214C12131ED10055DCFC /* NetworkingContext.h in Headers */,
>+				416D75A220C651A500D02D2C /* NetworkLoadInformation.h in Headers */,
> 				8A81BF8511DCFD9000DA2B98 /* NetworkLoadMetrics.h in Headers */,
> 				59C27F07138D28CF0079B7E2 /* NetworkResourcesData.h in Headers */,
> 				1A7FA6190DDA3B3A0028F8A5 /* NetworkStateNotifier.h in Headers */,
>diff --git a/Source/WebCore/loader/LoaderStrategy.cpp b/Source/WebCore/loader/LoaderStrategy.cpp
>index 838642d9de6097f0d63d5ad48bbf55358adcb487..8c6361f67c39ede66c23d89cd48de2a25cf28ca3 100644
>--- a/Source/WebCore/loader/LoaderStrategy.cpp
>+++ b/Source/WebCore/loader/LoaderStrategy.cpp
>@@ -26,8 +26,7 @@
> #include "config.h"
> #include "LoaderStrategy.h"
> 
>-#include "NetworkLoadMetrics.h"
>-#include "ResourceResponse.h"
>+#include "NetworkLoadInformation.h"
> 
> namespace WebCore {
> 
>@@ -43,6 +42,9 @@ NetworkLoadMetrics LoaderStrategy::networkMetricsFromResourceLoadIdentifier(uint
>     return { };
> }
> 
>-} // namespace WebCore
>-
>+Vector<NetworkTransactionInformation> LoaderStrategy::intermediateLoadInformationFromResourceLoadIdentifier(uint64_t /* resourceLoadIdentifier */)
>+{
>+    return { };
>+}
> 
>+} // namespace WebCore
>diff --git a/Source/WebCore/loader/LoaderStrategy.h b/Source/WebCore/loader/LoaderStrategy.h
>index f142b57727b3f598af1fa297e2d993bb3e156640..d4357a03d36c47e9bd25d49fd85200f92ca0525b 100644
>--- a/Source/WebCore/loader/LoaderStrategy.h
>+++ b/Source/WebCore/loader/LoaderStrategy.h
>@@ -42,6 +42,7 @@ class FrameLoader;
> class HTTPHeaderMap;
> class NetscapePlugInStreamLoader;
> class NetscapePlugInStreamLoaderClient;
>+struct NetworkTransactionInformation;
> class NetworkLoadMetrics;
> class ResourceError;
> class ResourceLoader;
>@@ -85,8 +86,12 @@ public:
>     virtual bool havePerformedSecurityChecks(const ResourceResponse&) const { return false; }
> 
>     virtual ResourceResponse responseFromResourceLoadIdentifier(uint64_t resourceLoadIdentifier);
>+    virtual Vector<NetworkTransactionInformation> intermediateLoadInformationFromResourceLoadIdentifier(uint64_t resourceLoadIdentifier);
>     virtual NetworkLoadMetrics networkMetricsFromResourceLoadIdentifier(uint64_t resourceLoadIdentifier);
> 
>+    // Used for testing only.
>+    virtual Vector<uint64_t> ongoingLoads() const { return { }; }
>+
> protected:
>     virtual ~LoaderStrategy();
> };
>diff --git a/Source/WebCore/platform/network/NetworkLoadInformation.h b/Source/WebCore/platform/network/NetworkLoadInformation.h
>new file mode 100644
>index 0000000000000000000000000000000000000000..3c9360dbefe3dca6c43e285d450ad7eaeace5e3a
>--- /dev/null
>+++ b/Source/WebCore/platform/network/NetworkLoadInformation.h
>@@ -0,0 +1,92 @@
>+/*
>+ * Copyright (C) 2018 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#pragma once
>+
>+#include "NetworkLoadMetrics.h"
>+#include "ResourceRequest.h"
>+#include "ResourceResponse.h"
>+#include <wtf/EnumTraits.h>
>+#include <wtf/Vector.h>
>+
>+namespace WebCore {
>+
>+struct NetworkTransactionInformation {
>+    enum class Type { Redirection, Preflight };
>+    Type type;
>+    ResourceRequest request;
>+    ResourceResponse response;
>+    NetworkLoadMetrics metrics;
>+
>+    template<class Encoder> void encode(Encoder&) const;
>+    template<class Decoder> static std::optional<NetworkTransactionInformation> decode(Decoder&);
>+};
>+
>+struct NetworkLoadInformation {
>+    ResourceRequest request;
>+    ResourceResponse response;
>+    NetworkLoadMetrics metrics;
>+    Vector<NetworkTransactionInformation> transactions;
>+};
>+
>+}
>+
>+namespace WTF {
>+template<> struct EnumTraits<WebCore::NetworkTransactionInformation::Type> {
>+    using values = EnumValues<
>+        WebCore::NetworkTransactionInformation::Type,
>+        WebCore::NetworkTransactionInformation::Type::Redirection,
>+        WebCore::NetworkTransactionInformation::Type::Preflight
>+    >;
>+};
>+}
>+
>+namespace WebCore {
>+
>+template<class Encoder> inline void NetworkTransactionInformation::encode(Encoder& encoder) const
>+{
>+    encoder << type;
>+    encoder << request;
>+    encoder << response;
>+    encoder << metrics;
>+}
>+
>+template<class Decoder> inline std::optional<NetworkTransactionInformation> NetworkTransactionInformation::decode(Decoder& decoder)
>+{
>+    NetworkTransactionInformation information;
>+
>+    if (!decoder.decode(information.type))
>+        return std::nullopt;
>+    if (!decoder.decode(information.request))
>+        return std::nullopt;
>+    if (!decoder.decode(information.response))
>+        return std::nullopt;
>+    if (!decoder.decode(information.metrics))
>+        return std::nullopt;
>+
>+    return information;
>+}
>+
>+}
>diff --git a/Source/WebCore/testing/Internals.cpp b/Source/WebCore/testing/Internals.cpp
>index 58261eda23db6bd60e15be376cd1b0a295a454bf..c188468d6d779a5a5a6f4289a1b28970ec3706a5 100644
>--- a/Source/WebCore/testing/Internals.cpp
>+++ b/Source/WebCore/testing/Internals.cpp
>@@ -98,6 +98,7 @@
> #include "InternalSettings.h"
> #include "JSImageData.h"
> #include "LibWebRTCProvider.h"
>+#include "LoaderStrategy.h"
> #include "MallocStatistics.h"
> #include "MediaPlayer.h"
> #include "MediaProducer.h"
>@@ -108,6 +109,7 @@
> #include "MockLibWebRTCPeerConnection.h"
> #include "MockPageOverlay.h"
> #include "MockPageOverlayClient.h"
>+#include "NetworkLoadInformation.h"
> #if USE(CG)
> #include "PDFDocumentImage.h"
> #endif
>@@ -116,6 +118,7 @@
> #include "PageOverlay.h"
> #include "PathUtilities.h"
> #include "PlatformMediaSessionManager.h"
>+#include "PlatformStrategies.h"
> #include "PrintContext.h"
> #include "PseudoElement.h"
> #include "Range.h"
>@@ -175,6 +178,7 @@
> #include <wtf/MonotonicTime.h>
> #include <wtf/text/StringBuffer.h>
> #include <wtf/text/StringBuilder.h>
>+#include <wtf/text/StringConcatenateNumbers.h>
> #include <wtf/text/StringView.h>
> 
> #if ENABLE(INPUT_TYPE_COLOR)
>@@ -4565,4 +4569,32 @@ bool Internals::usingAppleInternalSDK() const
> #endif
> }
> 
>+void Internals::setCaptureExtraNetworkLoadMetricsEnabled(bool value)
>+{
>+    platformStrategies()->loaderStrategy()->setCaptureExtraNetworkLoadMetricsEnabled(value);
>+}
>+
>+String Internals::ongoingLoadDescriptions()
>+{
>+    StringBuilder builder;
>+    builder.append("[");
>+    bool isStarting = true;
>+    auto loads = platformStrategies()->loaderStrategy()->ongoingLoads();
>+    for (auto& identifier : platformStrategies()->loaderStrategy()->ongoingLoads()) {
>+        if (isStarting)
>+            isStarting = false;
>+        else
>+            builder.append(",");
>+
>+        builder.append("[");
>+
>+        for (auto& info : platformStrategies()->loaderStrategy()->intermediateLoadInformationFromResourceLoadIdentifier(identifier))
>+            builder.append(makeString("[", (int)info.type, ",\"", info.request.url().string(), "\",\"", info.request.httpMethod(), "\",", info.response.httpStatusCode(), "]"));
>+
>+        builder.append("]");
>+    }
>+    builder.append("]");
>+    return builder.toString();
>+}
>+    
> } // namespace WebCore
>diff --git a/Source/WebCore/testing/Internals.h b/Source/WebCore/testing/Internals.h
>index 93a7463464e0e99dceb801ce55ffd10d7e8a7a6e..d7d185681df7f47c1776340328ed68d52bb59c8a 100644
>--- a/Source/WebCore/testing/Internals.h
>+++ b/Source/WebCore/testing/Internals.h
>@@ -696,6 +696,9 @@ public:
>     using PlaybackControlsPurpose = MediaElementSession::PlaybackControlsPurpose;
>     HTMLMediaElement* bestMediaElementForShowingPlaybackControlsManager(PlaybackControlsPurpose);
> 
>+    void setCaptureExtraNetworkLoadMetricsEnabled(bool);
>+    String ongoingLoadDescriptions();
>+
> private:
>     explicit Internals(Document&);
>     Document* contextDocument() const;
>diff --git a/Source/WebCore/testing/Internals.idl b/Source/WebCore/testing/Internals.idl
>index 4073a04820df567b9f63dcfd2cfe24ece958ceac..a51b5435579f6a85290e356b5c1767a79adaa9bb 100644
>--- a/Source/WebCore/testing/Internals.idl
>+++ b/Source/WebCore/testing/Internals.idl
>@@ -625,4 +625,7 @@ enum EventThrottlingBehavior {
>     [Conditional=VIDEO, MayThrowException] readonly attribute NowPlayingState nowPlayingState;
> 
>     [Conditional=VIDEO] HTMLMediaElement bestMediaElementForShowingPlaybackControlsManager(PlaybackControlsPurpose purpose);
>+
>+    DOMString ongoingLoadDescriptions();
>+    void setCaptureExtraNetworkLoadMetricsEnabled(boolean value);
> };
>diff --git a/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp b/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp
>index 29250baaed205f32af218bdb386471788f13cd2a..6551ff7ade3309c904c83b6c4ad92770721e7749 100644
>--- a/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp
>+++ b/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp
>@@ -39,9 +39,10 @@ namespace WebKit {
> 
> using namespace WebCore;
> 
>-NetworkCORSPreflightChecker::NetworkCORSPreflightChecker(Parameters&& parameters, CompletionCallback&& completionCallback)
>+NetworkCORSPreflightChecker::NetworkCORSPreflightChecker(Parameters&& parameters, bool shouldCaptureExtraNetworkLoadMetrics, CompletionCallback&& completionCallback)
>     : m_parameters(WTFMove(parameters))
>     , m_completionCallback(WTFMove(completionCallback))
>+    , m_shouldCaptureExtraNetworkLoadMetrics(shouldCaptureExtraNetworkLoadMetrics)
> {
> }
> 
>@@ -67,6 +68,9 @@ void NetworkCORSPreflightChecker::startPreflight()
>     if (!m_parameters.userAgent.isNull())
>         loadParameters.request.setHTTPHeaderField(HTTPHeaderName::UserAgent, m_parameters.userAgent);
> 
>+    if (m_shouldCaptureExtraNetworkLoadMetrics)
>+        m_loadInformation = NetworkTransactionInformation { NetworkTransactionInformation::Type::Preflight, loadParameters.request, { }, { } };
>+
>     if (auto* networkSession = SessionTracker::networkSession(loadParameters.sessionID)) {
>         m_task = NetworkDataTask::create(*networkSession, *this, WTFMove(loadParameters));
>         m_task->resume();
>@@ -76,6 +80,9 @@ void NetworkCORSPreflightChecker::startPreflight()
> 
> void NetworkCORSPreflightChecker::willPerformHTTPRedirection(WebCore::ResourceResponse&& response, WebCore::ResourceRequest&&, RedirectCompletionHandler&& completionHandler)
> {
>+    if (m_shouldCaptureExtraNetworkLoadMetrics)
>+        m_loadInformation.response = WTFMove(response);
>+
>     RELEASE_LOG_IF_ALLOWED("willPerformHTTPRedirection");
>     completionHandler({ });
>     m_completionCallback(ResourceError { errorDomainWebKitInternal, 0, m_parameters.originalRequest.url(), ASCIILiteral("Preflight response is not successful"), ResourceError::Type::AccessControl });
>@@ -97,6 +104,10 @@ void NetworkCORSPreflightChecker::didReceiveChallenge(const WebCore::Authenticat
> void NetworkCORSPreflightChecker::didReceiveResponseNetworkSession(WebCore::ResourceResponse&& response, ResponseCompletionHandler&& completionHandler)
> {
>     RELEASE_LOG_IF_ALLOWED("didReceiveResponseNetworkSession");
>+
>+    if (m_shouldCaptureExtraNetworkLoadMetrics)
>+        m_loadInformation.response = response;
>+
>     m_response = WTFMove(response);
>     completionHandler(PolicyAction::Use);
> }
>@@ -106,8 +117,11 @@ void NetworkCORSPreflightChecker::didReceiveData(Ref<WebCore::SharedBuffer>&&)
>     RELEASE_LOG_IF_ALLOWED("didReceiveData");
> }
> 
>-void NetworkCORSPreflightChecker::didCompleteWithError(const WebCore::ResourceError& preflightError, const WebCore::NetworkLoadMetrics&)
>+void NetworkCORSPreflightChecker::didCompleteWithError(const WebCore::ResourceError& preflightError, const WebCore::NetworkLoadMetrics& metrics)
> {
>+    if (m_shouldCaptureExtraNetworkLoadMetrics)
>+        m_loadInformation.metrics = metrics;
>+
>     if (!preflightError.isNull()) {
>         RELEASE_LOG_IF_ALLOWED("didCompleteWithError");
>         auto error = preflightError;
>@@ -145,4 +159,10 @@ void NetworkCORSPreflightChecker::cannotShowURL()
>     m_completionCallback(ResourceError { errorDomainWebKitInternal, 0, m_parameters.originalRequest.url(), ASCIILiteral("Preflight response was blocked"), ResourceError::Type::AccessControl });
> }
> 
>+NetworkTransactionInformation NetworkCORSPreflightChecker::takeInformation()
>+{
>+    ASSERT(m_shouldCaptureExtraNetworkLoadMetrics);
>+    return WTFMove(m_loadInformation);
>+}
>+
> } // Namespace WebKit
>diff --git a/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.h b/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.h
>index 42e69e60df1ede2749cf056fffdc4040a5255406..e66ea6d33d54875fe5b859b263927388062d1a5d 100644
>--- a/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.h
>+++ b/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.h
>@@ -26,8 +26,7 @@
> #pragma once
> 
> #include "NetworkDataTask.h"
>-#include <WebCore/ResourceRequest.h>
>-#include <WebCore/ResourceResponse.h>
>+#include <WebCore/NetworkLoadInformation.h>
> #include <WebCore/StoredCredentialsPolicy.h>
> #include <pal/SessionID.h>
> #include <wtf/CompletionHandler.h>
>@@ -52,12 +51,14 @@ public:
>     };
>     using CompletionCallback = CompletionHandler<void(WebCore::ResourceError&&)>;
> 
>-    NetworkCORSPreflightChecker(Parameters&&, CompletionCallback&&);
>+    NetworkCORSPreflightChecker(Parameters&&, bool shouldCaptureExtraNetworkLoadMetrics, CompletionCallback&&);
>     ~NetworkCORSPreflightChecker();
>     const WebCore::ResourceRequest& originalRequest() const { return m_parameters.originalRequest; }
> 
>     void startPreflight();
> 
>+    WebCore::NetworkTransactionInformation takeInformation();
>+
> private:
>     void willPerformHTTPRedirection(WebCore::ResourceResponse&&, WebCore::ResourceRequest&&, RedirectCompletionHandler&&) final;
>     void didReceiveChallenge(const WebCore::AuthenticationChallenge&, ChallengeCompletionHandler&&) final;
>@@ -72,6 +73,8 @@ private:
>     WebCore::ResourceResponse m_response;
>     CompletionCallback m_completionCallback;
>     RefPtr<NetworkDataTask> m_task;
>+    bool m_shouldCaptureExtraNetworkLoadMetrics { false };
>+    WebCore::NetworkTransactionInformation m_loadInformation;
> };
> 
> } // namespace WebKit
>diff --git a/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h b/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
>index 15e5b211e8f9c37791f1a09e33e83a8543867583..e6b6ca41e5145c29e0d234140f75b321a6f3a8db 100644
>--- a/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
>+++ b/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
>@@ -33,6 +33,7 @@
> #include "NetworkConnectionToWebProcessMessages.h"
> #include "NetworkMDNSRegister.h"
> #include "NetworkRTCProvider.h"
>+#include <WebCore/NetworkLoadInformation.h>
> #include <WebCore/ResourceLoadPriority.h>
> #include <wtf/RefCounted.h>
> 
>@@ -77,33 +78,37 @@ public:
>     void cleanupForSuspension(Function<void()>&&);
>     void endSuspension();
> 
>-    // FIXME: We should store all redirected request/responses.
>-    struct NetworkLoadInformation {
>-        WebCore::ResourceResponse response;
>-        WebCore::NetworkLoadMetrics metrics;
>-    };
>+    void takeNetworkLoadInformationRequest(ResourceLoadIdentifier identifier, WebCore::ResourceRequest& request)
>+    {
>+        request = m_networkLoadInformationByID.get(identifier).request;
>+    }
> 
>     void takeNetworkLoadInformationResponse(ResourceLoadIdentifier identifier, WebCore::ResourceResponse& response)
>     {
>         response = m_networkLoadInformationByID.get(identifier).response;
>     }
> 
>+    void takeNetworkLoadIntermediateInformation(ResourceLoadIdentifier identifier, Vector<WebCore::NetworkTransactionInformation>& information)
>+    {
>+        information = m_networkLoadInformationByID.get(identifier).transactions;
>+    }
>+
>     void takeNetworkLoadInformationMetrics(ResourceLoadIdentifier identifier, WebCore::NetworkLoadMetrics& metrics)
>     {
>         metrics = m_networkLoadInformationByID.take(identifier).metrics;
>     }
> 
>-    void addNetworkLoadInformationResponse(ResourceLoadIdentifier identifier, const WebCore::ResourceResponse& response)
>+    void addNetworkLoadInformation(ResourceLoadIdentifier identifier, WebCore::NetworkLoadInformation&& information)
>     {
>         ASSERT(!m_networkLoadInformationByID.contains(identifier));
>-        m_networkLoadInformationByID.add(identifier, NetworkLoadInformation { response, { } });
>+        m_networkLoadInformationByID.add(identifier, WTFMove(information));
>     }
> 
>     void addNetworkLoadInformationMetrics(ResourceLoadIdentifier identifier, const WebCore::NetworkLoadMetrics& metrics)
>     {
>         ASSERT(m_networkLoadInformationByID.contains(identifier));
>         m_networkLoadInformationByID.ensure(identifier, [] {
>-            return NetworkLoadInformation { };
>+            return WebCore::NetworkLoadInformation { };
>         }).iterator->value.metrics = metrics;
>     }
> 
>@@ -221,7 +226,7 @@ private:
>     HashMap<String, RefPtr<WebCore::BlobDataFileReference>> m_blobDataFileReferences;
>     Vector<ResourceNetworkActivityTracker> m_networkActivityTrackers;
> 
>-    HashMap<ResourceLoadIdentifier, NetworkLoadInformation> m_networkLoadInformationByID;
>+    HashMap<ResourceLoadIdentifier, WebCore::NetworkLoadInformation> m_networkLoadInformationByID;
> 
> 
> #if USE(LIBWEBRTC)
>diff --git a/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in b/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
>index f4ec63311f77a3be67187b896d52a0178baf7154..bf2c454e1f23953b7b673ff0712b55a98bc0262c 100644
>--- a/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
>+++ b/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
>@@ -66,6 +66,8 @@ messages -> NetworkConnectionToWebProcess LegacyReceiver {
>     RemoveOriginAccessWhitelistEntry(String sourceOrigin, String destinationProtocol, String destinationHost, bool allowDestinationSubdomains);
>     ResetOriginAccessWhitelists();
> 
>+    TakeNetworkLoadInformationRequest(uint64_t resourceLoadIdentifier) -> (WebCore::ResourceRequest request);
>     TakeNetworkLoadInformationResponse(uint64_t resourceLoadIdentifier) -> (WebCore::ResourceResponse response);
>+    TakeNetworkLoadIntermediateInformation(uint64_t resourceLoadIdentifier) -> (Vector<WebCore::NetworkTransactionInformation> transactions);
>     TakeNetworkLoadInformationMetrics(uint64_t resourceLoadIdentifier) -> (WebCore::NetworkLoadMetrics networkMetrics);
> }
>diff --git a/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp b/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp
>index d0f21256534a9be2de01838b9e0ba6965caa074d..c3b8644694f8700c745478849ea59bc1add2784c 100644
>--- a/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp
>+++ b/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp
>@@ -52,7 +52,7 @@ static inline bool isSameOrigin(const URL& url, const SecurityOrigin* origin)
>     return url.protocolIsData() || url.protocolIsBlob() || !origin || origin->canRequest(url);
> }
> 
>-NetworkLoadChecker::NetworkLoadChecker(NetworkConnectionToWebProcess& connection, uint64_t webPageID, uint64_t webFrameID, ResourceLoadIdentifier loadIdentifier, FetchOptions&& options, PAL::SessionID sessionID, HTTPHeaderMap&& originalRequestHeaders, URL&& url, RefPtr<SecurityOrigin>&& sourceOrigin, PreflightPolicy preflightPolicy, String&& referrer)
>+NetworkLoadChecker::NetworkLoadChecker(NetworkConnectionToWebProcess& connection, uint64_t webPageID, uint64_t webFrameID, ResourceLoadIdentifier loadIdentifier, FetchOptions&& options, PAL::SessionID sessionID, HTTPHeaderMap&& originalRequestHeaders, URL&& url, RefPtr<SecurityOrigin>&& sourceOrigin, PreflightPolicy preflightPolicy, String&& referrer, bool shouldCaptureExtraNetworkLoadMetrics)
>     : m_connection(connection)
>     , m_webPageID(webPageID)
>     , m_webFrameID(webFrameID)
>@@ -64,6 +64,7 @@ NetworkLoadChecker::NetworkLoadChecker(NetworkConnectionToWebProcess& connection
>     , m_origin(WTFMove(sourceOrigin))
>     , m_preflightPolicy(preflightPolicy)
>     , m_referrer(WTFMove(referrer))
>+    , m_shouldCaptureExtraNetworkLoadMetrics(shouldCaptureExtraNetworkLoadMetrics)
> {
>     m_isSameOriginRequest = isSameOrigin(m_url, m_origin.get());
>     switch (options.credentials) {
>@@ -85,6 +86,9 @@ void NetworkLoadChecker::check(ResourceRequest&& request, ValidationHandler&& ha
> {
>     ASSERT(!isChecking());
> 
>+    if (m_shouldCaptureExtraNetworkLoadMetrics)
>+        m_loadInformation.request = request;
>+
>     m_firstRequestHeaders = request.httpHeaderFields();
>     // FIXME: We should not get this information from the request but directly from some NetworkProcess setting.
>     m_dntHeaderValue = m_firstRequestHeaders.get(HTTPHeaderName::DNT);
>@@ -358,7 +362,7 @@ void NetworkLoadChecker::checkCORSRequestWithPreflight(ResourceRequest&& request
>         m_sessionID,
>         m_storedCredentialsPolicy
>     };
>-    m_corsPreflightChecker = std::make_unique<NetworkCORSPreflightChecker>(WTFMove(parameters), [this, request = WTFMove(request), handler = WTFMove(handler), isRedirected = isRedirected()](auto&& error) mutable {
>+    m_corsPreflightChecker = std::make_unique<NetworkCORSPreflightChecker>(WTFMove(parameters), m_shouldCaptureExtraNetworkLoadMetrics, [this, request = WTFMove(request), handler = WTFMove(handler), isRedirected = isRedirected()](auto&& error) mutable {
>         RELEASE_LOG_IF_ALLOWED("checkCORSRequestWithPreflight - makeCrossOriginAccessRequestWithPreflight preflight complete, success: %d forRedirect? %d", error.isNull(), isRedirected);
> 
>         if (!error.isNull()) {
>@@ -366,6 +370,9 @@ void NetworkLoadChecker::checkCORSRequestWithPreflight(ResourceRequest&& request
>             return;
>         }
> 
>+        if (m_shouldCaptureExtraNetworkLoadMetrics)
>+            m_loadInformation.transactions.append(m_corsPreflightChecker->takeInformation());
>+
>         auto corsPreflightChecker = WTFMove(m_corsPreflightChecker);
>         updateRequestForAccessControl(request, *m_origin, m_storedCredentialsPolicy);
>         handler(WTFMove(request));
>@@ -429,10 +436,17 @@ void NetworkLoadChecker::sendCSPViolationReport(URL&& reportURL, Ref<FormData>&&
>         m_connection->connection().send(Messages::WebPage::SendCSPViolationReport { m_webFrameID, WTFMove(reportURL), IPC::FormDataReference { WTFMove(report) } }, m_webPageID);
> }
> 
>-void NetworkLoadChecker::enqueueSecurityPolicyViolationEvent(WebCore::SecurityPolicyViolationEvent::Init&& eventInit)
>+void NetworkLoadChecker::enqueueSecurityPolicyViolationEvent(SecurityPolicyViolationEvent::Init&& eventInit)
> {
>     if (m_webPageID && m_webFrameID)
>         m_connection->connection().send(Messages::WebPage::EnqueueSecurityPolicyViolationEvent { m_webFrameID, WTFMove(eventInit) }, m_webPageID);
> }
> 
>+void NetworkLoadChecker::storeRedirectionIfNeeded(const ResourceRequest& request, const ResourceResponse& response)
>+{
>+    if (!m_shouldCaptureExtraNetworkLoadMetrics)
>+        return;
>+    m_loadInformation.transactions.append(NetworkTransactionInformation { NetworkTransactionInformation::Type::Redirection, ResourceRequest { request }, ResourceResponse { response }, { } });
>+}
>+
> } // namespace WebKit
>diff --git a/Source/WebKit/NetworkProcess/NetworkLoadChecker.h b/Source/WebKit/NetworkProcess/NetworkLoadChecker.h
>index 1442639e2575a952f4e75ff4454e80a5946af839..1e5a74bedd7028548239f6ecb3d9377be03f5bf1 100644
>--- a/Source/WebKit/NetworkProcess/NetworkLoadChecker.h
>+++ b/Source/WebKit/NetworkProcess/NetworkLoadChecker.h
>@@ -28,8 +28,8 @@
> #include "NetworkContentRuleListManager.h"
> #include "NetworkResourceLoadParameters.h"
> #include <WebCore/ContentSecurityPolicyClient.h>
>+#include <WebCore/NetworkLoadInformation.h>
> #include <WebCore/ResourceError.h>
>-#include <WebCore/ResourceResponse.h>
> #include <WebCore/SecurityPolicyViolationEvent.h>
> #include <wtf/CompletionHandler.h>
> #include <wtf/Expected.h>
>@@ -46,7 +46,7 @@ class NetworkCORSPreflightChecker;
> 
> class NetworkLoadChecker : public WebCore::ContentSecurityPolicyClient, public CanMakeWeakPtr<NetworkLoadChecker> {
> public:
>-    NetworkLoadChecker(NetworkConnectionToWebProcess&, uint64_t webPageID, uint64_t webFrameID, ResourceLoadIdentifier, WebCore::FetchOptions&&, PAL::SessionID, WebCore::HTTPHeaderMap&&, WebCore::URL&&, RefPtr<WebCore::SecurityOrigin>&&, WebCore::PreflightPolicy, String&& referrer);
>+    NetworkLoadChecker(NetworkConnectionToWebProcess&, uint64_t webPageID, uint64_t webFrameID, ResourceLoadIdentifier, WebCore::FetchOptions&&, PAL::SessionID, WebCore::HTTPHeaderMap&&, WebCore::URL&&, RefPtr<WebCore::SecurityOrigin>&&, WebCore::PreflightPolicy, String&& referrer, bool shouldCaptureExtraNetworkLoadMetrics);
>     ~NetworkLoadChecker();
> 
>     using RequestOrError = Expected<WebCore::ResourceRequest, WebCore::ResourceError>;
>@@ -69,6 +69,9 @@ public:
>     const WebCore::URL& url() const { return m_url; }
>     WebCore::StoredCredentialsPolicy storedCredentialsPolicy() const { return m_storedCredentialsPolicy; }
> 
>+    WebCore::NetworkLoadInformation takeNetworkLoadInformation() { return WTFMove(m_loadInformation); }
>+    void storeRedirectionIfNeeded(const WebCore::ResourceRequest&, const WebCore::ResourceResponse&);
>+
> private:
>     WebCore::ContentSecurityPolicy* contentSecurityPolicy();
>     bool isChecking() const { return !!m_corsPreflightChecker; }
>@@ -132,6 +135,8 @@ private:
>     WebCore::PreflightPolicy m_preflightPolicy;
>     String m_dntHeaderValue;
>     String m_referrer;
>+    bool m_shouldCaptureExtraNetworkLoadMetrics { false };
>+    WebCore::NetworkLoadInformation m_loadInformation;
> };
> 
> }
>diff --git a/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp b/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
>index c5f675197f83e3b19a5bd125877fbd4ed421921d..4d51ba75021a58fb5532d412beaeadc9fb6f692f 100644
>--- a/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
>+++ b/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
>@@ -119,7 +119,7 @@ NetworkResourceLoader::NetworkResourceLoader(NetworkResourceLoadParameters&& par
>     }
> 
>     if (synchronousReply || parameters.shouldRestrictHTTPResponseAccess) {
>-        m_networkLoadChecker = std::make_unique<NetworkLoadChecker>(m_connection, m_parameters.webPageID, m_parameters.webFrameID, identifier(), FetchOptions { m_parameters.options }, m_parameters.sessionID, HTTPHeaderMap { m_parameters.originalRequestHeaders }, URL { m_parameters.request.url() }, m_parameters.sourceOrigin.copyRef(), m_parameters.preflightPolicy, originalRequest().httpReferrer());
>+        m_networkLoadChecker = std::make_unique<NetworkLoadChecker>(m_connection, m_parameters.webPageID, m_parameters.webFrameID, identifier(), FetchOptions { m_parameters.options }, m_parameters.sessionID, HTTPHeaderMap { m_parameters.originalRequestHeaders }, URL { m_parameters.request.url() }, m_parameters.sourceOrigin.copyRef(), m_parameters.preflightPolicy, originalRequest().httpReferrer(), shouldCaptureExtraNetworkLoadMetrics());
>         if (m_parameters.cspResponseHeaders)
>             m_networkLoadChecker->setCSPResponseHeaders(ContentSecurityPolicyResponseHeaders { m_parameters.cspResponseHeaders.value() });
> #if ENABLE(CONTENT_EXTENSIONS)
>@@ -426,8 +426,11 @@ auto NetworkResourceLoader::didReceiveResponse(ResourceResponse&& receivedRespon
> 
>     m_response = WTFMove(receivedResponse);
> 
>-    if (shouldCaptureExtraNetworkLoadMetrics())
>-        m_connection->addNetworkLoadInformationResponse(identifier(), m_response);
>+    if (shouldCaptureExtraNetworkLoadMetrics() && m_networkLoadChecker) {
>+        auto information = m_networkLoadChecker->takeNetworkLoadInformation();
>+        information.response = m_response;
>+        m_connection->addNetworkLoadInformation(identifier(), WTFMove(information));
>+    }
> 
>     // For multipart/x-mixed-replace didReceiveResponseAsync gets called multiple times and buffering would require special handling.
>     if (!isSynchronous() && m_response.isMultipart())
>@@ -568,7 +571,7 @@ void NetworkResourceLoader::didBlockAuthenticationChallenge()
>     send(Messages::WebResourceLoader::DidBlockAuthenticationChallenge());
> }
> 
>-void NetworkResourceLoader::willSendRedirectedRequest(ResourceRequest&& request, WebCore::ResourceRequest&& redirectRequest, ResourceResponse&& redirectResponse)
>+void NetworkResourceLoader::willSendRedirectedRequest(ResourceRequest&& request, ResourceRequest&& redirectRequest, ResourceResponse&& redirectResponse)
> {
>     ++m_redirectCount;
> 
>@@ -576,6 +579,7 @@ void NetworkResourceLoader::willSendRedirectedRequest(ResourceRequest&& request,
>         m_cache->storeRedirect(request, redirectResponse, redirectRequest);
> 
>     if (m_networkLoadChecker) {
>+        m_networkLoadChecker->storeRedirectionIfNeeded(request, redirectResponse);
>         m_networkLoadChecker->checkRedirection(redirectResponse, WTFMove(redirectRequest), [protectedThis = makeRef(*this), this, storedCredentialsPolicy = m_networkLoadChecker->storedCredentialsPolicy(), request = WTFMove(request), redirectResponse](auto&& result) mutable {
>             if (!result.has_value()) {
>                 if (result.error().isCancellation())
>diff --git a/Source/WebKit/NetworkProcess/PingLoad.cpp b/Source/WebKit/NetworkProcess/PingLoad.cpp
>index 1aece4792d2e6ead4b042dbd393c41177b690ac2..a098c3c7cd3542b3baede6e1a4fe11e545647e05 100644
>--- a/Source/WebKit/NetworkProcess/PingLoad.cpp
>+++ b/Source/WebKit/NetworkProcess/PingLoad.cpp
>@@ -42,7 +42,7 @@ PingLoad::PingLoad(NetworkResourceLoadParameters&& parameters, NetworkConnection
>     : m_parameters(WTFMove(parameters))
>     , m_completionHandler(WTFMove(completionHandler))
>     , m_timeoutTimer(*this, &PingLoad::timeoutTimerFired)
>-    , m_networkLoadChecker(makeUniqueRef<NetworkLoadChecker>(connection, m_parameters.webPageID, m_parameters.webFrameID, m_parameters.identifier, FetchOptions { m_parameters.options}, m_parameters.sessionID, WTFMove(m_parameters.originalRequestHeaders), URL { m_parameters.request.url() }, m_parameters.sourceOrigin.copyRef(), m_parameters.preflightPolicy, m_parameters.request.httpReferrer()))
>+    , m_networkLoadChecker(makeUniqueRef<NetworkLoadChecker>(connection, m_parameters.webPageID, m_parameters.webFrameID, m_parameters.identifier, FetchOptions { m_parameters.options}, m_parameters.sessionID, WTFMove(m_parameters.originalRequestHeaders), URL { m_parameters.request.url() }, m_parameters.sourceOrigin.copyRef(), m_parameters.preflightPolicy, m_parameters.request.httpReferrer(), false))
> {
> 
>     if (m_parameters.cspResponseHeaders)
>diff --git a/Source/WebKit/Scripts/webkit/messages.py b/Source/WebKit/Scripts/webkit/messages.py
>index 16e2867a9b0820a3a857d409a51f61260721dbb6..022137eb15644e489256041102c337b87906dfbd 100644
>--- a/Source/WebKit/Scripts/webkit/messages.py
>+++ b/Source/WebKit/Scripts/webkit/messages.py
>@@ -388,6 +388,7 @@ def headers_for_type(type):
>         'WebCore::IncludeSecureCookies': ['<WebCore/CookiesStrategy.h>'],
>         'WebCore::KeyframeValueList': ['<WebCore/GraphicsLayer.h>'],
>         'WebCore::KeypressCommand': ['<WebCore/KeyboardEvent.h>'],
>+        'WebCore::NetworkTransactionInformation': ['<WebCore/NetworkLoadInformation.h>'],
>         'WebCore::PasteboardCustomData': ['<WebCore/Pasteboard.h>'],
>         'WebCore::PasteboardImage': ['<WebCore/Pasteboard.h>'],
>         'WebCore::PasteboardURL': ['<WebCore/Pasteboard.h>'],
>diff --git a/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp b/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
>index 097b8bbd3ecf4551f671eb3a847ebf3e920e0ea6..d7bd90b79b356508d798ade9fdc8598abe64590a 100644
>--- a/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
>+++ b/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
>@@ -56,10 +56,10 @@
> #include <WebCore/Frame.h>
> #include <WebCore/FrameLoader.h>
> #include <WebCore/NetscapePlugInStreamLoader.h>
>+#include <WebCore/NetworkLoadInformation.h>
> #include <WebCore/PlatformStrategies.h>
> #include <WebCore/ReferrerPolicy.h>
> #include <WebCore/ResourceLoader.h>
>-#include <WebCore/ResourceResponse.h>
> #include <WebCore/RuntimeEnabledFeatures.h>
> #include <WebCore/SecurityOrigin.h>
> #include <WebCore/Settings.h>
>@@ -658,6 +658,13 @@ ResourceResponse WebLoaderStrategy::responseFromResourceLoadIdentifier(uint64_t
>     return response;
> }
> 
>+Vector<NetworkTransactionInformation> WebLoaderStrategy::intermediateLoadInformationFromResourceLoadIdentifier(uint64_t resourceLoadIdentifier)
>+{
>+    Vector<NetworkTransactionInformation> information;
>+    WebProcess::singleton().ensureNetworkProcessConnection().connection().sendSync(Messages::NetworkConnectionToWebProcess::TakeNetworkLoadIntermediateInformation { resourceLoadIdentifier }, Messages::NetworkConnectionToWebProcess::TakeNetworkLoadIntermediateInformation::Reply { information }, 0, Seconds::infinity(), IPC::SendSyncOption::DoNotProcessIncomingMessagesWhenWaitingForSyncReply);
>+    return information;
>+}
>+
> NetworkLoadMetrics WebLoaderStrategy::networkMetricsFromResourceLoadIdentifier(uint64_t resourceLoadIdentifier)
> {
>     NetworkLoadMetrics networkMetrics;
>diff --git a/Source/WebKit/WebProcess/Network/WebLoaderStrategy.h b/Source/WebKit/WebProcess/Network/WebLoaderStrategy.h
>index ed023fcb9f8b6c5b6d24f57abd1dd1893f300b08..0983f4210ff54d3f4d78641bfb4f17ffdc401f6c 100644
>--- a/Source/WebKit/WebProcess/Network/WebLoaderStrategy.h
>+++ b/Source/WebKit/WebProcess/Network/WebLoaderStrategy.h
>@@ -92,11 +92,19 @@ private:
>     bool tryLoadingUsingURLSchemeHandler(WebCore::ResourceLoader&);
> 
>     WebCore::ResourceResponse responseFromResourceLoadIdentifier(uint64_t resourceLoadIdentifier) final;
>+    Vector<WebCore::NetworkTransactionInformation> intermediateLoadInformationFromResourceLoadIdentifier(uint64_t resourceLoadIdentifier) final;
>     WebCore::NetworkLoadMetrics networkMetricsFromResourceLoadIdentifier(uint64_t resourceLoadIdentifier) final;
> 
>     bool shouldPerformSecurityChecks() const final;
>     bool havePerformedSecurityChecks(const WebCore::ResourceResponse&) const final;
> 
>+    Vector<uint64_t> ongoingLoads() const final
>+    {
>+        return WTF::map(m_webResourceLoaders, [](auto&& keyValue) -> uint64_t {
>+            return keyValue.key;
>+        });
>+    }
>+
>     HashSet<RefPtr<WebCore::ResourceLoader>> m_internallyFailedResourceLoaders;
>     RunLoop::Timer<WebLoaderStrategy> m_internallyFailedLoadTimer;
>     
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 387f72096379b78ee56817c63cdbef4fb0e1923e..a6509cd54cf72989c5305778a4cc9f28f61f7ecf 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-13  Youenn Fablet  <youenn@apple.com>
>+
>+        Network Preflights do not show in WebInspector after moving CORS checks to NetworkProcess
>+        https://bugs.webkit.org/show_bug.cgi?id=186312
>+        <rdar://problem/40495434>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * http/wpt/fetch/inspect-preflight-expected.txt: Added.
>+        * http/wpt/fetch/inspect-preflight.html: Added.
>+        * http/wpt/fetch/resources/preflight.py: Added.
>+        * platform/mac-wk1/TestExpectations:
>+        * platform/win/TestExpectations:
>+
> 2018-06-13  Per Arne Vollan  <pvollan@apple.com>
> 
>         A few layout tests are failing on Windows.
>diff --git a/LayoutTests/http/wpt/fetch/inspect-preflight-expected.txt b/LayoutTests/http/wpt/fetch/inspect-preflight-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..1331ee491a65bb6a43b30d2e1e21d2ee6ac40046
>--- /dev/null
>+++ b/LayoutTests/http/wpt/fetch/inspect-preflight-expected.txt
>@@ -0,0 +1,3 @@
>+
>+PASS Get preflight information 
>+
>diff --git a/LayoutTests/http/wpt/fetch/inspect-preflight.html b/LayoutTests/http/wpt/fetch/inspect-preflight.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..c2bd144c029a06e38e0c45aee9aafdcfa9e13ab8
>--- /dev/null
>+++ b/LayoutTests/http/wpt/fetch/inspect-preflight.html
>@@ -0,0 +1,32 @@
>+<!DOCTYPE html>
>+<html>
>+<head>
>+<title>Storing network load information</title>
>+<script src="/resources/testharness.js"></script>
>+<script src="/resources/testharnessreport.js"></script>
>+<script src="/common/get-host-info.sub.js"></script>
>+</head>
>+<body>
>+<script>
>+promise_test(async (test) => {
>+    if (!window.internals)
>+        return Promise.reject("Internals API required");
>+
>+    internals.setCaptureExtraNetworkLoadMetricsEnabled(true);
>+
>+    const host = get_host_info();
>+    await fetch(host.HTTP_REMOTE_ORIGIN + "/WebKit/fetch/resources/preflight.py", { headers : [["header", "value"]] });
>+
>+    let descriptions = internals.ongoingLoadDescriptions();
>+    internals.setCaptureExtraNetworkLoadMetricsEnabled(false);
>+
>+    let result = JSON.parse(descriptions)[0][0];
>+
>+    assert_equals(result[0], 1, "type");
>+    assert_equals(result[2], "OPTIONS", "method");
>+    assert_equals(result[3], 200, "status");
>+
>+}, "Get preflight information");
>+</script>
>+</body>
>+</html>
>diff --git a/LayoutTests/http/wpt/fetch/resources/preflight.py b/LayoutTests/http/wpt/fetch/resources/preflight.py
>new file mode 100644
>index 0000000000000000000000000000000000000000..d60d1d0d855cc05682bf9866cb12edea6905f8a1
>--- /dev/null
>+++ b/LayoutTests/http/wpt/fetch/resources/preflight.py
>@@ -0,0 +1,17 @@
>+import time
>+
>+def main(request, response):
>+    headers = [("Content-Type", "text/plain")]
>+    headers.append(("Access-Control-Allow-Origin", "*"))
>+    headers.append(("Access-Control-Allow-Methods", "GET"))
>+    headers.append(("Access-Control-Allow-Headers", "header"))
>+
>+    if request.method == "OPTIONS":
>+        return 200, headers, ""
>+
>+    for header in headers:
>+        response.headers.set(header[0], header[1])
>+    response.write_status_headers()
>+    response.writer.write_content("START\n")
>+    time.sleep(5);
>+    response.writer.write_content("END\n")
>diff --git a/LayoutTests/platform/mac-wk1/TestExpectations b/LayoutTests/platform/mac-wk1/TestExpectations
>index f721b1c74423d741e191e6ede9ccb68a6b751b9d..e164b0351d27ba4064bc61d77368f18799b8e0a6 100644
>--- a/LayoutTests/platform/mac-wk1/TestExpectations
>+++ b/LayoutTests/platform/mac-wk1/TestExpectations
>@@ -458,6 +458,7 @@ webkit.org/b/173432 [ Debug ] imported/w3c/web-platform-tests/fetch/nosniff/impo
> 
> # Requires WK2 loading support
> http/wpt/fetch/dnt-header-after-redirection.html [ Skip ]
>+http/wpt/fetch/inspect-preflight.html [ Skip ]
> 
> # requires wk2 speculative tiling
> fast/images/low-memory-decode.html [ Skip ]
>diff --git a/LayoutTests/platform/win/TestExpectations b/LayoutTests/platform/win/TestExpectations
>index d80ac25d85f71b48a3b2565847168bc32962fb2b..08a628546af14a20a1107f91e03ba0fb2549ca55 100644
>--- a/LayoutTests/platform/win/TestExpectations
>+++ b/LayoutTests/platform/win/TestExpectations
>@@ -3721,6 +3721,7 @@ fast/forms/file/entries-api/webkitdirectory-open-panel.html [ Skip ]
> 
> # Requires WK2 loading support
> http/wpt/fetch/dnt-header-after-redirection.html [ Skip ]
>+http/wpt/fetch/inspect-preflight.html [ Skip ]
> 
> # html/syntax web platform tests are failing on Windows.
> webkit.org/b/162415 imported/w3c/web-platform-tests/html/syntax [ Skip ]

Actions: View | Formatted Diff | Diff

Attachments on bug 186312: 341982 | 341985 | 341994 | 342616 | 342676 | 342691 | 343052