Attachment 342684 Details for Bug 186603 – Patch

[patch] Patch

bug-186603-20180613124515.patch (text/plain), 7.11 KB, created by John Wilander on 2018-06-13 12:45:15 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: John Wilander

Created: 2018-06-13 12:45:15 PDT

Size: 7.11 KB

patch

obsolete

>Subversion Revision: 232802
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 3603901450d063b7ae74347ff9a29ee49cfcd22b..9fde60e7b1b95c8033b554c4a6b59979b1469d91 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-13  John Wilander  <wilander@apple.com>
>+
>+        Add console logging to test case to help investigate flaky timeouts
>+        https://bugs.webkit.org/show_bug.cgi?id=186603
>+        <rdar://problem/41096614>
>+
>+        Unreviewed test gardening.
>+
>+        * http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt:
>+        * http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html:
>+            Now has step-by-step console logging so that (hopefully) the flaky timeouts don't produce empty output.
>+
> 2018-06-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
> 
>         TileFirstPaint strategy for async image decoding should be disabled for non root RenderLayers
>diff --git a/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt b/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt
>index 50e82c81652ca42bdf0598f59ba8e946907cde2a..7a33027294d7b09e003005738a9a037b4a32a1ce 100644
>--- a/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt
>+++ b/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt
>@@ -1,3 +1,15 @@
>+CONSOLE MESSAGE: line 114: Bootstrapping test.
>+CONSOLE MESSAGE: line 65: Step 1.
>+CONSOLE MESSAGE: line 70: Step 2.
>+CONSOLE MESSAGE: line 77: Step 3.
>+CONSOLE MESSAGE: line 84: Step 4.
>+CONSOLE MESSAGE: line 54: setNormalCookiePartitioningTimeOutPlusUserInteractionAndContinue().
>+CONSOLE MESSAGE: line 91: Step 5.
>+CONSOLE MESSAGE: line 48: setShortCookiePartitioningTimeOutPlusFireShouldPartitionCookiesHandlerAndContinue().
>+CONSOLE MESSAGE: line 43: fireShouldPartitionCookiesHandlerAndContinue().
>+CONSOLE MESSAGE: line 98: Step 6.
>+CONSOLE MESSAGE: line 54: setNormalCookiePartitioningTimeOutPlusUserInteractionAndContinue().
>+CONSOLE MESSAGE: line 105: Step 7.
> PASS successfullyParsed is true
> 
> TEST COMPLETE
>diff --git a/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html b/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html
>index d722d739708ef74248ae3657b55dee2f542b5e19..26b8ba8f01d1ecb7481727e39400d577d4d61176 100644
>--- a/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html
>+++ b/LayoutTests/http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html
>@@ -40,15 +40,18 @@
>     }
> 
>     function fireShouldPartitionCookiesHandlerAndContinue() {
>+        console.log("fireShouldPartitionCookiesHandlerAndContinue().");
>         testRunner.statisticsUpdateCookiePartitioning(runTest);
>     }
> 
>     function setShortCookiePartitioningTimeOutPlusFireShouldPartitionCookiesHandlerAndContinue() {
>+        console.log("setShortCookiePartitioningTimeOutPlusFireShouldPartitionCookiesHandlerAndContinue().");
>         testRunner.setStatisticsTimeToLiveCookiePartitionFree(1);
>         setTimeout(fireShouldPartitionCookiesHandlerAndContinue, 2000);
>     }
> 
>     function setNormalCookiePartitioningTimeOutPlusUserInteractionAndContinue() {
>+        console.log("setNormalCookiePartitioningTimeOutPlusUserInteractionAndContinue().");
>         testRunner.setStatisticsTimeToLiveCookiePartitionFree(86400);
>         testRunner.setStatisticsHasHadUserInteraction(thirdPartyOrigin, true);
>         if (!testRunner.isStatisticsHasHadUserInteraction(thirdPartyOrigin))
>@@ -59,40 +62,47 @@
>     function runTest() {
>         switch (document.location.hash) {
>             case "#step1":
>+                console.log("Step 1.");
>                 // Set first-party cookie for http://localhost:8000
>                 document.location.href = thirdPartyBaseUrl + subPathToSetFirstPartyCookie + "#" + fragmentWithReturnUrl + "#step2";
>                 break;
>             case "#step2":
>+                console.log("Step 2.");
>                 // Check that the first-party cookie is not sent in partition 127.0.0.1:8000
>                 document.location.hash = "step3";
>                 openIframe(thirdPartyBaseUrl + subPathToGetCookies + "&message=Should receive no cookies.",
>                     runTest);
>                 break;
>             case "#step3":
>+                console.log("Step 3.");
>                 // Set third-party cookie for http://localhost:8000 in partition 127.0.0.1:8000
>                 document.location.hash = "step4";
>                 openIframe(thirdPartyBaseUrl + subPathToSetThirdPartyCookie + "&message=Setting partitioned, third-party cookie.",
>                     runTest);
>                 break;
>             case "#step4":
>+                console.log("Step 4.");
>                 // Check that only partitioned cookie get sent in partition 127.0.0.1:8000
>                 document.location.hash = "step5";
>                 openIframe(thirdPartyBaseUrl + subPathToGetCookies + "&message=Should only receive partitioned, third-party cookie.",
>                     setNormalCookiePartitioningTimeOutPlusUserInteractionAndContinue);
>                 break;
>             case "#step5":
>+                console.log("Step 5.");
>                 // http://localhost:8000 now has user interaction, check that un-partitioned cookie is sent for third-party
>                 document.location.hash = "step6";
>                 openIframe(thirdPartyBaseUrl + subPathToGetCookies + "&message=After first user interaction, should still only receive a partitioned, third-party cookie.",
>                     setShortCookiePartitioningTimeOutPlusFireShouldPartitionCookiesHandlerAndContinue);
>                 break;
>             case "#step6":
>+                console.log("Step 6.");
>                 // Cookie partitioning should be applied again
>                 document.location.hash = "step7";
>                 openIframe(thirdPartyBaseUrl + subPathToGetCookies + "&message=Should only receive partitioned, third-party cookie.",
>                     setNormalCookiePartitioningTimeOutPlusUserInteractionAndContinue);
>                 break;
>             case "#step7":
>+                console.log("Step 7.");
>                 // http://localhost:8000 now has fresh user interaction, check that un-partitioned cookie is sent for third-party
>                 openIframe(thirdPartyBaseUrl + subPathToGetCookies + "&message=After second user interaction, should still only receive a partitioned, third-party cookie.",
>                     finishTest);
>@@ -101,6 +111,7 @@
>     }
> 
>     if (document.location.hash === "" && window.testRunner && window.internals) {
>+        console.log("Bootstrapping test.");
>         setEnableFeature(true);
> 
>         // Set localhost as prevalent and with non-recent user interaction to put it in the partitioning category.

Actions: View | Formatted Diff | Diff

Attachments on bug 186603: 342684