Attachment 342677 Details for Bug 186600 – Patch

[patch] Patch

bug-186600-20180613105902.patch (text/plain), 1.82 KB, created by BJ Burg on 2018-06-13 10:59:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: BJ Burg

Created: 2018-06-13 10:59:03 PDT

Size: 1.82 KB

patch

obsolete

>Subversion Revision: 232754
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 517b87c29b3dd61271bfcf3ef1e959a2518a551d..fa583649fa46b8f025b5e35f1e2854e62c1b76f1 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-06-13  Brian Burg  <bburg@apple.com>
>+
>+        [Cocoa] Web Automation: wrong modifiers sent for 'Help' virtual key
>+        https://bugs.webkit.org/show_bug.cgi?id=186600
>+        <rdar://problem/41088912>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This fixes a hang when running W3C test:
>+
>+            special_keys.py::test_webdriver_special_key_sends_keydown[HELP-expected2]
>+
>+        * UIProcess/Automation/mac/WebAutomationSessionMac.mm:
>+        (WebKit::eventModifierFlagsForVirtualKey):
>+        The help modifier doesn't seem to be used when pressing the Help key.
>+        I verified this using the Help key on the Keyboard Viewer, since no
>+        keyboards from the past decade actually have this physical button.
>+
> 2018-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.4 release.
>diff --git a/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm b/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm
>index f460a38653dc64ee661790730c18cbfb4e0f2b61..bd471fc9ad90736bf23eda19744573419cb70170 100644
>--- a/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm
>+++ b/Source/WebKit/UIProcess/Automation/mac/WebAutomationSessionMac.mm
>@@ -372,8 +372,6 @@ static NSEventModifierFlags eventModifierFlagsForVirtualKey(VirtualKey key)
>         return NSEventModifierFlagCommand;
> 
>     case VirtualKey::Help:
>-        return NSEventModifierFlagHelp | NSEventModifierFlagFunction;
>-
>     case VirtualKey::PageUp:
>     case VirtualKey::PageDown:
>     case VirtualKey::End:

Actions: View | Formatted Diff | Diff

Attachments on bug 186600: 342677