Attachment 342628 Details for Bug 186071 – patch

[patch] patch

a-backup.diff (text/plain), 1.86 KB, created by Saam Barati on 2018-06-12 21:56:15 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2018-06-12 21:56:15 PDT

Size: 1.86 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 232787)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-06-12  Saam Barati  <sbarati@apple.com>
>+
>+        Remove JSVirtualMachine shrinkFootprint when clients move to shrinkFootprintWhenIdle
>+        https://bugs.webkit.org/show_bug.cgi?id=186071
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * API/JSVirtualMachine.mm:
>+        (-[JSVirtualMachine shrinkFootprint]): Deleted.
>+        * API/JSVirtualMachinePrivate.h:
>+
> 2018-06-11  Saam Barati  <sbarati@apple.com>
> 
>         Reduce graph size by replacing terminal nodes in blocks that have a ForceOSRExit with Unreachable
>Index: Source/JavaScriptCore/API/JSVirtualMachine.mm
>===================================================================
>--- Source/JavaScriptCore/API/JSVirtualMachine.mm	(revision 232767)
>+++ Source/JavaScriptCore/API/JSVirtualMachine.mm	(working copy)
>@@ -268,13 +268,6 @@ - (NSMapTable *)externalRememberedSet
>     return m_externalRememberedSet;
> }
> 
>-- (void)shrinkFootprint
>-{
>-    JSC::VM* vm = toJS(m_group);
>-    JSC::JSLockHolder locker(vm);
>-    vm->shrinkFootprintWhenIdle();
>-}
>-
> - (void)shrinkFootprintWhenIdle
> {
>     JSC::VM* vm = toJS(m_group);
>Index: Source/JavaScriptCore/API/JSVirtualMachinePrivate.h
>===================================================================
>--- Source/JavaScriptCore/API/JSVirtualMachinePrivate.h	(revision 232767)
>+++ Source/JavaScriptCore/API/JSVirtualMachinePrivate.h	(working copy)
>@@ -31,8 +31,6 @@
> 
> @interface JSVirtualMachine(JSPrivate)
> 
>-- (void)shrinkFootprint; // FIXME: Remove this SPI when clients move to shrinkFootprintWhenIdle: https://bugs.webkit.org/show_bug.cgi?id=186071
>-
> /*!
> @method
> @discussion Shrinks the memory footprint of the VM by deleting various internal caches,

Actions: View | Formatted Diff | Diff

Attachments on bug 186071: 342627 | 342628