Attachment 342622 Details for Bug 186583 – patch

[patch] patch

a-backup.diff (text/plain), 1.92 KB, created by Saam Barati on 2018-06-12 19:20:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Saam Barati

Created: 2018-06-12 19:20:59 PDT

Size: 1.92 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 232786)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,20 @@
>+2018-06-12  Saam Barati  <sbarati@apple.com>
>+
>+        CFGSimplificationPhase should de-dupe jettisonedBlocks
>+        https://bugs.webkit.org/show_bug.cgi?id=186583
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        When making the predecessors list unique in r232741, it revealed a bug inside
>+        of CFG simplification, where we try to remove the same predecessor more than
>+        once from a blocks predecessors list. We built the list of blocks to remove
>+        from the list of successors, which is not unique, causing us to try to remove
>+        the same predecessor more than once. The solution here is to just add to this
>+        list of blocks to remove only if the block is not already in the list.
>+
>+        * dfg/DFGCFGSimplificationPhase.cpp:
>+        (JSC::DFG::CFGSimplificationPhase::run):
>+
> 2018-06-11  Saam Barati  <sbarati@apple.com>
> 
>         Reduce graph size by replacing terminal nodes in blocks that have a ForceOSRExit with Unreachable
>Index: Source/JavaScriptCore/dfg/DFGCFGSimplificationPhase.cpp
>===================================================================
>--- Source/JavaScriptCore/dfg/DFGCFGSimplificationPhase.cpp	(revision 232767)
>+++ Source/JavaScriptCore/dfg/DFGCFGSimplificationPhase.cpp	(working copy)
>@@ -182,7 +182,7 @@ public:
>                         
>                         Vector<BasicBlock*, 1> jettisonedBlocks;
>                         for (BasicBlock* successor : terminal->successors()) {
>-                            if (successor != targetBlock)
>+                            if (successor != targetBlock && !jettisonedBlocks.contains(successor))
>                                 jettisonedBlocks.append(successor);
>                         }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 186583: 342622