Attachment 342583 Details for Bug 186527 – Patch

[patch] Patch

bug-186527-20180612155336.patch (text/plain), 3.11 KB, created by valerie on 2018-06-12 12:53:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: valerie

Created: 2018-06-12 12:53:38 PDT

Size: 3.11 KB

patch

obsolete

>Subversion Revision: 232767
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 599e234f0a2d23cbee97680245a954430263b81a..97282a921392b9718b62ef204f05bf297bbc83d1 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-12  Valerie R Young  <valerie@bocoup.com>
>+
>+        [test262-runner] Test output should summarize tests that are
>+        unexpectedly passing/failing.
>+        https://bugs.webkit.org/show_bug.cgi?id=186527
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/test262/Runner.pm:
>+        (main):
>+          In verbose mode, a summary of all new failing tests
>+          and all new passing tests are printed at the end of
>+          the script output.
>+
> 2018-06-12  Tim Horton  <timothy_horton@apple.com>
> 
>         Add a API test for r232601
>diff --git a/Tools/Scripts/test262/Runner.pm b/Tools/Scripts/test262/Runner.pm
>index f2f412828dbc4be8a94ce7dc34760ae9ac62d741..d045d5589027b52b61d4dcf8667152831aa1deec 100755
>--- a/Tools/Scripts/test262/Runner.pm
>+++ b/Tools/Scripts/test262/Runner.pm
>@@ -358,6 +358,8 @@ sub main {
>     my $newfailcount = 0;
>     my $newpasscount = 0;
>     my $skipfilecount = 0;
>+    my $newfailurereport = '';
>+    my $newpassreport = '';
> 
>     # Create expectation file and calculate results
>     foreach my $test (@results) {
>@@ -381,18 +383,49 @@ sub main {
>             }
> 
>             # If an unexpected failure
>-            $newfailcount++ if !$expectedFailure || ($expectedFailure ne $test->{error});
>+            if (!$expectedFailure || ($expectedFailure ne $test->{error})) {
>+                $newfailcount++;
>+
>+                if ($verbose) {
>+                    my $path = $test->{path};
>+                    my $mode = $test->{mode};
>+                    my $err = $test->{error};
>+                    $newfailurereport .= "FAIL $path ($mode)\n$err\n\n";
>+                }
>+            }
> 
>         }
>         elsif ($test->{result} eq 'PASS') {
>             # If this is an newly passing test
>-            $newpasscount++ if $expectedFailure;
>+            if ($expectedFailure) {
>+                $newpasscount++;
>+
>+                if ($verbose) {
>+                    my $path = $test->{path};
>+                    my $mode = $test->{mode};
>+                    $newpassreport .= "PASS $path ($mode)\n";
>+                }
>+            }
>         }
>         elsif ($test->{result} eq 'SKIP') {
>             $skipfilecount++;
>         }
>     }
> 
>+    # In verbose mode, the result of every test is printed, so summarize useful results
>+    if ($verbose && $expect && ($newfailurereport || $newpassreport)) {
>+        print "\n";
>+        if ($newfailurereport) {
>+            print "---------------NEW FAILING TESTS SUMMARY---------------\n\n";
>+            print "$newfailurereport";
>+        }
>+        if ($newpassreport) {
>+            print "---------------NEW PASSING TESTS SUMMARY---------------\n\n";
>+            print "$newpassreport\n";
>+        }
>+        print "---------------------------------------------------------\n";
>+    }
>+
>     if ($saveExpectations) {
>         DumpFile($expectationsFile, \%failed);
>         print "\nSaved results in: $expectationsFile\n";

Actions: View | Formatted Diff | Diff

Attachments on bug 186527: 342583 | 342604