WebKit Bugzilla
Attachment 342557 Details for
Bug 186567
: FloatingPointEnvironment is only needed for ARM CPUs.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
proposed patch.
bug-186567.patch (text/plain), 2.83 KB, created by
Mark Lam
on 2018-06-12 10:28:40 PDT
(
hide
)
Description:
proposed patch.
Filename:
MIME Type:
Creator:
Mark Lam
Created:
2018-06-12 10:28:40 PDT
Size:
2.83 KB
patch
obsolete
>Index: Source/WebCore/ChangeLog >=================================================================== >--- Source/WebCore/ChangeLog (revision 232757) >+++ Source/WebCore/ChangeLog (working copy) >@@ -1,3 +1,20 @@ >+2018-06-12 Mark Lam <mark.lam@apple.com> >+ >+ FloatingPointEnvironment is only needed for ARM CPUs. >+ https://bugs.webkit.org/show_bug.cgi?id=186567 >+ <rdar://problem/40929441> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ No new tests. This behavior is already covered by existing tests. >+ >+ * platform/ios/wak/FloatingPointEnvironment.cpp: >+ * platform/ios/wak/FloatingPointEnvironment.h: >+ (WebCore::FloatingPointEnvironment::enableDenormalSupport): >+ (WebCore::FloatingPointEnvironment::saveMainThreadEnvironment): >+ (WebCore::FloatingPointEnvironment::propagateMainThreadEnvironment): >+ (WebCore::FloatingPointEnvironment::singleton): >+ > 2018-06-12 Wenson Hsieh <wenson_hsieh@apple.com> > > REGRESSION(r228724): Occasional crash when executing ReplaceSelectionCommand at the end of the document >Index: Source/WebCore/platform/ios/wak/FloatingPointEnvironment.cpp >=================================================================== >--- Source/WebCore/platform/ios/wak/FloatingPointEnvironment.cpp (revision 232757) >+++ Source/WebCore/platform/ios/wak/FloatingPointEnvironment.cpp (working copy) >@@ -29,7 +29,7 @@ > #include <wtf/MainThread.h> > #include <wtf/NeverDestroyed.h> > >-#if PLATFORM(IOS) >+#if PLATFORM(IOS) && (CPU(ARM) || CPU(ARM64)) > > namespace WebCore { > >@@ -73,4 +73,4 @@ void FloatingPointEnvironment::propagate > > } // namespace WebCore > >-#endif // PLATFORM(IOS) >+#endif // PLATFORM(IOS) && (CPU(ARM) || CPU(ARM64)) >Index: Source/WebCore/platform/ios/wak/FloatingPointEnvironment.h >=================================================================== >--- Source/WebCore/platform/ios/wak/FloatingPointEnvironment.h (revision 232757) >+++ Source/WebCore/platform/ios/wak/FloatingPointEnvironment.h (working copy) >@@ -26,12 +26,12 @@ > #ifndef FloatingPointEnvironment_h > #define FloatingPointEnvironment_h > >-#if TARGET_OS_IPHONE >- > #import <fenv.h> > > namespace WebCore { > >+#if PLATFORM(IOS) && (CPU(ARM) || CPU(ARM64)) >+ > class FloatingPointEnvironment { > public: > FloatingPointEnvironment(); >@@ -48,11 +48,22 @@ private: > bool m_isInitialized; > }; > >+#else // not PLATFORM(IOS) && (CPU(ARM) || CPU(ARM64)) >+ >+class FloatingPointEnvironment { >+public: >+ FloatingPointEnvironment() = default; >+ void enableDenormalSupport() { } >+ void saveMainThreadEnvironment() { } >+ void propagateMainThreadEnvironment() { } >+ static FloatingPointEnvironment singleton() { return { }; } >+}; >+ >+#endif // PLATFORM(IOS) && (CPU(ARM) || CPU(ARM64)) >+ > } // namespace WebCore > > using WebCore::FloatingPointEnvironment; > >-#endif // TARGET_OS_IPHONE >- > #endif // FloatingPointEnvironment_h >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
msaboff
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186567
:
342557
|
342563
|
342572
|
342642