Attachment 342439 Details for Bug 186523 – Patch

[patch] Patch

bug-186523-20180611185152.patch (text/plain), 12.31 KB, created by Carlos Alberto Lopez Perez on 2018-06-11 09:51:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Alberto Lopez Perez

Created: 2018-06-11 09:51:53 PDT

Size: 12.31 KB

patch

obsolete

>Subversion Revision: 232714
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 1ad6b83000ce08bfe8d1fe6481ebc1a48f301efe..3c618b1e31461ca91cccc410b0c8ae10fe95a732 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,37 @@
>+2018-06-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
>+
>+        [JSCOnly] Add a MIPS32el JSCOnly EWS
>+        https://bugs.webkit.org/show_bug.cgi?id=186523
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Add a new jsc-mips-ews queue that will execute build-jsc for the jsc-only (Linux) port.
>+        The worker(s) on this queue should be pre-configured to cross-build JSC for MIPS32el.
>+
>+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Add also here the missed WPE bubble.
>+        (BubbleQueueServer):
>+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
>+        * QueueStatusServer/config/queues.py:
>+        * QueueStatusServer/model/queues.py:
>+        (Queue.display_name):
>+        * Scripts/webkitpy/common/config/ews.json:
>+        * Scripts/webkitpy/common/config/ports.py:
>+        (DeprecatedPort.port):
>+        (WpePort.run_webkit_tests_command):
>+        (JscOnlyPort):
>+        (JscOnlyPort.build_jsc_command):
>+        * Scripts/webkitpy/common/config/ports_unittest.py:
>+        (DeprecatedPortTest.test_wincairo_port):
>+        (DeprecatedPortTest):
>+        (DeprecatedPortTest.test_jsconly_port):
>+        * Scripts/webkitpy/port/factory.py:
>+        (PortFactory):
>+        * Scripts/webkitpy/port/jsc_only.py: Added. Add a basic port definition. Required by the EWS tooling.
>+        (JscOnlyPort):
>+        (JscOnlyPort.__init__):
>+        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
>+        (test_ews_name):
>+
> 2018-06-11  Philippe Normand  <pnormand@igalia.com>
> 
>         [webkitpy] PHP7.2 support on Debian platforms
>diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js
>index 7742a9b0b5aa98e34ba1cea50e719c198f2b60af..c713d0e7e2507e8a105de32a12a00cdee0c0b2f8 100644
>--- a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js
>+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js
>@@ -32,13 +32,15 @@ BubbleQueueServer = function()
>         "ios-ews": {platform: Dashboard.Platform.iOS11Device, shortName: "ios", title: "Release\xa0Build\xa0EWS"},
>         "ios-sim-ews": {platform: Dashboard.Platform.iOS11Simulator, shortName: "ios-sim", title: "WebKit2\xa0Release\xa0Tests\xa0EWS"},
>         "jsc-ews": {platform: Dashboard.Platform.macOSSierra, shortName: "jsc", title: "Release\xa0JSC\xa0Tests\xa0EWS"},
>+        "jsc-mips-ews": {platform: Dashboard.Platform.LinuxJSCOnly, shortName: "jsc", title: "Release\xa0JSC\xa0Build\xa0EWS"},
>         "mac-ews": {platform: Dashboard.Platform.macOSSierra, shortName: "mac", title: "WebKit1\xa0Release\xa0Tests\xa0EWS"},
>         "mac-wk2-ews": {platform: Dashboard.Platform.macOSSierra, shortName: "mac-wk2", title: "WebKit2\xa0Release\xa0Tests\xa0EWS"},
>         "mac-debug-ews": {platform: Dashboard.Platform.macOSSierra, shortName: "mac-debug", title: "WebKit1\xa0Debug\xa0Tests\xa0EWS"},
>         "mac-32bit-ews": {platform: Dashboard.Platform.macOSHighSierra, shortName: "mac-32bit", title: "Release\xa032\u2011bit\xa0Build\xa0EWS"},
>         "bindings-ews": {platform: Dashboard.Platform.macOSHighSierra, shortName: "bindings", title: "Bindings\xa0EWS"},
>         "webkitpy-ews": {platform: Dashboard.Platform.macOSHighSierra, shortName: "webkitpy", title: "Webkitpy\xa0EWS"},
>-        "win-ews": {platform: Dashboard.Platform.Windows7, shortName: "win", title: "WebKit1\xa0Release\xa0Build\xa0EWS"}
>+        "win-ews": {platform: Dashboard.Platform.Windows7, shortName: "win", title: "WebKit1\xa0Release\xa0Build\xa0EWS"},
>+        "wpe-ews": {platform: Dashboard.Platform.LinuxWPE, shortName: "wpe", title: "WebKit2\xa0Release\xa0Build\xa0EWS"}
>     };
> 
>     BaseObject.call(this);
>diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js
>index 35d657f6a9cbd1692bc827602cdcdb7e09138fc8..92a4d75d839560bb6d74d994afb1bde28e533dc0 100644
>--- a/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js
>+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js
>@@ -34,7 +34,8 @@ Dashboard = {
>         Windows7: { name: "windows-7", readableName: "Windows 7", order: 60 },
>         WindowsXP: { name: "windows-xp", readableName: "Windows XP", order: 70 },
>         LinuxWPE: { name : "linux-wpe", readableName: "Linux WPE", order: 90 },
>-        LinuxGTK: { name : "linux-gtk", readableName: "Linux GTK", order: 91 }
>+        LinuxGTK: { name : "linux-gtk", readableName: "Linux GTK", order: 91 },
>+        LinuxJSCOnly: { name : "linux-jsc-only", readableName: "Linux JSCOnly", order: 92 }
>     },
>     Branch: {},
>     Repository: {
>diff --git a/Tools/QueueStatusServer/config/queues.py b/Tools/QueueStatusServer/config/queues.py
>index 34f3d9789be030d5a21e0516b728431917d9ae43..e49287ab73fa8f7f9ebb130f58ea5884d4b4ffa4 100644
>--- a/Tools/QueueStatusServer/config/queues.py
>+++ b/Tools/QueueStatusServer/config/queues.py
>@@ -38,6 +38,7 @@ all_queue_names = [
>     "ios-sim-ews",
>     "bindings-ews",
>     "jsc-ews",
>+    "jsc-mips-ews",
>     "mac-ews",
>     "mac-wk2-ews",
>     "mac-debug-ews",
>diff --git a/Tools/QueueStatusServer/model/queues.py b/Tools/QueueStatusServer/model/queues.py
>index 028c4473f125ac5288947e4adebe7d0faaeb34ac..d4db07f996f247a3e63f0d2c463b6ccb87c02456 100644
>--- a/Tools/QueueStatusServer/model/queues.py
>+++ b/Tools/QueueStatusServer/model/queues.py
>@@ -78,6 +78,7 @@ class Queue(object):
>         display_name = display_name.replace("Wk2", "WK2")
>         display_name = display_name.replace("Ews", "EWS")
>         display_name = display_name.replace("Ios", "iOS")
>+        display_name = display_name.replace("JscOnly", "JSCOnly")
>         display_name = display_name.replace("Jsc", "JSC")
>         display_name = display_name.replace("Wpe", "WPE")
>         display_name = display_name.replace("Gtk", "GTK")
>diff --git a/Tools/Scripts/webkitpy/common/config/ews.json b/Tools/Scripts/webkitpy/common/config/ews.json
>index 4fbc9db8fdc2464a2eea7d6a834a0d1bd0a69aeb..371b1a403ee2795549f7ded29135374e4864df24 100644
>--- a/Tools/Scripts/webkitpy/common/config/ews.json
>+++ b/Tools/Scripts/webkitpy/common/config/ews.json
>@@ -53,6 +53,15 @@
>         "group": "jsc",
>         "runTests": true
>     },
>+    "JSC MIPS32el EWS": {
>+        "port": "jsc-only",
>+        "name": "jsc-mips-ews",
>+        "group": "jsc",
>+        "runTests": false,
>+        "watchers": [
>+            "guijemont@igalia.com"
>+        ]
>+    },
>     "Bindings EWS": {
>         "port": "mac",
>         "name": "bindings-ews",
>diff --git a/Tools/Scripts/webkitpy/common/config/ports.py b/Tools/Scripts/webkitpy/common/config/ports.py
>index 94d71bfe31099b8a2496cd264effd0f81b33a6fc..564472a8a2182280f2093713e0eb242bdfcacf22 100644
>--- a/Tools/Scripts/webkitpy/common/config/ports.py
>+++ b/Tools/Scripts/webkitpy/common/config/ports.py
>@@ -68,6 +68,7 @@ class DeprecatedPort(object):
>             # FIXME: https://bugs.webkit.org/show_bug.cgi?id=169302
>             "ios": IOSPort,
>             "ios-simulator-wk2": IOSSimulatorWK2Port,
>+            "jsc-only": JscOnlyPort,
>             "mac": MacPort,
>             "mac-wk2": MacWK2Port,
>             "win": WinPort,
>@@ -230,3 +231,11 @@ class WpePort(DeprecatedPort):
>         command = super(WpePort, self).run_webkit_tests_command(build_style)
>         command.append("--wpe")
>         return command
>+
>+
>+class JscOnlyPort(DeprecatedPort):
>+    port_flag_name = "jsc-only"
>+
>+    def build_jsc_command(self, build_style=None):
>+        command = self.script_shell_command("build-jsc")
>+        return self._append_build_style_flag(command, build_style)
>diff --git a/Tools/Scripts/webkitpy/common/config/ports_unittest.py b/Tools/Scripts/webkitpy/common/config/ports_unittest.py
>index 2c528b950935a3f77f977d240eef709e25287a40..c9480c0f242281415c7fabdd00c7db2fb7d79b44 100644
>--- a/Tools/Scripts/webkitpy/common/config/ports_unittest.py
>+++ b/Tools/Scripts/webkitpy/common/config/ports_unittest.py
>@@ -61,3 +61,9 @@ class DeprecatedPortTest(unittest.TestCase):
>         self.assertEqual(WinCairoPort().run_webkit_tests_command(), DeprecatedPort().script_shell_command("run-webkit-tests") + ["--wincairo"])
>         self.assertEqual(WinCairoPort().build_webkit_command(), DeprecatedPort().script_shell_command("build-webkit") + ["--wincairo"])
>         self.assertEqual(WinCairoPort().build_webkit_command(build_style="debug"), DeprecatedPort().script_shell_command("build-webkit") + ["--debug", "--wincairo"])
>+
>+    def test_jsconly_port(self):
>+        self.assertEqual(JscOnlyPort().flag(), "--port=jsc-only")
>+        self.assertEqual(JscOnlyPort().build_jsc_command(), DeprecatedPort().script_shell_command("build-jsc"))
>+        self.assertEqual(JscOnlyPort().build_jsc_command(build_style="release"), DeprecatedPort().script_shell_command("build-jsc") + ["--release"])
>+        self.assertEqual(JscOnlyPort().build_jsc_command(build_style="debug"), DeprecatedPort().script_shell_command("build-jsc") + ["--debug"])
>diff --git a/Tools/Scripts/webkitpy/port/factory.py b/Tools/Scripts/webkitpy/port/factory.py
>index 49190d130ceac2f2ae6bb57a93cf644e1dd3b9a8..1195e80d60b41cb51afbc3b18892da4f02d60dfa 100644
>--- a/Tools/Scripts/webkitpy/port/factory.py
>+++ b/Tools/Scripts/webkitpy/port/factory.py
>@@ -91,6 +91,7 @@ class PortFactory(object):
>         'gtk.GtkPort',
>         'ios_simulator.IOSSimulatorPort',
>         'ios_device.IOSDevicePort',
>+        'jsc_only.JscOnlyPort',
>         'mac.MacPort',
>         'mock_drt.MockDRTPort',
>         'test.TestPort',
>diff --git a/Tools/Scripts/webkitpy/port/jsc_only.py b/Tools/Scripts/webkitpy/port/jsc_only.py
>new file mode 100644
>index 0000000000000000000000000000000000000000..2d71d07e73529d8a76370098558cde732f2be249
>--- /dev/null
>+++ b/Tools/Scripts/webkitpy/port/jsc_only.py
>@@ -0,0 +1,30 @@
>+# Copyright (C) 2018 Igalia S.L.
>+#
>+# Redistribution and use in source and binary forms, with or without
>+# modification, are permitted provided that the following conditions are met:
>+#
>+# 1. Redistributions of source code must retain the above copyright notice, this
>+#    list of conditions and the following disclaimer.
>+# 2. Redistributions in binary form must reproduce the above copyright notice,
>+#    this list of conditions and the following disclaimer in the documentation
>+#    and/or other materials provided with the distribution.
>+#
>+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
>+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
>+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
>+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
>+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>+# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
>+# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+
>+from webkitpy.port.base import Port
>+
>+
>+class JscOnlyPort(Port):
>+    port_name = "jsc-only"
>+
>+    def __init__(self, *args, **kwargs):
>+        super(JscOnlyPort, self).__init__(*args, **kwargs)
>diff --git a/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py b/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py
>index 6ecaed0bb26ec394e4fbb24a3ac3f3ebcb6c81b2..24460aabdf7168a06f490de07049134c24b1cbed 100644
>--- a/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py
>+++ b/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py
>@@ -197,6 +197,7 @@ MOCK: update_status: %(name)s Checked relevance of patch
>             'ios-ews',
>             'ios-sim-ews',
>             'jsc-ews',
>+            'jsc-mips-ews',
>             'mac-32bit-ews',
>             'mac-debug-ews',
>             'mac-ews',

Flags:

mcatanzaro: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 186523: 342439 | 342450