Attachment 342418 Details for Bug 166885 – Patch

[patch] Patch

bug-166885-20180611142642.patch (text/plain), 23.36 KB, created by Carlos Alberto Lopez Perez on 2018-06-11 05:26:44 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Alberto Lopez Perez

Created: 2018-06-11 05:26:44 PDT

Size: 23.36 KB

patch

obsolete

>Subversion Revision: 232699
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index e1f9614525c151f41f6f52e5b6e30dfa02b97966..51ff26a7d71e703e8ecb88f2ccc13a9debff8324 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,40 @@
>+2018-06-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
>+
>+        [GTK] Add a script to upload the data generated with run-benchmark to a browserperfdash server and use it on the gtk perf bot
>+        https://bugs.webkit.org/show_bug.cgi?id=166885
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch adds a new script that will execute run-benchmark and upload the results it generates to a browserperfdash web app.
>+
>+        It also modifies the buildbot config file so the GTK performance bot runs this script on the perf-test step.
>+
>+        * BuildSlaveSupport/build.webkit.org-config/steps.py:
>+        (RunBenchmarkTests):
>+        * Scripts/browserperfdash-benchmark: Added.
>+        * Scripts/webkitpy/browserperfdash/README: Added.
>+        * Scripts/webkitpy/browserperfdash/__init__.py: Added.
>+        * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py: Added.
>+        (parse_args):
>+        (BrowserPerfDashRunner):
>+        (BrowserPerfDashRunner.__init__):
>+        (BrowserPerfDashRunner._parse_config_file):
>+        (BrowserPerfDashRunner._get_test_version_string):
>+        (BrowserPerfDashRunner._get_test_data_json_string):
>+        (BrowserPerfDashRunner._upload_result):
>+        (BrowserPerfDashRunner.run):
>+        (format_logger):
>+        (main):
>+        * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py: Added.
>+        (FakeBenchmarkRunner):
>+        (FakeBenchmarkRunner.__init__):
>+        (FakeBenchmarkRunner.execute):
>+        (BrowserPerfDashRunnerTest):
>+        (BrowserPerfDashRunnerTest.test_list_plans_at_least_five):
>+        (BrowserPerfDashRunnerTest.test_benchmark_runner_subclasses_at_least_two):
>+        (BrowserPerfDashRunnerTest.test_can_construct_runner_object_minimum_parameters):
>+        * Scripts/webkitpy/browserperfdash/config-file-example.txt: Added.
>+
> 2018-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed. Fix WPE API and layout tests after r232670.
>diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py b/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>index 0631e86e3c55d84c0505af6985756e90a53d5ff1..19d5df71b65fb421f572ea7698ccf8a783353700 100644
>--- a/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>+++ b/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
>@@ -829,7 +829,9 @@ class RunBenchmarkTests(shell.Test):
>     # The current maximum timeout for a benchmark plan is also 1200.
>     # So raise the buildbot timeout to avoid aborting this whole step when a test timeouts.
>     timeout = 1500
>-    command = ["python", "./Tools/Scripts/run-benchmark", "--allplans"]
>+    command = ["python", "./Tools/Scripts/browserperfdash-benchmark", "--allplans",
>+               "--config-file", "../../browserperfdash-benchmark-config.txt",
>+               "--browser-version", WithProperties("r%(got_revision)s")]
> 
>     def start(self):
>         platform = self.getProperty("platform")
>diff --git a/Tools/Scripts/browserperfdash-benchmark b/Tools/Scripts/browserperfdash-benchmark
>new file mode 100755
>index 0000000000000000000000000000000000000000..ab3149178695f7c22f5126e71ba3019c3e87a967
>--- /dev/null
>+++ b/Tools/Scripts/browserperfdash-benchmark
>@@ -0,0 +1,36 @@
>+#!/usr/bin/env python
>+#
>+# Copyright (C) 2018 Igalia S.L.
>+#
>+# Redistribution and use in source and binary forms, with or without
>+# modification, are permitted provided that the following conditions are met:
>+#
>+# 1. Redistributions of source code must retain the above copyright notice, this
>+#    list of conditions and the following disclaimer.
>+# 2. Redistributions in binary form must reproduce the above copyright notice,
>+#    this list of conditions and the following disclaimer in the documentation
>+#    and/or other materials provided with the distribution.
>+#
>+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
>+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
>+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
>+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
>+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>+# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
>+# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+
>+
>+import logging
>+import sys
>+
>+from webkitpy.browserperfdash.browserperfdash_runner import main, format_logger
>+
>+
>+_log = logging.getLogger()
>+
>+if __name__ == '__main__':
>+    format_logger(_log)
>+    sys.exit(main())
>diff --git a/Tools/Scripts/webkitpy/browserperfdash/README b/Tools/Scripts/webkitpy/browserperfdash/README
>new file mode 100644
>index 0000000000000000000000000000000000000000..8e89a78edddd3584cba33f8f16edb67ce8f7263b
>--- /dev/null
>+++ b/Tools/Scripts/webkitpy/browserperfdash/README
>@@ -0,0 +1,5 @@
>+The scripts inside this folder allow to send the data from run-benchmark
>+to a server running the browserperfdash web app below:
>+
>+Source code: https://github.com/Igalia/browserperfdash
>+Deployment:  https://browserperfdash.igalia.com/
>diff --git a/Tools/Scripts/webkitpy/browserperfdash/__init__.py b/Tools/Scripts/webkitpy/browserperfdash/__init__.py
>new file mode 100644
>index 0000000000000000000000000000000000000000..b376bf2bea2b6af5ce79d3e3d33c73adec434f18
>--- /dev/null
>+++ b/Tools/Scripts/webkitpy/browserperfdash/__init__.py
>@@ -0,0 +1,13 @@
>+# Required for Python to search this directory for module files
>+
>+# Keep this file free of any code or import statements that could
>+# cause either an error to occur or a log message to be logged.
>+# This ensures that calling code can import initialization code from
>+# webkitpy before any errors or log messages due to code in this file.
>+# Initialization code can include things like version-checking code and
>+# logging configuration code.
>+#
>+# We do not execute any version-checking code or logging configuration
>+# code in this file so that callers can opt-in as they want.  This also
>+# allows different callers to choose different initialization code,
>+# as necessary.
>diff --git a/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py b/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py
>new file mode 100644
>index 0000000000000000000000000000000000000000..c7c7762e2f50d59761dd807832b8ba6ed90298be
>--- /dev/null
>+++ b/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py
>@@ -0,0 +1,210 @@
>+#!/usr/bin/env python
>+#
>+# Copyright (C) 2018 Igalia S.L.
>+#
>+# Redistribution and use in source and binary forms, with or without
>+# modification, are permitted provided that the following conditions are met:
>+#
>+# 1. Redistributions of source code must retain the above copyright notice, this
>+#    list of conditions and the following disclaimer.
>+# 2. Redistributions in binary form must reproduce the above copyright notice,
>+#    this list of conditions and the following disclaimer in the documentation
>+#    and/or other materials provided with the distribution.
>+#
>+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
>+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
>+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
>+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
>+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>+# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
>+# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+
>+
>+import argparse
>+import ConfigParser
>+import json
>+import logging
>+import os
>+import platform
>+import sys
>+import tempfile
>+import time
>+import urllib
>+
>+from webkitpy.benchmark_runner.benchmark_runner import BenchmarkRunner
>+from webkitpy.benchmark_runner.browser_driver.browser_driver_factory import BrowserDriverFactory
>+from webkitpy.benchmark_runner.webdriver_benchmark_runner import WebDriverBenchmarkRunner
>+from webkitpy.benchmark_runner.webserver_benchmark_runner import WebServerBenchmarkRunner
>+from webkitpy.benchmark_runner.run_benchmark import default_browser, default_platform, benchmark_runner_subclasses
>+
>+_log = logging.getLogger(__name__)
>+
>+
>+def parse_args():
>+    parser = argparse.ArgumentParser(description='Automate the browser based performance benchmarks')
>+    # browserperfdash specific arguments.
>+    parser.add_argument('--config-file', dest='config_file', default=None, required=True, help='Configuration file for sending the results to the performance dashboard server(s).')
>+    parser.add_argument('--browser-version', dest='browser_version', default=None, required=True, help='A string that identifies the browser version.')
>+    # arguments shared with run-benchmark.
>+    parser.add_argument('--build-directory', dest='buildDir', help='Path to the browser executable. e.g. WebKitBuild/Release/')
>+    parser.add_argument('--platform', dest='platform', default=default_platform(), choices=BrowserDriverFactory.available_platforms())
>+    parser.add_argument('--browser', dest='browser', default=default_browser(), choices=BrowserDriverFactory.available_browsers())
>+    parser.add_argument('--driver', default=WebServerBenchmarkRunner.name, choices=benchmark_runner_subclasses.keys(), help='Use the specified benchmark driver. Defaults to %s.' % WebServerBenchmarkRunner.name)
>+    parser.add_argument('--local-copy', dest='localCopy', help='Path to a local copy of the benchmark. e.g. PerformanceTests/SunSpider/')
>+    parser.add_argument('--count', dest='countOverride', type=int, help='Number of times to run the benchmark. e.g. 5')
>+    mutual_group = parser.add_mutually_exclusive_group(required=True)
>+    mutual_group.add_argument('--plan', dest='plan', help='Benchmark plan to run. e.g. speedometer, jetstream')
>+    mutual_group.add_argument('--allplans', action='store_true', help='Run all available benchmark plans sequentially')
>+    args = parser.parse_args()
>+    return args
>+
>+
>+class BrowserPerfDashRunner(object):
>+    name = 'browserperfdash_runner'
>+
>+    def __init__(self, args):
>+        self._args = args
>+        self._plandir = os.path.abspath(BenchmarkRunner.plan_directory())
>+        if not os.path.isdir(self._plandir):
>+            raise Exception('Cant find plandir: {plandir}'.format(plandir=self._plandir))
>+        self._parse_config_file(self._args.config_file)
>+        # This is the dictionary that will be sent in the post petition that browserperfdash expects
>+        # (as defined in https://github.com/Igalia/browserperfdash/wiki/Design-Document)
>+        # - The bot_* data its obtained from the config file
>+        # - the browser_* data is given at startup time via command-line arguments
>+        # - The test_* data is generated after each test run.
>+        self._result_data = {'bot_id': None,
>+                             'bot_password': None,
>+                             'browser_id': self._args.browser,
>+                             'browser_version': self._args.browser_version,
>+                             'test_id': None,
>+                             'test_version': None,
>+                             'test_data': None}
>+
>+    def _parse_config_file(self, config_file):
>+        if not os.path.isfile(config_file):
>+            raise Exception('Can not open config file for uploading results at: {config_file}'.format(config_file=config_file))
>+        self._config_parser = ConfigParser.RawConfigParser()
>+        self._config_parser.read(config_file)
>+
>+    def _get_test_version_string(self, plan_name):
>+        plan_file_path = os.path.join(self._plandir, '{plan_name}.plan'.format(plan_name=plan_name))
>+        with open(plan_file_path, 'r') as plan_fd:
>+            plan_json = json.load(plan_fd)
>+            if 'svn_source' in plan_json:
>+                return plan_json['svn_source']
>+            elif 'remote_archive' in plan_json:
>+                return plan_json['remote_archive']
>+            else:
>+                raise Exception('Can not upload results because is not possible to determine test version for test plan: {plan_file_path}'.format(plan_file_path=plan_file_path))
>+
>+    def _get_test_data_json_string(self, temp_result_file):
>+        temp_result_file.flush()
>+        temp_result_file.seek(0)
>+        temp_result_json = json.load(temp_result_file)
>+        if 'debugOutput' in temp_result_json:
>+            del temp_result_json['debugOutput']
>+        return json.dumps(temp_result_json)
>+
>+    def _upload_result(self):
>+        upload_failed = False
>+        for server in self._config_parser.sections():
>+            self._result_data['bot_id'] = self._config_parser.get(server, 'bot_id')
>+            self._result_data['bot_password'] = self._config_parser.get(server, 'bot_password')
>+            post_data = urllib.urlencode(self._result_data)
>+            post_url = self._config_parser.get(server, 'post_url')
>+            try:
>+                post_request = urllib.urlopen(post_url, post_data)
>+                if post_request.getcode() == 200:
>+                    _log.info('Sucesfully uploaded results to server {server_name} for test {test_name} and browser {browser_name} version {browser_version}'.format(
>+                               server_name=server, test_name=self._result_data['test_id'], browser_name=self._result_data['browser_id'], browser_version=self._result_data['browser_version']))
>+                else:
>+                    upload_failed = True
>+                    _log.error('The server {server_name} returned an error code: {http_error}'.format(server_name=server, http_error=post_request.getcode()))
>+                    _log.error('The error text from the server {server_name} was: "{error_text}"'.format(server_name=server, error_text=post_request.read()))
>+            except Exception as e:
>+                upload_failed = True
>+                _log.error('Exception while trying to upload results to server {server_name}'.format(server_name=server))
>+                _log.error(e)
>+        return not upload_failed
>+
>+    def run(self):
>+        failed = []
>+        worked = []
>+        skipped = []
>+        planlist = []
>+        if self._args.plan:
>+            if not os.path.isfile(os.path.join(self._plandir, '{plan_name}.plan'.format(plan_name=self._args.plan))):
>+                raise Exception('Cant find a file named {plan_name}.plan in directory {plan_directory}'.format(plan_name=self._args.plan, plan_directory=self._plandir))
>+            planlist = [self._args.plan]
>+        elif self._args.allplans:
>+            planlist = BenchmarkRunner.available_plans()
>+            skippedfile = os.path.join(self._plandir, 'Skipped')
>+            if not planlist:
>+                raise Exception('Cant find any plan in the directory {plan_directory}'.format(plan_directory=self._plandir))
>+            if os.path.isfile(skippedfile):
>+                skipped = [line.strip() for line in open(skippedfile) if not line.startswith('#') and len(line) > 1]
>+
>+        if len(planlist) < 1:
>+            _log.error('No benchmarks plans available to run in directory {plan_directory}'.format(plan_directory=self._plandir))
>+            return 1
>+
>+        _log.info('Starting benchmark for browser {browser} and version {browser_version}'.format(browser=self._args.browser, browser_version=self._args.browser_version))
>+
>+        iteration_count = 0
>+        for plan in sorted(planlist):
>+            iteration_count = +1
>+            if plan in skipped:
>+                _log.info('Skipping benchmark plan: {plan_name} because is listed on the Skipped file [benchmark {iteration} of {total}]'.format(plan_name=plan, iteration=iteration_count, total=len(planlist)))
>+                continue
>+            _log.info('Starting benchmark plan: {plan_name} [benchmark {iteration} of {total}]'.format(plan_name=plan, iteration=iteration_count, total=len(planlist)))
>+            try:
>+                # Run test and save test info
>+                with tempfile.NamedTemporaryFile() as temp_result_file:
>+                    benchmark_runner_class = benchmark_runner_subclasses[self._args.driver]
>+                    runner = benchmark_runner_class(plan, self._args.localCopy, self._args.countOverride, self._args.buildDir, temp_result_file.name, self._args.platform, self._args.browser)
>+                    runner.execute()
>+                    _log.info('Finished benchmark plan: {plan_name}'.format(plan_name=plan))
>+                    # Fill test info for upload
>+                    self._result_data['test_id'] = plan
>+                    self._result_data['test_version'] = self._get_test_version_string(plan)
>+                    # Fill obtained test results for upload
>+                    self._result_data['test_data'] = self._get_test_data_json_string(temp_result_file)
>+
>+                # Now upload data to server(s)
>+                _log.info('Uploading results for plan: {plan_name} and browser {browser} version {browser_version}'.format(plan_name=plan, browser=self._args.browser, browser_version=self._args.browser_version))
>+                if self._upload_result():
>+                    worked.append(plan)
>+                else:
>+                    failed.append(plan)
>+
>+            except KeyboardInterrupt:
>+                raise
>+            except:
>+                failed.append(plan)
>+                _log.exception('Error running benchmark plan: {plan_name}'.format(plan_name=plan))
>+
>+        if len(worked) > 0:
>+            _log.info('The following benchmark plans have been upload succesfully: {list_plan_worked}'.format(list_plan_worked=worked))
>+
>+        if len(failed) > 0:
>+            _log.error('The following benchmark plans have failed to run or to upload : {list_plan_failed}'.format(list_plan_failed=failed))
>+            return len(failed)
>+
>+        return 0
>+
>+
>+def format_logger(logger):
>+    logger.setLevel(logging.INFO)
>+    ch = logging.StreamHandler()
>+    formatter = logging.Formatter('%(asctime)s - %(levelname)s - %(message)s')
>+    ch.setFormatter(formatter)
>+    logger.addHandler(ch)
>+
>+
>+def main():
>+    perfdashrunner = BrowserPerfDashRunner(parse_args())
>+    return perfdashrunner.run()
>diff --git a/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py b/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py
>new file mode 100644
>index 0000000000000000000000000000000000000000..34615186414ddd71c0a9c02ad7fb95a46353f81e
>--- /dev/null
>+++ b/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py
>@@ -0,0 +1,64 @@
>+#!/usr/bin/env python
>+#
>+# Copyright (C) 2018 Igalia S.L.
>+#
>+# Redistribution and use in source and binary forms, with or without
>+# modification, are permitted provided that the following conditions are met:
>+#
>+# 1. Redistributions of source code must retain the above copyright notice, this
>+#    list of conditions and the following disclaimer.
>+# 2. Redistributions in binary form must reproduce the above copyright notice,
>+#    this list of conditions and the following disclaimer in the documentation
>+#    and/or other materials provided with the distribution.
>+#
>+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
>+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
>+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
>+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
>+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
>+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
>+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
>+# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
>+# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+
>+
>+import logging
>+import unittest
>+import os
>+
>+from webkitpy.benchmark_runner.run_benchmark import default_browser, default_platform, benchmark_runner_subclasses
>+from webkitpy.benchmark_runner.benchmark_runner import BenchmarkRunner
>+from webkitpy.benchmark_runner.webserver_benchmark_runner import WebServerBenchmarkRunner
>+from webkitpy.benchmark_runner.webdriver_benchmark_runner import WebDriverBenchmarkRunner
>+from webkitpy.benchmark_runner.browser_driver.browser_driver_factory import BrowserDriverFactory
>+
>+
>+_log = logging.getLogger(__name__)
>+
>+
>+class FakeBenchmarkRunner(BenchmarkRunner):
>+    name = 'fake'
>+
>+    def __init__(self, plan_file, local_copy, count_override, build_dir, output_file, platform, browser):
>+        super(FakeBenchmarkRunner, self).__init__(plan_file, local_copy, count_override, build_dir, output_file, platform, browser)
>+
>+    def execute(self):
>+        return True
>+
>+
>+# This tests for some features of benchmark_runner that browserperfdash_runner depends on
>+class BrowserPerfDashRunnerTest(unittest.TestCase):
>+    def test_list_plans_at_least_five(self):
>+        plan_list = BenchmarkRunner.available_plans()
>+        self.assertTrue(len(plan_list) > 4)
>+
>+    def test_benchmark_runner_subclasses_at_least_two(self):
>+        self.assertTrue(len(benchmark_runner_subclasses) > 1)
>+
>+    def test_can_construct_runner_object_minimum_parameters(self):
>+        # This tests that constructing the benchmark_runner object specifying the minimum required paramaters is ok.
>+        plan_list = BenchmarkRunner.available_plans()
>+        build_dir = os.path.abspath(os.curdir)
>+        runner = FakeBenchmarkRunner(plan_list[0], False, 1, build_dir, "/tmp/testOutput.txt", default_platform(), default_browser())
>+        self.assertTrue(runner.execute())
>diff --git a/Tools/Scripts/webkitpy/browserperfdash/config-file-example.txt b/Tools/Scripts/webkitpy/browserperfdash/config-file-example.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..65f7cc2ae209ec5237580cb625d00bced8841445
>--- /dev/null
>+++ b/Tools/Scripts/webkitpy/browserperfdash/config-file-example.txt
>@@ -0,0 +1,31 @@
>+# This configuration file uses the syntax from Python's ConfigParser.
>+# The syntax is similar to Windows "INI" files.
>+#
>+# [section1]
>+# key1 = value1
>+# key2 = value2
>+#
>+# Each section entry defines a server where to upload the results.
>+# The server should be running this Django app: https://github.com/Igalia/browserperfdash
>+#
>+# If more than a section entry is defined, the program will try to upload
>+# the data to each one of them.
>+#
>+# The following entries are mandatory for each section
>+#
>+# 'bot_id'       : The identifier of this bot on the server.
>+# 'bot_password' : The password of this bot on the server.
>+# 'post_url'     : The POST URL (typically ${BASE_URI}/dash/bot-report)
>+#
>+
>+## Configuration for dashboard browserperfdash.igalia.org
>+#[browserperfdash.igalia.org]
>+#bot_id = gtk-linux-64-perf-tests
>+#bot_password = r4nd0MP4ss
>+#post_url = https://browserperfdash.igalia.com/dash/bot-report
>+
>+## Configuration for dashboard localhost-test
>+#[localhost-test]
>+#bot_id = testlocalbot
>+#bot_password = 123
>+#post_url = http://localhost:8000/dash/bot-report

Flags:

mcatanzaro: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 166885: 298457 | 342418