Attachment 342416 Details for Bug 186482 – patch

[patch] patch

media-cache-ranges-test-fix.patch (text/plain), 3.08 KB, created by Antti Koivisto on 2018-06-11 03:49:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antti Koivisto

Created: 2018-06-11 03:49:03 PDT

Size: 3.08 KB

patch

obsolete

>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 232705)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,3 +1,18 @@
>+2018-06-11 Antti Koivisto <antti@apple.com>
>+
>+ REGRESSION (Mojave): LayoutTest http/tests/cache/disk-cache/disk-cache-media-small.html is failing
>+ https://bugs.webkit.org/show_bug.cgi?id=186482
>+ <rdar://problem/40924056>
>+
>+ Reviewed by NOBODY (OOPS!).
>+
>+ The test was sensitive to which exact ranges the system media framework would request.
>+
>+ * http/tests/cache/disk-cache/disk-cache-media-small-expected.txt:
>+ * http/tests/cache/disk-cache/disk-cache-media-small.html:
>+
>+ Don't print out the ranges, just check they are all coming from the right source.
>+
> 2018-06-11 Antoine Quint <graouts@apple.com>
> 
> [Web Animations] Make imported/mozilla/css-transitions/test_setting-effect.html pass reliably
>Index: LayoutTests/http/tests/cache/disk-cache/disk-cache-media-small-expected.txt
>===================================================================
>--- LayoutTests/http/tests/cache/disk-cache/disk-cache-media-small-expected.txt	(revision 232538)
>+++ LayoutTests/http/tests/cache/disk-cache/disk-cache-media-small-expected.txt	(working copy)
>@@ -1,7 +1,5 @@
> First load
>-Content range: bytes 0-1/192844, Response source: Network
>-Content range: bytes 0-192843/192844, Response source: Network
>+PASS: All response ranges from: Network
> Second Load
>-Content range: bytes 0-1/192844, Response source: Disk cache
>-Content range: bytes 0-192843/192844, Response source: Disk cache
>+PASS: All response ranges from: Disk cache
> 
>Index: LayoutTests/http/tests/cache/disk-cache/disk-cache-media-small.html
>===================================================================
>--- LayoutTests/http/tests/cache/disk-cache/disk-cache-media-small.html	(revision 232538)
>+++ LayoutTests/http/tests/cache/disk-cache/disk-cache-media-small.html	(working copy)
>@@ -23,20 +23,27 @@ function loadTestMedia() {
> });
> }
> 
>-function logResponses(media)
>+function logResponses(media, expextedSource)
> {
>+ let pass = true;
> const ranges = internals.mediaResponseContentRanges(media);
> const sources = internals.mediaResponseSources(media);
>- for (i = 0; i < Math.min(2, ranges.length); ++i)
>- logdiv.innerHTML += `Content range: ${ranges[i]}, Response source: ${sources[i]} `;
>+ for (i = 0; i < ranges.length; ++i) {
>+ if (sources[i] != expextedSource) {
>+ logdiv.innerHTML += `FAIL: Range ${ranges[i]} from ${sources[i]} expected ${expextedSource} `;
>+ pass = false;
>+ }
>+ }
>+ if (pass)
>+ logdiv.innerHTML += `PASS: All response ranges from: ${expextedSource} `;
> }
> 
> async function test() {
> logdiv.innerHTML += "First load ";
>- logResponses(await loadTestMedia());
>+ logResponses(await loadTestMedia(), "Network");
> 
> logdiv.innerHTML += "Second Load ";
>- logResponses(await loadTestMedia());
>+ logResponses(await loadTestMedia(), "Disk cache");
> 
> testRunner.notifyDone();
> }

Actions: View | Formatted Diff | Diff

Attachments on bug 186482: 342416 | 342417 | 342420 | 342425