Attachment 342347 Details for Bug 186450 – patch

[patch] patch

patch.txt (text/plain), 2.05 KB, created by Nan Wang on 2018-06-08 17:12:11 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Nan Wang

Created: 2018-06-08 17:12:11 PDT

Size: 2.05 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 232654)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2018-06-08  Nan Wang  <n_wang@apple.com>
>+
>+        AX: [iOS] accessibility sometimes doesn't know process suspension is canceled
>+        https://bugs.webkit.org/show_bug.cgi?id=186450
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        There's some early return condition in WebProcess::cancelPrepareToSuspend() which
>+        could lead to accessibility failing to post process status notificaiton. Fixed it
>+        by moving the accessibility notification before the early return condition.
>+
>+        * WebProcess/WebProcess.cpp:
>+        (WebKit::WebProcess::cancelPrepareToSuspend):
>+
> 2018-06-08  Per Arne Vollan  <pvollan@apple.com>
> 
>         Only display refresh monitors having requested display refresh callback should get notified on screen updates.
>Index: Source/WebKit/WebProcess/WebProcess.cpp
>===================================================================
>--- Source/WebKit/WebProcess/WebProcess.cpp	(revision 232641)
>+++ Source/WebKit/WebProcess/WebProcess.cpp	(working copy)
>@@ -1412,16 +1412,16 @@ void WebProcess::cancelPrepareToSuspend(
>     RELEASE_LOG(ProcessSuspension, "%p - WebProcess::cancelPrepareToSuspend()", this);
>     setAllLayerTreeStatesFrozen(false);
> 
>+#if PLATFORM(IOS)
>+    accessibilityProcessSuspendedNotification(false);
>+#endif
>+    
>     // If we've already finished cleaning up and sent ProcessReadyToSuspend, we
>     // shouldn't send DidCancelProcessSuspension; the UI process strictly expects one or the other.
>     if (!m_pageMarkingLayersAsVolatileCounter)
>         return;
> 
>     cancelMarkAllLayersVolatile();
>-    
>-#if PLATFORM(IOS)
>-    accessibilityProcessSuspendedNotification(false);
>-#endif
> 
>     RELEASE_LOG(ProcessSuspension, "%p - WebProcess::cancelPrepareToSuspend() Sending DidCancelProcessSuspension IPC message", this);
>     parentProcessConnection()->send(Messages::WebProcessProxy::DidCancelProcessSuspension(), 0);

Actions: View | Formatted Diff | Diff

Attachments on bug 186450: 342347