Attachment 342323 Details for Bug 186445 – PATCH

[patch] PATCH

186445.diff (text/plain), 1.18 KB, created by Basuke Suzuki on 2018-06-08 14:04:09 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2018-06-08 14:04:09 PDT

Size: 1.18 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index d2fbb2d902a..9dc2f6fc334 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-08  Basuke Suzuki  <Basuke.Suzuki@sony.com>
>+
>+        [Win] Add IPC error case for broken pipe
>+        https://bugs.webkit.org/show_bug.cgi?id=186445
>+
>+        Add error handling for ERROR_BROKEN_PIPE on IPC::Connection::readEventHandler.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Platform/IPC/win/ConnectionWin.cpp:
>+        (IPC::Connection::readEventHandler):
>+
> 2018-06-07  Chris Dumez  <cdumez@apple.com>
> 
>         Add base class to get WeakPtrFactory member and avoid some boilerplate code
>diff --git a/Source/WebKit/Platform/IPC/win/ConnectionWin.cpp b/Source/WebKit/Platform/IPC/win/ConnectionWin.cpp
>index bc94c67d118..01faa919ded 100644
>--- a/Source/WebKit/Platform/IPC/win/ConnectionWin.cpp
>+++ b/Source/WebKit/Platform/IPC/win/ConnectionWin.cpp
>@@ -204,6 +204,9 @@ void Connection::readEventHandler()
>             continue;
>         }
> 
>+        if (error == ERROR_BROKEN_PIPE)
>+            return;
>+
>         // FIXME: We need to handle other errors here.
>         ASSERT_NOT_REACHED();
>     }

Flags:

rniwa: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 186445: 342323 | 342351 | 342774