Attachment 342311 Details for Bug 186440 – Patch

[patch] Patch

bug-186440-20180608130756.patch (text/plain), 2.47 KB, created by Chris Dumez on 2018-06-08 13:07:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-06-08 13:07:56 PDT

Size: 2.47 KB

patch

obsolete

>Subversion Revision: 232619
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index b4d409afd9ba15e441b629ca07423cd74245262f..2c6b6ee2e6850257e0d80f5fa5281f7d85054fa8 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-08  Chris Dumez  <cdumez@apple.com>
>+
>+        http/tests/navigation/https-no-store-subframe-in-page-cache.html fails with PSON enabled
>+        https://bugs.webkit.org/show_bug.cgi?id=186440
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Override the PageCache setting *after* the cross-origin navigation. It was previously
>+        overriden before the navigation and thus would not persist with process swap on navigation
>+        enabled.
>+
>+        * http/tests/navigation/https-no-store-subframe-in-page-cache.html:
>+        * http/tests/navigation/resources/https-no-store-subframe-in-page-cache.html:
>+
> 2018-06-07  Mark Lam  <mark.lam@apple.com>
> 
>         Enhance run-jsc-stress-tests to allow a test to specify test specific options required for it to run.
>diff --git a/LayoutTests/http/tests/navigation/https-no-store-subframe-in-page-cache.html b/LayoutTests/http/tests/navigation/https-no-store-subframe-in-page-cache.html
>index c24cb594bc1533f5ac02ccba95f6f6a064166c4c..9071ba3fa948931d2b651b568d373561ec671356 100644
>--- a/LayoutTests/http/tests/navigation/https-no-store-subframe-in-page-cache.html
>+++ b/LayoutTests/http/tests/navigation/https-no-store-subframe-in-page-cache.html
>@@ -3,7 +3,6 @@
> if (window.testRunner) {
>     testRunner.dumpAsText();
>     testRunner.waitUntilDone();
>-    testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
> }
> 
> if (location.protocol != "https:")
>diff --git a/LayoutTests/http/tests/navigation/resources/https-no-store-subframe-in-page-cache.html b/LayoutTests/http/tests/navigation/resources/https-no-store-subframe-in-page-cache.html
>index 636d1186ebb4c96aabfcd3880c2a426b67b6bc9d..cc14d6750cbcf2ffb3d2af1024a63f727a482d6d 100644
>--- a/LayoutTests/http/tests/navigation/resources/https-no-store-subframe-in-page-cache.html
>+++ b/LayoutTests/http/tests/navigation/resources/https-no-store-subframe-in-page-cache.html
>@@ -13,6 +13,9 @@ window.onpageshow = function(evt)
> 
> window.onload = function()
> {
>+    if (window.testRunner)
>+        testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
>+
>     if (window.sessionStorage.https_in_page_cache_started) {
>         alert("FAIL: The page was reloaded on back. It should NOT have been.");
>         if (window.testRunner)

Actions: View | Formatted Diff | Diff

Attachments on bug 186440: 342311