Attachment 342309 Details for Bug 186405 – PATCH

[patch] PATCH

186405.diff (text/plain), 1.75 KB, created by Basuke Suzuki on 2018-06-08 13:05:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2018-06-08 13:05:36 PDT

Size: 1.75 KB

patch

obsolete

>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index d2fbb2d902a..e751943f34e 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-06-08  Basuke Suzuki  <Basuke.Suzuki@sony.com>
>+
>+        [Win] Fix initial value of HANDLE to INVALID_HANDLE_VALUE
>+        https://bugs.webkit.org/show_bug.cgi?id=186405
>+
>+        The handle was not initialized at all. Initialized with INVALID_HANDLE_VALUE.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Platform/IPC/Attachment.h:
>+        * Platform/IPC/win/AttachmentWin.cpp:
>+        (IPC::Attachment::decode):
>+
> 2018-06-07  Chris Dumez  <cdumez@apple.com>
> 
>         Add base class to get WeakPtrFactory member and avoid some boilerplate code
>diff --git a/Source/WebKit/Platform/IPC/Attachment.h b/Source/WebKit/Platform/IPC/Attachment.h
>index 3fe9887ef4e..5ff41d29510 100644
>--- a/Source/WebKit/Platform/IPC/Attachment.h
>+++ b/Source/WebKit/Platform/IPC/Attachment.h
>@@ -98,7 +98,7 @@ private:
>     mach_port_name_t m_port;
>     mach_msg_type_name_t m_disposition;
> #elif OS(WINDOWS)
>-    HANDLE m_handle;
>+    HANDLE m_handle { INVALID_HANDLE_VALUE };
> #endif
> };
> 
>diff --git a/Source/WebKit/Platform/IPC/win/AttachmentWin.cpp b/Source/WebKit/Platform/IPC/win/AttachmentWin.cpp
>index 50cb544abcb..b0ac81cf401 100644
>--- a/Source/WebKit/Platform/IPC/win/AttachmentWin.cpp
>+++ b/Source/WebKit/Platform/IPC/win/AttachmentWin.cpp
>@@ -67,7 +67,7 @@ static bool getDuplicatedHandle(HANDLE sourceHandle, DWORD sourcePID, HANDLE& du
> 
> bool Attachment::decode(Decoder& decoder, Attachment& attachment)
> {
>-    ASSERT_ARG(attachment, !attachment.m_handle);
>+    ASSERT_ARG(attachment, attachment.m_handle == INVALID_HANDLE_VALUE);
> 
>     uint64_t sourceHandle;
>     if (!decoder.decode(sourceHandle))

Actions: View | Formatted Diff | Diff

Attachments on bug 186405: 342309