WebKit Bugzilla
Attachment 342301 Details for
Bug 185698
: Layout Test svg/dom/animated-tearoff-list-remove-target.html is a flaky timeout
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-185698-20180608114559.patch (text/plain), 3.91 KB, created by
Said Abou-Hallawa
on 2018-06-08 11:45:59 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Said Abou-Hallawa
Created:
2018-06-08 11:45:59 PDT
Size:
3.91 KB
patch
obsolete
>Index: LayoutTests/ChangeLog >=================================================================== >--- LayoutTests/ChangeLog (revision 232629) >+++ LayoutTests/ChangeLog (working copy) >@@ -1,3 +1,27 @@ >+2018-06-08 Said Abou-Hallawa <sabouhallawa@apple.com> >+ >+ Layout Test svg/dom/animated-tearoff-list-remove-target.html is a flaky timeout >+ https://bugs.webkit.org/show_bug.cgi?id=185698 >+ <rdar://problem/40341200> >+ >+ The test is flaky because we get animVal.getItem(0) of an SVG list attribute >+ of the target element without initializing this attribute with a base value. >+ >+ The test was assuming that the animator would set the animVal from the >+ 'from' attribute of the <animate> element before getting animVal.getItem(0). >+ But this order of operations may not be fulfilled always. Therefore the >+ test was getting the exception IndexSizeError and it was timing out. >+ >+ The fix can be one of the following or both: >+ -- Initialize the attribute of the target element by a base value. >+ -- Make the animation run for some time before getting animVal.getItem(0). >+ And to make the test verify a more complex scenario, let it run for more >+ extra time after kicking off the GC. >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * svg/dom/animated-tearoff-list-remove-target.html: >+ > 2018-06-07 Mark Lam <mark.lam@apple.com> > > Enhance run-jsc-stress-tests to allow a test to specify test specific options required for it to run. >Index: LayoutTests/svg/dom/animated-tearoff-list-remove-target.html >=================================================================== >--- LayoutTests/svg/dom/animated-tearoff-list-remove-target.html (revision 232627) >+++ LayoutTests/svg/dom/animated-tearoff-list-remove-target.html (working copy) >@@ -3,10 +3,10 @@ > <div>Removing the target of an animate element should detach the wrappers of the attributes from their animated properties.</div> > <svg> > <text x="15" y="40"> >- <tspan id="first-tspan">First tspan.</tspan> >+ <tspan id="first-tspan" x="0">First tspan.</tspan> > </text> > <text x="15" y="60"> >- <tspan id="second-tspan">Second tspan</tspan> >+ <tspan id="second-tspan" x="0">Second tspan</tspan> > </text> > <animate id="animate" xlink:href="#first-tspan" attributeType="XML" attributeName="x" from="0" to="100" dur="10s" repeatCount="indefinite"/> > </svg> >@@ -33,6 +33,7 @@ > // animItem is a reference (not a copy) to the first item in the x animated list. > var animList = tspanElement.x.animVal; > var animItem = animList.getItem(0); >+ var valueAsString = animItem.valueAsString; > > // Now change the target of the <animate> element to be the "second-tspan". > var animateElement = document.getElementById("animate"); >@@ -41,14 +42,16 @@ > // By now animItem should be detached from the animated animList and has its own copy > // of an SVGLength. animItem should not be affected if garbage collection is forced. > gc(); >- if (animItem.valueAsString == "0") { >- document.querySelector("div").innerHTML += "<br><br>PASS." >- document.querySelector("svg").remove(); >- } >- >- if (window.testRunner) >- testRunner.notifyDone(); >- }, 0); >+ setTimeout(() => { >+ if (animItem.valueAsString == valueAsString) { >+ document.querySelector("div").innerHTML += "<br><br>PASS." >+ document.querySelector("svg").remove(); >+ } >+ >+ if (window.testRunner) >+ testRunner.notifyDone(); >+ }, 50); >+ }, 50); > })(); > </script> > </body>
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 185698
:
342301
|
342331
|
342349
|
342460
|
342468
|
342482