WebKit Bugzilla
Attachment 342240 Details for
Bug 186426
: Related task may not have a metric or platform.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-186426-20180607215106.patch (text/plain), 2.31 KB, created by
dewei_zhu
on 2018-06-07 21:51:07 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
dewei_zhu
Created:
2018-06-07 21:51:07 PDT
Size:
2.31 KB
patch
obsolete
>Subversion Revision: 232614 >diff --git a/Websites/perf.webkit.org/ChangeLog b/Websites/perf.webkit.org/ChangeLog >index 1308a05e3084b1b57db9603d839ee116061dc7d5..02f149af81589477a7acb9f495d69185ce362fd2 100644 >--- a/Websites/perf.webkit.org/ChangeLog >+++ b/Websites/perf.webkit.org/ChangeLog >@@ -1,3 +1,16 @@ >+2018-06-07 Dewei Zhu <dewei_zhu@apple.com> >+ >+ Related task may not have a metric or platform. >+ https://bugs.webkit.org/show_bug.cgi?id=186426 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Related task in the related task list can be a custom analysis task which >+ may not have platform or metric. >+ >+ * public/v3/pages/analysis-task-page.js: Added null checks for platform and metric. >+ (AnalysisTaskPage.prototype._renderRelatedTasks): >+ > 2018-06-07 Dewei Zhu <dewei_zhu@apple.com> > > Fix browser test failed assertions and a bug in 'common-component-base' >diff --git a/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js b/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js >index 14e3a729ac01aef4f0898b629e5886ff53b7a318..0f7089f284c138d83b452f8f6221e9a4b50077b5 100644 >--- a/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js >+++ b/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js >@@ -704,9 +704,9 @@ class AnalysisTaskPage extends PageWithHeading { > this.renderReplace(this.content('related-tasks-list'), (task && relatedTasks ? relatedTasks : []).map((otherTask) => { > let suffix = ''; > const taskLabel = otherTask.label(); >- if (otherTask.metric() != task.metric() && taskLabel.indexOf(otherTask.metric().label()) < 0) >+ if (otherTask.metric() && otherTask.metric() != task.metric() && taskLabel.indexOf(otherTask.metric().label()) < 0) > suffix += ` with "${otherTask.metric().label()}"`; >- if (otherTask.platform() != task.platform() && taskLabel.indexOf(otherTask.platform().label()) < 0) >+ if (otherTask.platform() && otherTask.platform() != task.platform() && taskLabel.indexOf(otherTask.platform().label()) < 0) > suffix += ` on ${otherTask.platform().label()}`; > return element('li', [link(taskLabel, this.router().url(`analysis/task/${otherTask.id()}`)), suffix]); > }));
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
rniwa
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 186426
: 342240