Attachment 342227 Details for Bug 186420 – Patch

[patch] Patch

bug-186420-20180607183445.patch (text/plain), 5.62 KB, created by Chris Dumez on 2018-06-07 18:34:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-06-07 18:34:46 PDT

Size: 5.62 KB

patch

obsolete

>Subversion Revision: 232584
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2bd09496e890ffc8f8ae05252fee2b33c94b9826..07b3648d8cab7fd063e650e3c90b07df6f97405e 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-06-07  Chris Dumez  <cdumez@apple.com>
>+
>+        PopStateEvent should not be cancelable by default
>+        https://bugs.webkit.org/show_bug.cgi?id=186420
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        PopStateEvent should not be cancelable by default:
>+        - https://github.com/web-platform-tests/wpt/pull/11355
>+        - https://html.spec.whatwg.org/#history-traversal
>+
>+        All other browsers agree with the specification.
>+
>+        No new tests, updated existing tests.
>+
>+        * dom/PopStateEvent.cpp:
>+        (WebCore::PopStateEvent::PopStateEvent):
>+
> 2018-06-07  Brent Fulgham  <bfulgham@apple.com>
> 
>         Handle Storage Access API calls in the absence of an attached frame
>diff --git a/Source/WebCore/dom/PopStateEvent.cpp b/Source/WebCore/dom/PopStateEvent.cpp
>index 57190c8d2da8a76b54228b34866d4a696634a4f6..82995f046d6b0dd047d5d2491ebeb70b39eac4bd 100644
>--- a/Source/WebCore/dom/PopStateEvent.cpp
>+++ b/Source/WebCore/dom/PopStateEvent.cpp
>@@ -40,7 +40,7 @@ PopStateEvent::PopStateEvent(const AtomicString& type, const Init& initializer,
> }
> 
> PopStateEvent::PopStateEvent(RefPtr<SerializedScriptValue>&& serializedState, History* history)
>-    : Event(eventNames().popstateEvent, false, true)
>+    : Event(eventNames().popstateEvent, false, false)
>     , m_serializedState(WTFMove(serializedState))
>     , m_history(history)
> {
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index 5a93191889e5049d1c39fde137cd84bbda1bd4cb..86d4036796f50b4f5d724208bd9891e62d034b14 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-06-07  Chris Dumez  <cdumez@apple.com>
>+
>+        PopStateEvent should not be cancelable by default
>+        https://bugs.webkit.org/show_bug.cgi?id=186420
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Resync web-platform-tests after:
>+        https://github.com/web-platform-tests/wpt/pull/11355
>+
>+        * web-platform-tests/html/browsers/browsing-the-web/history-traversal/hashchange_event-expected.txt:
>+        * web-platform-tests/html/browsers/browsing-the-web/history-traversal/hashchange_event.html:
>+        * web-platform-tests/html/browsers/browsing-the-web/history-traversal/popstate_event.html:
>+
> 2018-06-06  Youenn Fablet  <youenn@apple.com>
> 
>         HTTP Header values validation is too strict
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/hashchange_event-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/hashchange_event-expected.txt
>index b475a3dd7d261f642000446a0c40ad957051833e..5c27d0d822e8e2fcd754a4be850dad4a15fda2dc 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/hashchange_event-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/hashchange_event-expected.txt
>@@ -1,3 +1,3 @@
> 
>-FAIL Queue a task to fire hashchange event assert_true: bubble expected true got false
>+PASS Queue a task to fire hashchange event 
> 
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/hashchange_event.html b/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/hashchange_event.html
>index 287e7a6ef1d6c0fa6cdb3f1300bcbd3964a9c93e..b7111255f8b82421d8a1e9f91d2b514194a4c50b 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/hashchange_event.html
>+++ b/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/hashchange_event.html
>@@ -18,11 +18,11 @@ window.onload = t.step_func(function () {
> 
>   location.hash = 'foo';
>   window.onhashchange = t.step_func(function (e) {
>-    assert_true(e.isTrusted);
>-    assert_equals(e.target, window);
>-    assert_equals(e.type, "hashchange");
>-    assert_true(e instanceof HashChangeEvent);
>-    assert_true(e.bubbles, "bubble");
>+    assert_true(e.isTrusted, "isTrusted");
>+    assert_equals(e.target, window, "target");
>+    assert_equals(e.type, "hashchange", "type");
>+    assert_true(e instanceof HashChangeEvent, "is HashChangeEvent");
>+    assert_false(e.bubbles, "bubbles");
>     assert_false(e.cancelable, "cancelable");
>     oldURLs.push(e.oldURL);
>     newURLs.push(e.newURL);
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/popstate_event.html b/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/popstate_event.html
>index 7630b99184362527dc26de42e32238d78dfca094..a41fabf9686cda0a6299c5b8bc3ab6d03ff3b627 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/popstate_event.html
>+++ b/LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/popstate_event.html
>@@ -15,6 +15,13 @@ window.onload = t.step_func(function () {
> 
>   history.back();
>   window.onpopstate = t.step_func(function (e) {
>+    assert_true(e.isTrusted, "isTrusted");
>+    assert_equals(e.target, window, "target");
>+    assert_equals(e.type, "popstate", "type");
>+    assert_true(e instanceof PopStateEvent, "is PopStateEvent");
>+    assert_false(e.bubbles, "bubbles");
>+    assert_false(e.cancelable, "cancelable");
>+
>     states.push(e.state);
> 
>     if (states.length === 2) {

Actions: View | Formatted Diff | Diff

Attachments on bug 186420: 342227