Attachment 342210 Details for Bug 186412 – Patch

[patch] Patch

bug-186412-20180608080453.patch (text/plain), 2.16 KB, created by Dean Jackson on 2018-06-07 15:04:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dean Jackson

Created: 2018-06-07 15:04:54 PDT

Size: 2.16 KB

patch

obsolete

>Subversion Revision: 232551
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 9b2ece8e41ed6a545ca940a6557584c25a5b5db7..468b0243fe8be9f29ff1a107daecd0652b0e4290 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-06-07  Dean Jackson  <dino@apple.com>
>+
>+        Match HI spec for thumbnail view sizing and location
>+        https://bugs.webkit.org/show_bug.cgi?id=186412
>+        <rdar://problem/40226192>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Use the computed obscured inset to position the QuickLook
>+        view inside the WKSystemPreviewView.
>+
>+        * UIProcess/ios/WKSystemPreviewView.mm:
>+        (-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]):
>+        (-[WKSystemPreviewView _layoutThumbnailView]):
>+
> 2018-06-06  Jer Noble  <jer.noble@apple.com>
> 
>         REGRESSION (r232301) - Unable to enter video fullscreen
>diff --git a/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm b/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm
>index 836b369bb9d316b0eb3855e58777f2f8f957aa13..7b012a9e73b5cf1601c5bf1577f60d3a106b15d9 100644
>--- a/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm
>+++ b/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm
>@@ -128,7 +128,11 @@ SOFT_LINK_CLASS(AssetViewer, ASVThumbnailView);
> {
>     if (_thumbnailView) {
>         UIEdgeInsets safeAreaInsets = _webView._computedUnobscuredSafeAreaInset;
>-        CGRect layoutFrame = CGRectMake(0, 0, self.frame.size.width - safeAreaInsets.left - safeAreaInsets.right, self.frame.size.height - safeAreaInsets.top - safeAreaInsets.bottom);
>+        UIEdgeInsets obscuredAreaInsets = _webView._computedObscuredInset;
>+
>+        CGRect layoutFrame = CGRectMake(safeAreaInsets.left, safeAreaInsets.top,
>+            self.frame.size.width - safeAreaInsets.left - safeAreaInsets.right - obscuredAreaInsets.left - obscuredAreaInsets.right,
>+            self.frame.size.height - safeAreaInsets.top - safeAreaInsets.bottom - obscuredAreaInsets.top - obscuredAreaInsets.bottom);
>         [_thumbnailView setFrame:layoutFrame];
>         [_thumbnailView setAutoresizingMask:UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight];
>     }

Flags:

thorton: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 186412: 342210