Attachment 342203 Details for Bug 186408 – Patch

[patch] Patch

bug-186408-20180607135045.patch (text/plain), 1.97 KB, created by Tim Horton on 2018-06-07 13:50:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Horton

Created: 2018-06-07 13:50:46 PDT

Size: 1.97 KB

patch

obsolete

>Subversion Revision: 232591
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index bf01846e6ec32192e8ca85dbef526956c767e4f7..14bce86f0fd31f6033be1334caaa805ffded9e7c 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-06-07  Tim Horton  <timothy_horton@apple.com>
>+
>+        REGRESSION (r232544): Pages are blank after homing out and then resuming on iPad
>+        https://bugs.webkit.org/show_bug.cgi?id=186408
>+        <rdar://problem/40907111>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/Cocoa/WKWebView.mm:
>+        (-[WKWebView _resizeWhileHidingContentWithUpdates:]):
>+        Clients who use _resizeWhileHidingContentWithUpdates don't call
>+        _endAnimatedResize; the former API is a one-shot. We can't wait for
>+        _endAnimatedResize to complete the animation (and don't need to, since
>+        the content is hidden), but instead should just finish it when the
>+        commit with the resized tiles arrives.
>+
> 2018-06-07  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Release assert in Document::updateLayout() in WebPage::determinePrimarySnapshottedPlugIn()
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>index c65632c7e3ccb73b918e7502ff8b99ced275a45a..3427d4ae5e3ef39a60aaef24d1cdd7f034b89115 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
>@@ -5375,6 +5375,10 @@ - (void)_resizeWhileHidingContentWithUpdates:(void (^)(void))updateBlock
>     if (_dynamicViewportUpdateMode == WebKit::DynamicViewportUpdateMode::ResizingWithAnimation) {
>         [_contentView setHidden:YES];
>         _dynamicViewportUpdateMode = WebKit::DynamicViewportUpdateMode::ResizingWithDocumentHidden;
>+        
>+        // _resizeWhileHidingContentWithUpdates is used by itself; the client will
>+        // not call endAnimatedResize, so we can't wait for it.
>+        _waitingForEndAnimatedResize = NO;
>     }
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 186408: 342203