Attachment 342198 Details for Bug 186376 – Patch for landing

[patch] Patch for landing

bug-186376-20180607120859.patch (text/plain), 1.93 KB, created by Jiewen Tan on 2018-06-07 12:09:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jiewen Tan

Created: 2018-06-07 12:09:00 PDT

Size: 1.93 KB

patch

obsolete

>Subversion Revision: 232531
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 644b63a735cf83118ef5a4f2d2f641bd280ef0f9..eae1a717bea0f1d67cedf3a2381af107f52cd926 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,21 @@
>+2018-06-06  Jiewen Tan  <jiewen_tan@apple.com>
>+
>+        Use the same overloaded addInputString in WKContentViewInteraction
>+        https://bugs.webkit.org/show_bug.cgi?id=186376
>+        <rdar://problem/18498360>
>+
>+        Reviewed by Brent Fulgham.
>+
>+        Different overloaded variants of [UIKeyboardImpl -addInputString] behaves differently. We should use the same
>+        overloaded variant consistently: [UIKeyboardImpl -addInputString:withFlags:withInputManagerHint:].
>+
>+        Sadly, there is no test case for this change as:
>+        1) UIScriptController has troubles simulating '\r' keyboard event, and
>+        2) API test couldn't simulate proper UI keyboard events.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView _interpretKeyEvent:isCharEvent:]):
>+
> 2018-06-05  Keith Rollin  <krollin@apple.com>
> 
>         Remove tracksResourceLoadMilestones support
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index ea1080b8dd712e007e82e275d3fe2cb5a06ae5b1..d6d7f362e7960916661205adc6e3b1dfdecdc0d1 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -3742,7 +3742,7 @@ - (BOOL)_interpretKeyEvent:(::WebEvent *)event isCharEvent:(BOOL)isCharEvent
>     case kWebReturnKey:
>         if (contentEditable && isCharEvent) {
>             // Map \r from HW keyboard to \n to match the behavior of the soft keyboard.
>-            [keyboard addInputString:@"\n" withFlags:0];
>+            [keyboard addInputString:@"\n" withFlags:0 withInputManagerHint:nil];
>             return YES;
>         }
>         break;

Actions: View | Formatted Diff | Diff

Attachments on bug 186376: 342104 | 342127 | 342198