Attachment 342195 Details for Bug 186395 – Patch

[patch] Patch

bug-186395-20180607114535.patch (text/plain), 2.23 KB, created by Tim Horton on 2018-06-07 11:45:36 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Horton

Created: 2018-06-07 11:45:36 PDT

Size: 2.23 KB

patch

obsolete

>Subversion Revision: 232515
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 2d0492fb0a5484ddfc4f79462544def858ffea7d..997419b74be0f8ae1f9784e14925ba3e175069d4 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-06-07  Tim Horton  <timothy_horton@apple.com>
>+
>+        REGRESSION (r232544): [iOS] TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnimatedResizeSucceed is failing
>+        https://bugs.webkit.org/show_bug.cgi?id=186395
>+        <rdar://problem/40902427>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
>+        (TEST):
>+        endAnimatedResize no longer synchronizes, so we have to wait for the next presentation update.
>+
> 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
> 
>         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
>diff --git a/Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm b/Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm
>index 5d292cb169358f0ab55d5353f2f650fc975f5144..0d14ed71e5d3c45c08905711790718d94fb4baa8 100644
>--- a/Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm
>+++ b/Tools/TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm
>@@ -208,15 +208,19 @@ TEST(WebKit, OverrideLayoutSizeChangesDuringAnimatedResizeSucceed)
>     [webView _endAnimatedResize];
> 
>     __block bool didReadLayoutSize = false;
>-    [webView evaluateJavaScript:@"[window.innerWidth, window.innerHeight]" completionHandler:^(id value, NSError *error) {
>-        CGFloat innerWidth = [[value objectAtIndex:0] floatValue];
>-        CGFloat innerHeight = [[value objectAtIndex:1] floatValue];
> 
>-        EXPECT_EQ(innerWidth, 100);
>-        EXPECT_EQ(innerHeight, 200);
>+    [webView _doAfterNextPresentationUpdate:^{
>+        [webView evaluateJavaScript:@"[window.innerWidth, window.innerHeight]" completionHandler:^(id value, NSError *error) {
>+            CGFloat innerWidth = [[value objectAtIndex:0] floatValue];
>+            CGFloat innerHeight = [[value objectAtIndex:1] floatValue];
> 
>-        didReadLayoutSize = true;
>+            EXPECT_EQ(innerWidth, 100);
>+            EXPECT_EQ(innerHeight, 200);
>+
>+            didReadLayoutSize = true;
>+        }];
>     }];
>+    
>     TestWebKitAPI::Util::run(&didReadLayoutSize);
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 186395: 342195