Attachment 342194 Details for Bug 186402 – Patch

[patch] Patch

bug-186402-20180607113957.patch (text/plain), 1.87 KB, created by Alex Christensen on 2018-06-07 11:40:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-06-07 11:40:01 PDT

Size: 1.87 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 232587)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-06-07  Alex Christensen  <achristensen@webkit.org>
>+
>+        REGRESSION(r224134) Client certificate challenges don't always appear
>+        https://bugs.webkit.org/show_bug.cgi?id=186402
>+        <rdar://problem/35967150>
>+
>+        Reviewed by Brian Weinstein.
>+
>+        * NetworkProcess/NetworkLoad.cpp:
>+        (WebKit::NetworkLoad::completeAuthenticationChallenge):
>+        Add an exception for all TLS-handshake-related challenges, not just server trust.
>+
> 2018-06-04  Kocsen Chung  <kocsen_chung@apple.com>
> 
>         Apply patch. rdar://problem/40688638
>Index: Source/WebKit/NetworkProcess/NetworkLoad.cpp
>===================================================================
>--- Source/WebKit/NetworkProcess/NetworkLoad.cpp	(revision 232579)
>+++ Source/WebKit/NetworkProcess/NetworkLoad.cpp	(working copy)
>@@ -337,8 +337,10 @@ void NetworkLoad::didReceiveChallenge(co
> 
> void NetworkLoad::completeAuthenticationChallenge(ChallengeCompletionHandler&& completionHandler)
> {
>-    bool isServerTrustEvaluation = m_challenge->protectionSpace().authenticationScheme() == ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested;
>-    if (!isAllowedToAskUserForCredentials() && !isServerTrustEvaluation) {
>+    auto scheme = m_challenge->protectionSpace().authenticationScheme();
>+    bool isTLSHandshake = scheme == ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested
>+        || scheme == ProtectionSpaceAuthenticationSchemeClientCertificateRequested;
>+    if (!isAllowedToAskUserForCredentials() && !isTLSHandshake) {
>         m_client.get().didBlockAuthenticationChallenge();
>         completionHandler(AuthenticationChallengeDisposition::UseCredential, { });
>         return;

Actions: View | Formatted Diff | Diff

Attachments on bug 186402: 342189 | 342194